Page MenuHomePhabricator

Fail on the use of special pages Special:SetAliases and Special:SetLabelDescriptionAliases with aliases containing | character
Closed, ResolvedPublic5 Story Points

Description

When Special:SetAliases or Special:SetLabelDescriptionAliases is given an item or a property that already has an alias containing | save action should fail with the error message TODO and the situation should be track to be able to reason on the severity of the problem.

Details

Event Timeline

WMDE-leszek renamed this task from Track the use of special pages Special:SetAliases and Special:SetLabelDescriptionAliases with aliases containing | character to Error on the use of special pages Special:SetAliases and Special:SetLabelDescriptionAliases with aliases containing | character.May 14 2019, 1:12 PM
WMDE-leszek renamed this task from Error on the use of special pages Special:SetAliases and Special:SetLabelDescriptionAliases with aliases containing | character to Fail on the use of special pages Special:SetAliases and Special:SetLabelDescriptionAliases with aliases containing | character.
WMDE-leszek created this task.
WMDE-leszek updated the task description. (Show Details)
WMDE-leszek updated the task description. (Show Details)
WMDE-leszek set the point value for this task to 5.May 14 2019, 1:17 PM
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptMay 14 2019, 4:31 PM

Change 510215 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Fail Special:SetAliases and Special:SetLabelDescriptionAliases with aliases containing | character

https://gerrit.wikimedia.org/r/510215

noarave claimed this task.May 27 2019, 1:07 PM
noarave added a subscriber: Ladsgroup.
Restricted Application added a project: User-Noarave. · View Herald TranscriptMay 27 2019, 1:07 PM

Change 510215 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fail Special:SetAliases and Special:SetLabelDescriptionAliases with aliases containing | character

https://gerrit.wikimedia.org/r/510215

+++ Steps to verify +++

Prerequisits:

  • Mediawiki Docker setup (or access to log files in other setup)
  • LocalSettings.php includes a path to your log file like so: $wgDebugLogFile = "/var/log/mediawiki/debug.log";
  1. Start your containers
  2. Through the js editing layer add an alias with pipes to an exisitng item
  3. then got to SetAliases through the special page (in my case it looks like this: http://default.web.mw.localhost:8080/mediawiki/index.php?title=Special:SetAliases/Q180)
  4. try to save the alias using the set aliases button -> an error message appears
  5. Enter the container in the mw docker directory, ./bash
  6. navigate to the path where your log ffile lies and type: tail -f debug.log | grep SetAliases

You should see a log message indicating there was a save attempt for aliases with pipes.
(points 3-6 could be repeated for Special:SetLabelDescriptionAliases)

  • Mediawiki Docker setup (or access to log files in other setup)

should it be not clear, https://github.com/addshore/mediawiki-docker-dev is what WMDE uses

  • Mediawiki Docker setup (or access to log files in other setup)

should it be not clear, https://github.com/addshore/mediawiki-docker-dev is what WMDE uses

It now should be testable in beta cluster, right?

It now should be testable in beta cluster, right?

of course #facepalm . How do we check logs on Beta cluster?

It now should be testable in beta cluster, right?

of course #facepalm . How do we check logs on Beta cluster?

https://logstash-beta.wmflabs.org/ If you need access to the cluster, let me know.