When Special:SetAliases or Special:SetLabelDescriptionAliases is given an item or a property that already has an alias containing | save action should fail with the error message TODO and the situation should be track to be able to reason on the severity of the problem.
Description
Details
Event Timeline
Change 510215 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Fail Special:SetAliases and Special:SetLabelDescriptionAliases with aliases containing | character
Change 510215 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fail Special:SetAliases and Special:SetLabelDescriptionAliases with aliases containing | character
+++ Steps to verify +++
Prerequisits:
- Mediawiki Docker setup (or access to log files in other setup)
- LocalSettings.php includes a path to your log file like so: $wgDebugLogFile = "/var/log/mediawiki/debug.log";
- Start your containers
- Through the js editing layer add an alias with pipes to an exisitng item
- then got to SetAliases through the special page (in my case it looks like this: http://default.web.mw.localhost:8080/mediawiki/index.php?title=Special:SetAliases/Q180)
- try to save the alias using the set aliases button -> an error message appears
- Enter the container in the mw docker directory, ./bash
- navigate to the path where your log ffile lies and type: tail -f debug.log | grep SetAliases
You should see a log message indicating there was a save attempt for aliases with pipes.
(points 3-6 could be repeated for Special:SetLabelDescriptionAliases)
should it be not clear, https://github.com/addshore/mediawiki-docker-dev is what WMDE uses
It now should be testable in beta cluster, right?
of course #facepalm . How do we check logs on Beta cluster?