ApiVisualEditor.php: PHP Notice: Undefined variable: restbaseHeaders
Closed, ResolvedPublic
Actions

Description

Error

Request URL: https://en.wikipedia.org/w/api.php?action=visualeditor&format=json&paction=metadata&page=Kilbirnie&uselang=en&formatversion=2
Request ID: INSERT_ID

message

[{exception_id}] {exception_url} ErrorException from line 599 of /srv/mediawiki/php-1.34.0-wmf.4/extensions/VisualEditor/includes/ApiVisualEditor.php: PHP Notice: Undefined variable: restbaseHeaders

trace

#0 /srv/mediawiki/php-1.34.0-wmf.4/extensions/VisualEditor/includes/ApiVisualEditor.php(599): MWExceptionHandler::handleError(integer, string, string, integer, array, array)
#1 /srv/mediawiki/php-1.34.0-wmf.4/includes/api/ApiMain.php(1593): ApiVisualEditor->execute()
#2 /srv/mediawiki/php-1.34.0-wmf.4/includes/api/ApiMain.php(531): ApiMain->executeAction()
#3 /srv/mediawiki/php-1.34.0-wmf.4/includes/api/ApiMain.php(502): ApiMain->executeActionWithErrorHandling()
#4 /srv/mediawiki/php-1.34.0-wmf.4/api.php(87): ApiMain->execute()
#5 /srv/mediawiki/w/api.php(3): include(string)
#6 {main}

Impact

Notes

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Initialize $restbaseHeaders to null	mediawiki/extensions/VisualEditor	wmf/1.34.0-wmf.5	+1 -0
Initialize $restbaseHeaders to null	mediawiki/extensions/VisualEditor	wmf/1.34.0-wmf.4	+1 -0
Initialize $restbaseHeaders to null	mediawiki/extensions/VisualEditor	master	+1 -0

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved	Release	hashar	T220730 1.34.0-wmf.5 deployment blockers
Resolved		Esanders	T223023 Switching from source to visual editing in mobile web removes all other sections
Resolved		Esanders	T223281 [{exception_id}] {exception_url} ErrorException from line 599 of /srv/mediawiki/php-1.34.0-wmf.4/extensions/VisualEditor/includes/ApiVisualEditor.php: PHP Notice: Undefined variable: restbaseHeaders

Event Timeline

Started today on May 14th at roughly 12:35 UTC

Potentially with ?

12:37 <jforrester@deploy1001> Synchronized php-1.34.0-wmf.4/extensions/VisualEditor/: Hot-deploy T223023 fix I1b35b28e42 for mobile VE edit section switches (duration: 00m 54s)

hashar mentioned this in T223023: Switching from source to visual editing in mobile web removes all other sections.May 14 2019, 2:59 PM

hashar added a parent task: T223023: Switching from source to visual editing in mobile web removes all other sections.

I believe https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/503651 is the reason.

Change 510176 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Initialize $restbaseHeaders to null

https://gerrit.wikimedia.org/r/510176

gerritbot added a project: Patch-For-Review.May 14 2019, 3:08 PM

Change 510176 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Initialize $restbaseHeaders to null

https://gerrit.wikimedia.org/r/510176

Change 510180 had a related patch set uploaded (by Jforrester; owner: Esanders):
[mediawiki/extensions/VisualEditor@wmf/1.34.0-wmf.5] Initialize $restbaseHeaders to null

https://gerrit.wikimedia.org/r/510180

Change 510181 had a related patch set uploaded (by Jforrester; owner: Esanders):
[mediawiki/extensions/VisualEditor@wmf/1.34.0-wmf.4] Initialize $restbaseHeaders to null

https://gerrit.wikimedia.org/r/510181

Jdforrester-WMF added a project: VisualEditor-MediaWiki.May 14 2019, 3:27 PM

Change 510181 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.34.0-wmf.4] Initialize $restbaseHeaders to null

https://gerrit.wikimedia.org/r/510181

Change 510180 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.34.0-wmf.5] Initialize $restbaseHeaders to null

https://gerrit.wikimedia.org/r/510180

Mentioned in SAL (#wikimedia-operations) [2019-05-14T15:51:42Z] <jforrester@deploy1001> Synchronized php-1.34.0-wmf.5/extensions/VisualEditor/includes/ApiVisualEditor.php: Hot-deploy VE unset variable fix T223281 (duration: 00m 57s)

Mentioned in SAL (#wikimedia-operations) [2019-05-14T15:56:14Z] <jforrester@deploy1001> Synchronized php-1.34.0-wmf.4/extensions/VisualEditor/includes/ApiVisualEditor.php: Hot-deploy VE unset variable fix T223281 (duration: 00m 55s)

Last recorded error at 2019-05-14T15:56:10. Seems now fixed.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMay 14 2019, 3:59 PM

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.6; 2019-05-21).May 14 2019, 4:00 PM

Confirmed. Thank you very much for the quick fix!

DannyS712 removed a project: Patch-For-Review.Apr 18 2020, 5:43 AM

[{exception_id}] {exception_url} ErrorException from line 599 of /srv/mediawiki/php-1.34.0-wmf.4/extensions/VisualEditor/includes/ApiVisualEditor.php: PHP Notice: Undefined variable: restbaseHeadersClosed, ResolvedPublicActions