Page MenuHomePhabricator
Create Task
Maniphest T225165

Potentially fragile test in GrowthExperiments
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

We don't know if it's still failing, but there was no clear fix committed recently, so it's likely that the test is too fragile:

Patch affected: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/FileImporter/+/514438/
Log: https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php70-docker/22340/consoleFull

14:25:30 Failed asserting that two strings are equal.
14:25:30 --- Expected
14:25:30 +++ Actual
14:25:30 @@ @@
14:25:30 -'(3)'
14:25:30 +'19)'
14:25:30 
14:25:30 /workspace/src/extensions/GrowthExperiments/tests/phpunit/HelpModuleQuestionPosterTest.php:117
14:25:30 /workspace/src/tests/phpunit/MediaWikiTestCase.php:427
14:25:30 /workspace/src/maintenance/doMaintenance.php:99

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Make section numbering test unit instead of integrationmediawiki/extensions/GrowthExperimentsmaster+60 -60
Disable flaky testmediawiki/extensions/GrowthExperimentsmaster+1 -0
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNoneT225162 Fix flapping tests in gated extensions as of 2019-06-06
 ResolvedPRODUCTION ERRORkostajhT225165 Potentially fragile test in GrowthExperiments

Event Timeline

awight created this task.Jun 5 2019, 10:18 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJun 5 2019, 10:18 PM
SBisson removed a project: Browser-Tests.Jun 5 2019, 11:58 PM
SBisson subscribed.

(Not a browser test)

We've seen it failing for the first time today and then it passed on recheck. There's indeed something fragile about it.

kostajh subscribed.Jun 6 2019, 1:21 AM
gerritbot added a comment.Jun 6 2019, 2:00 AM

Change 514639 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Disable flaky test

https://gerrit.wikimedia.org/r/514639

gerritbot added a project: Patch-For-Review.Jun 6 2019, 2:00 AM
hashar updated the task description. (Show Details)Jun 6 2019, 6:36 AM
hashar edited projects, added Wikimedia-production-error (ARCHIVED -- Shared Build Failure); removed Continuous-Integration-Config.
gerritbot added a comment.Jun 6 2019, 7:58 AM

Change 514639 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Disable flaky test

https://gerrit.wikimedia.org/r/514639

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.10; 2019-06-18).Jun 6 2019, 8:01 AM
Maintenance_bot removed a project: Patch-For-Review.Jun 6 2019, 8:10 AM
Krinkle moved this task from Untriaged to Resolved on the Wikimedia-production-error (ARCHIVED -- Shared Build Failure) board.Jun 10 2019, 3:22 PM
JTannerWMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Jun 11 2019, 6:04 PM
JTannerWMF subscribed.

We will take a look at this as a low-priority item for this sprint

JTannerWMF moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.Jun 11 2019, 6:04 PM
gerritbot added a comment.Jul 31 2019, 9:22 PM

Change 526784 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Make section numbering test unit instead of integration

https://gerrit.wikimedia.org/r/526784

gerritbot added a project: Patch-For-Review.Jul 31 2019, 9:22 PM
kostajh claimed this task.Jul 31 2019, 9:22 PM
kostajh moved this task from Ready for Development to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Aug 1 2019, 8:33 PM

Change 526784 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Make section numbering test unit instead of integration

https://gerrit.wikimedia.org/r/526784

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.17; 2019-08-06); removed MW-1.34-notes (1.34.0-wmf.10; 2019-06-18).Aug 1 2019, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 1 2019, 9:10 PM
kostajh closed this task as Resolved.Aug 12 2019, 1:33 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:06 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits