Page MenuHomePhabricator
Create Task
Maniphest T225359

MobileFrontend throws ConfigException when loading JS
Closed, ResolvedPublic
Actions

Description

When trying out mediawiki 1.33, i am seeing:

/w/load.php?lang=en&modules=startup&only=scripts&skin=timeless   ConfigException from line 53 of /srv/mediawiki/w/includes/config/GlobalVarConfig.php: GlobalVarConfig::get: undefined option: 'EnableBlockNoticeStats'
#0 /srv/mediawiki/w/extensions/MobileFrontend/includes/MobileFrontend.hooks.php(428): GlobalVarConfig->get(string)
#1 /srv/mediawiki/w/extensions/MobileFrontend/includes/modules/ResourceLoaderFileModuleWithMFConfig.php(16): MobileFrontendHooks::getResourceLoaderMFConfigVars()
#2 /srv/mediawiki/w/includes/resourceloader/ResourceLoaderModule.php(727): MobileFrontend\ResourceLoaderModules\ResourceLoaderFileModuleWithMFConfig->getScript(ResourceLoaderContext)
#3 /srv/mediawiki/w/includes/resourceloader/ResourceLoaderModule.php(694): ResourceLoaderModule->buildContent(ResourceLoaderContext)
#4 /srv/mediawiki/w/includes/resourceloader/ResourceLoaderModule.php(830): ResourceLoaderModule->getModuleContent(ResourceLoaderContext)
#5 /srv/mediawiki/w/includes/resourceloader/ResourceLoaderStartUpModule.php(255): ResourceLoaderModule->getVersionHash(ResourceLoaderContext)
#6 /srv/mediawiki/w/includes/resourceloader/ResourceLoaderStartUpModule.php(438): ResourceLoaderStartUpModule->getModuleRegistrations(ResourceLoaderContext)
#7 /srv/mediawiki/w/includes/resourceloader/ResourceLoaderModule.php(727): ResourceLoaderStartUpModule->getScript(ResourceLoaderContext)
#8 /srv/mediawiki/w/includes/resourceloader/ResourceLoaderModule.php(694): ResourceLoaderModule->buildContent(ResourceLoaderContext)
#9 /srv/mediawiki/w/includes/resourceloader/ResourceLoaderModule.php(830): ResourceLoaderModule->getModuleContent(ResourceLoaderContext)
#10 /srv/mediawiki/w/includes/resourceloader/ResourceLoader.php(658): ResourceLoaderModule->getVersionHash(ResourceLoaderContext)
#11 [internal function]: ResourceLoader->{closure}(string)
#12 /srv/mediawiki/w/includes/resourceloader/ResourceLoader.php(670): array_map(Closure, array)
#13 /srv/mediawiki/w/includes/resourceloader/ResourceLoader.php(751): ResourceLoader->getCombinedVersion(ResourceLoaderContext, array)
#14 /srv/mediawiki/w/load.php(46): ResourceLoader->respond(ResourceLoaderContext)
#15 {main}

In the logs, but in the js console i see "[6517215b23165c93329a295e] 2019-06-08 16:36:35: Fatal exception of type "ConfigException"".

Details

SubjectRepoBranchLines +/-
Remove block notice trackingmediawiki/extensions/MobileFrontendREL1_33+6 -28
Customize query in gerrit

Related Objects
Search...

Event Timeline

Paladox created this task.Jun 8 2019, 4:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 8 2019, 4:45 PM
Mainframe98 subscribed.Jun 8 2019, 4:50 PM

Probably the same as T225354: VisualEditor broken on REL1_33: "ConfigException: undefined option: 'EnableBlockNoticeStats'" - Likely already fixed in master, just needs a backport.

Part of T214214: Disable block notice tracking.

Paladox added a comment.Jun 8 2019, 4:50 PM

yup, found the commit that removes it on the master branch in MF, just not a easy back port as one of the files were renamed (https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/commit/eebdabe65c067dbcfd9ddf59ab283ddcdba61b40#diff-906c6ce0812fcfd8ccf583970a92df80)

gerritbot added a comment.Jun 8 2019, 4:53 PM

Change 515719 had a related patch set uploaded (by Paladox; owner: Dmaza):
[mediawiki/extensions/MobileFrontend@REL1_33] Remove block notice tracking

https://gerrit.wikimedia.org/r/515719

gerritbot added a project: Patch-For-Review.Jun 8 2019, 4:53 PM
matmarex mentioned this in T225354: VisualEditor broken on REL1_33: "ConfigException: undefined option: 'EnableBlockNoticeStats'".Jun 10 2019, 9:39 PM
matmarex subscribed.Jun 10 2019, 9:45 PM
In T225354#5248304, @matmarex wrote:

To clarify how it happened: the patch https://gerrit.wikimedia.org/r/c/mediawiki/core/+/506197 was backported, but the patches it relies on, that were marked with 'Depends-On' (in VisualEditor, and MobileFrontend – T225359) were not.

This probably should not have been possible, the 'Depends-On' should check only changes in the same branch. This is apparently already known as T210685: Depends-On should not work across branches.

matmarex mentioned this in T210685: Depends-On should not work across branches.Jun 10 2019, 9:46 PM
matmarex added a subtask: T189560: mediawiki/vendor REL1_* no longer ship dependencies for wmf extensions that are not in the mediawiki tarball.Jun 10 2019, 9:59 PM

We can't currently merge the fixes because of T189560.

ovasileva added a project: Web-Team-Backlog (Tracking).Jun 11 2019, 1:47 PM
Niharika added a project: Anti-Harassment.Jun 11 2019, 4:27 PM
Restricted Application added a subscriber: MGChecker. · View Herald TranscriptJun 11 2019, 4:27 PM
Niharika moved this task from Untriaged to Tracking work by others on the Anti-Harassment board.Jun 11 2019, 4:27 PM
Krinkle closed this task as a duplicate of T225354: VisualEditor broken on REL1_33: "ConfigException: undefined option: 'EnableBlockNoticeStats'".Jun 14 2019, 3:00 PM
matmarex reopened this task as Open.Jun 19 2019, 6:37 PM

I believe this should be tracked separately from T225354, because I was just able to get the patch for that issue to merge, while the patch here is still failing.

Jdforrester-WMF removed a project: MW-1.33-release.Jul 1 2019, 11:36 PM
Jdforrester-WMF subscribed.

We won't block the release of MW core on a MobileFrontend issue.

Kghbln subscribed.Jul 2 2019, 2:49 PM

I added a warning to the MobileFrontend and MediaWiki 1.33 pages about the incompatibility since this extension may be considered system relevant for many wikis.

gerritbot added a comment.Jul 2 2019, 2:59 PM

Change 515719 merged by Reedy:
[mediawiki/extensions/MobileFrontend@REL1_33] Remove block notice tracking

https://gerrit.wikimedia.org/r/515719

Reedy closed this task as Resolved.Jul 2 2019, 3:00 PM
Reedy assigned this task to Paladox.

Force merged the patch... Tests possibly not being fully right on REL1_33 is better than the whole extension actually being broken

Kghbln added a comment.Jul 2 2019, 6:27 PM

Thanks a lot! This specific error no longer appears. I have removed the respective notes from the wiki.

hashar closed subtask T189560: mediawiki/vendor REL1_* no longer ship dependencies for wmf extensions that are not in the mediawiki tarball as Resolved.Sep 3 2019, 10:19 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits