Page MenuHomePhabricator

Homepage: minor mobile instrumentation issues
Open, Needs TriagePublic

Description

@kostajh @SBisson @nettrom_WMF @Etonkovidova @Catrope

In my testing today, I have found three minor instrumentation issues with the mobile homepage that will not block our release on 2019-06-19, but which we should prioritize addressing immediately after.

  • When I tapped the back arrow from the start module overlay, I did not end up with "close" events. This happened twice, and then I was not able to reproduce it reliably, so if you can't reproduce it, and you don't see anything in the code that could cause it, then we'll just call that a fluke.
  • A couple actions on the start module overlay caused unexpected visits in HomepageVisit. When I clicked the button to start the tutorial in the tutorial module, I got a link-click event in the HomepageModule schema, and I also got a HomepageVisit event with referer_route = 'other'. This happened both times I tried it. And another time, I clicked browser refresh on the start module overlay, and I got a HomepageVisit event with referer_route = 'personaltoolslink'.
  • When I open the question dialog from the mentorship module and start typing in the question box, I correctly get a "enter-question-text" event in the HelpPanel schema. But when I do the same thing in the help module, I do not get a "enter-question-text" event.

Event Timeline

Etonkovidova added a comment.EditedJun 20 2019, 8:48 AM

When I tapped the back arrow from the start module overlay, I did not end up with "close" events. This happened twice, and then I was not able to reproduce it reliably, so if you can't reproduce it, and you don't see anything in the code that could cause it, then we'll just call that a fluke.

Could be due to the validation event error - https://phabricator.wikimedia.org/T222836#5269430.

Rechecked in testwiki on (iPhone 6S) - the close event (returning via back arrow from Start module) is displayed.

phuedx moved this task from Needs triage to Triaged on the Mobile board.Jun 20 2019, 10:03 AM

Could be due to the validation event error - https://phabricator.wikimedia.org/T222836#5269430.

Right, that's the same issue.

A couple actions on the start module overlay caused unexpected visits in HomepageVisit. When I clicked the button to start the tutorial in the tutorial module, I got a link-click event in the HomepageModule schema, and I also got a HomepageVisit event with referer_route = 'other'. This happened both times I tried it.

Not sure about this one. Will investigate.

And another time, I clicked browser refresh on the start module overlay, and I got a HomepageVisit event with referer_route = 'personaltoolslink'.

That makes sense, because before the overlay opens up you need to visit the Homepage. As for the referer route, reloading the page will use whatever was already in the URL parameters.

When I open the question dialog from the mentorship module and start typing in the question box, I correctly get a "enter-question-text" event in the HelpPanel schema. But when I do the same thing in the help module, I do not get a "enter-question-text" event.

Will investigate.

When I clicked the button to start the tutorial in the tutorial module, I got a link-click event in the HomepageModule schema, and I also got a HomepageVisit event with referer_route = 'other'. This happened both times I tried it. And another time, I clicked browser refresh on the start module overlay, and I got a HomepageVisit event with referer_route = 'personaltoolslink'.

This is what happens when the Tutorial button is clicked:

  1. POST request to Special:Homepage
  2. HomepageVisit is logged
  3. Redirect to the tutorial page

The POST/redirect was implemented instead of a simple link to the tutorial page in order to facilitate marking the tutorial page as "visited". This was done a while ago and should also happen on desktop. We can probably easily suppress it.

When I open the question dialog from the mentorship module and start typing in the question box, I correctly get a "enter-question-text" event in the HelpPanel schema. But when I do the same thing in the help module, I do not get a "enter-question-text" event.

Will investigate.

@MMiller_WMF could you please double-check that the textarea was blank before you started typing in the scenario with the help module? I'm unable to reproduce this as described.

I just tried this again in production. Currently waiting for the data to come through.