No problem closing it, although in this case it could be considered also as a feature request to add ShEx to wikibase-docker.

The one thing to be decided here is should this be in the base image or the bundle?
I'm personally leaning toward the bundle, and keeping the base image as just wikibase, no frills.

In T226152#5272025, @Addshore wrote:

The one thing to be decided here is should this be in the base image or the bundle?
I'm personally leaning toward the bundle, and keeping the base image as just wikibase, no frills.

Agreed.

EntitySchema is not in REL1_33. See https://www.mediawiki.org/w/api.php?action=query&list=extdistbranches&edbexts=EntitySchema&formatversion=2&format=json:

{"batchcomplete":true,"query":{"extdistbranches":{"extensions":{"EntitySchema":{"master":"https://extdist.wmflabs.org/dist/extensions/EntitySchema-master-deec406.tar.gz","source":"https://gerrit.wikimedia.org/r/mediawiki/extensions/EntitySchema.git"}}}}}

Compared to Wikibase:

{"batchcomplete":true,"query":{"extdistbranches":{"extensions":{"Wikibase":{"REL1_31":"https://extdist.wmflabs.org/dist/extensions/Wikibase-REL1_31-f690570.tar.gz","REL1_32":"https://extdist.wmflabs.org/dist/extensions/Wikibase-REL1_32-cd41afd.tar.gz","REL1_33":"https://extdist.wmflabs.org/dist/extensions/Wikibase-REL1_33-9344529.tar.gz","master":"https://extdist.wmflabs.org/dist/extensions/Wikibase-master-b308fab.tar.gz","source":"https://gerrit.wikimedia.org/r/mediawiki/extensions/Wikibase.git"}}}}}

What to do now? Backport the whole extension to 1.33?

That could be an option.
Or we could alter the docker file to just grab the extension at a specific pinned commit for 1.33 that we know works.

This is the earliest branch cut I could put my hands on: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/EntitySchema/+archive/wmf/1.34.0-wmf.8.tar.gz
The WikibaseSchema extension doesn't have any branch beside master but it has the commits while EntitySchema doesn't have the old commits. Maybe it works with 1.34-wmf.8. Worth a try.

I did a quick hack to load the extension, the container goes up but it looks very weird. I wonder why.

Looks very weird as in?

In T226152#5318509, @Addshore wrote:

Looks very weird as in?

The "admin" user doesn't exist, modules are not loaded because all 404 because the http://localhost:8181/wiki/index.php/Main_Page doesn't seem right + all try to load http://localhost:8181/w/load.php. I dig deeper. I think it's a config change with 1.33

Basically because the resetPassword.php maint script can't find "admin" account (became case sensitive?), it fails, I commented it out to see if there's another issue and there it is:

wikibase_1         | Fatal error: Uncaught ExtensionDependencyError: EntitySchema is not compatible with the current MediaWiki core (version 1.33.0), it requires: >= 1.34.0.
wikibase_1         |  in /var/www/html/includes/registration/ExtensionRegistry.php:323
wikibase_1         | Stack trace:
wikibase_1         | #0 /var/www/html/includes/registration/ExtensionRegistry.php(172): ExtensionRegistry->readFromQueue(Array)
wikibase_1         | #1 /var/www/html/includes/Setup.php(127): ExtensionRegistry->loadFromQueue()
wikibase_1         | #2 /var/www/html/maintenance/doMaintenance.php(81): require_once('/var/www/html/i...')
wikibase_1         | #3 /var/www/html/maintenance/update.php(266): require_once('/var/www/html/m...')
wikibase_1         | #4 {main}
wikibase_1         |   thrown in /var/www/html/includes/registration/ExtensionRegistry.php on line 323

Is 1.34 actually required for anything?
Probably best to check with the origional Devs :)
Otherwise let's change that down!

@Lucas_Werkmeister_WMDE @Michael @noarave ^

In T226152#5320715, @Addshore wrote:

Is 1.34 actually required for anything?
Probably best to check with the origional Devs :)
Otherwise let's change that down!

I think I remember that we are using 1.33 features. Not sure whether we are using 1.34 features, but certainly wouldn't rule it out either.
Did you try running the browser tests on an 1.33 installation?

If I recall correctly, the 1.33 release was branched fairly late during EntitySchema development, so I think there’s a good chance we’re compatible with 1.33, but I can’t say for sure.

There is your reason why it says 1.34: https://github.com/wikimedia/mediawiki-extensions-EntitySchema/commit/02e52f345d59a595dfccc3d06980341ec3fb8555

In T226152#5323872, @Michael wrote:

There is your reason why it says 1.34: https://github.com/wikimedia/mediawiki-extensions-EntitySchema/commit/02e52f345d59a595dfccc3d06980341ec3fb8555

Nice, applied the parent commit to see if that's working 💃