Page MenuHomePhabricator
Create Task
Maniphest T227083

Termbox should hide non-supported languages
Closed, ResolvedPublic
Actions

Description

Both desktop and new mobile termbox shouldn't show non-supported languages in either the current or historic revisions.

  • Remove from desktop termbox
    • remove from title and content of PageOutput
    • remove from ParserOutput (patches up for review)
    • remove from post load JS generated "Additional Languages"
  • Remove from mobile termbox
    • ensure unusual interface language don't show empty row
    • ensure previously valid terms aren't displayed in secondary languages ("in more languages" section)
    • ensure previously valid terms aren't displayed in additional languages

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

noarave created this task.Jul 2 2019, 12:59 PM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptJul 2 2019, 12:59 PM
Tarrow moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 20 2019, 1:19 PM
Tarrow claimed this task.Aug 20 2019, 2:45 PM

Assigning this to myself. I'm just in the process of working out where we should be making changes

Tarrow updated the task description. (Show Details)Aug 20 2019, 3:56 PM
Tarrow added a comment.Aug 21 2019, 7:23 AM

For the current desktop termbox it appears that we already check when building the termbox with the user's language that all of those languages are valid WikibaseContent languages:

Non-valid language are filtered out here: extensions/Wikibase/repo/includes/Hooks/OutputPageBeforeHTMLHookHandler.php:239
Which means that they are not then later iterated over in extensions/Wikibase/repo/includes/ParserOutput/PlaceholderExpander/EntityViewPlaceholderExpander.php

It looks at first glance to me like the additional "invalid" languages are added client side.

Tarrow added a comment.Aug 21 2019, 7:53 AM

Looks like that is partially true. I also missed that due to extensions/Wikibase/repo/includes/Hooks/OutputPageBeforeHTMLHookHandler.php:274 the language of the OutputPage is also always included even if it is not valid. This is then used to generate the language for the page title, and headline term.

e.g. if we append &uselang=foobarbaz to the url.

Tarrow updated the task description. (Show Details)Aug 21 2019, 7:56 AM
gerritbot added a comment.Aug 23 2019, 2:04 PM

Change 531924 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Add service for looking up a user's preferred languages

https://gerrit.wikimedia.org/r/531924

gerritbot added a project: Patch-For-Review.Aug 23 2019, 2:04 PM
gerritbot added a comment.Aug 23 2019, 2:47 PM

Change 531938 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Wire up UserPreferredContentLanguagesLookup with OutputPageBeforeHTMLHookHandler

https://gerrit.wikimedia.org/r/531938

gerritbot added a comment.Aug 26 2019, 7:24 PM

Change 531924 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add service for looking up a user's preferred languages

https://gerrit.wikimedia.org/r/531924

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.20; 2019-08-27).Aug 26 2019, 8:00 PM
gerritbot added a comment.Aug 27 2019, 1:16 PM

Change 532708 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] UserPreferredContentLanguagesLookup: better method param name

https://gerrit.wikimedia.org/r/532708

Tarrow updated the task description. (Show Details)Aug 29 2019, 10:19 AM
gerritbot added a comment.Aug 29 2019, 10:27 AM

Change 533183 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] Ensure EntityTermsViewFactory builds with valid Terms Languages

https://gerrit.wikimedia.org/r/533183

gerritbot added a comment.Aug 30 2019, 10:40 AM

Change 533497 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] Introduce ContentLanguagesFallbackChainFilterer

https://gerrit.wikimedia.org/r/533497

gerritbot added a comment.Sep 2 2019, 1:41 PM

Change 533913 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] Use only Terms languages in EntityTermsViews FallbackChains

https://gerrit.wikimedia.org/r/533913

gerritbot added a comment.Sep 2 2019, 3:47 PM

Change 533183 abandoned by Tarrow:
Ensure EntityTermsViewFactory builds with valid Terms Languages

Reason:
It seems that useful bit of this patch has been supplanted by: I79f735c7a07760bd1a85c9e39bed5168d2092390

https://gerrit.wikimedia.org/r/533183

gerritbot added a comment.Sep 2 2019, 4:16 PM

Change 533941 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] FingerprintableEntityMetaTagsCreator gets just Term Languages

https://gerrit.wikimedia.org/r/533941

Tarrow updated the task description. (Show Details)Sep 2 2019, 4:37 PM
gerritbot added a comment.Sep 3 2019, 11:32 AM

Change 532708 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] UserPreferredContentLanguagesLookup: better method param name

https://gerrit.wikimedia.org/r/532708

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.21; 2019-09-03); removed MW-1.34-notes (1.34.0-wmf.20; 2019-08-27).Sep 3 2019, 12:00 PM
gerritbot added a comment.Sep 3 2019, 10:23 PM

Change 533497 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Introduce ContentLanguagesFallbackChainFilterer

https://gerrit.wikimedia.org/r/533497

gerritbot added a comment.Sep 3 2019, 10:42 PM

Change 531938 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Wire up UserPreferredContentLanguagesLookup with OutputPageBeforeHTMLHookHandler

https://gerrit.wikimedia.org/r/531938

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.22; 2019-09-10); removed MW-1.34-notes (1.34.0-wmf.21; 2019-09-03).Sep 3 2019, 11:00 PM
WMDE-leszek mentioned this in T231968: Wikibase OutputPageBeforeHTMLHookHandlerTest::testOutputPageBeforeHTMLHookHandler failing on Travis CI.Sep 4 2019, 8:23 AM
gerritbot added a comment.Sep 4 2019, 9:05 PM

Change 534534 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] Add TermsContentLanguages to JS config

https://gerrit.wikimedia.org/r/534534

• alaa_wmde removed Tarrow as the assignee of this task.Sep 12 2019, 11:47 AM
• alaa_wmde edited projects, added Wikidata-Campsite; removed Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).
• alaa_wmde moved this task from Incoming to Ready to pick up on the Wikidata-Campsite board.
• alaa_wmde subscribed.

Moving back as it might not be continued on for a week or two

• alaa_wmde mentioned this in T227081: Provide supported languages to Wikibase Frontend.Oct 1 2019, 2:44 PM
Addshore triaged this task as High priority.Oct 29 2019, 1:39 PM
Addshore removed a project: Wikidata-Campsite.
Jakob_WMDE claimed this task.Dec 4 2019, 2:23 PM
gerritbot added a comment.Dec 4 2019, 3:47 PM

Change 554537 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Filter out invalid term languages from termbox

https://gerrit.wikimedia.org/r/554537

gerritbot added a comment.Dec 5 2019, 12:24 PM

Change 554835 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Filter out invalid term languages from termbox

https://gerrit.wikimedia.org/r/554835

Jakob_WMDE added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).Dec 5 2019, 4:11 PM
Jakob_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Dec 5 2019, 4:15 PM
gerritbot added a comment.Dec 10 2019, 2:35 PM

Change 554537 abandoned by Addshore:
Filter out invalid term languages from termbox

Reason:
Abandoned in favour of https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/ /554835/

https://gerrit.wikimedia.org/r/554537

gerritbot added a comment.Dec 10 2019, 2:35 PM

Change 534534 abandoned by Addshore:
Add TermsContentLanguages to JS config

Reason:
Abandoned in favour of https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/ /554835/

https://gerrit.wikimedia.org/r/534534

gerritbot added a comment.Dec 10 2019, 2:35 PM

Change 533941 abandoned by Addshore:
FingerprintableEntityMetaTagsCreator gets just Term Languages

Reason:
Abandoned in favour of https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/ /554835/

https://gerrit.wikimedia.org/r/533941

gerritbot added a comment.Dec 10 2019, 2:35 PM

Change 533913 abandoned by Addshore:
Use only Terms languages in EntityTermsViews FallbackChains

Reason:
Abandoned in favour of https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/ /554835/

https://gerrit.wikimedia.org/r/533913

Addshore moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 10 2019, 2:49 PM
gerritbot added a comment.Dec 10 2019, 3:02 PM

Change 554835 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Filter out invalid term languages from termbox

https://gerrit.wikimedia.org/r/554835

Jakob_WMDE updated the task description. (Show Details)Dec 10 2019, 3:25 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.10; 2019-12-10).Dec 10 2019, 4:00 PM
Lydia_Pintscher closed this task as Resolved.Dec 19 2019, 8:36 AM
Lydia_Pintscher moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
gerritbot added a comment.Feb 11 2020, 4:52 PM

Change 571534 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Revert "Introduce ContentLanguagesFallbackChainFilterer"

https://gerrit.wikimedia.org/r/571534

Tarrow added a comment.Feb 11 2020, 5:13 PM

I saw this revert patch come up; it's a great idea to clean up if not needed.

I see the ticket is closed but as far as I can see unsupported language can still appear in the termbox in various cases.
See for example
https://wikidata.beta.wmflabs.org/wiki/Q112?uselang=catfish
or
https://m.wikidata.beta.wmflabs.org/wiki/Q112?uselang=catfish

where the bad language is still happily pumped out.

I'm not quite sure the implication of not fixing this off hand. I've unchecked the "remove from ParserOutput (patches up for review)" box since that is where these snuck in.
Also 2/3 new termbox tickets are still unchecked so maybe this needs checking too.

I guess we need to figure out if this is actually done?

Tarrow updated the task description. (Show Details)Feb 11 2020, 5:13 PM
Lucas_Werkmeister_WMDE subscribed.Feb 11 2020, 5:58 PM
Lucas_Werkmeister_WMDE added a comment.Feb 11 2020, 6:01 PM

FWIW, Jakob’s comment at T217770#5778186 seems to mention the ?uselang “hack” as something that still needs to be cleaned up, so maybe that was never intended to be in scope of this task?

gerritbot added a comment.Feb 12 2020, 12:37 PM

Change 571534 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Revert "Introduce ContentLanguagesFallbackChainFilterer"

https://gerrit.wikimedia.org/r/571534

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.20; 2020-02-18); removed MW-1.35-notes (1.35.0-wmf.10; 2019-12-10).Feb 12 2020, 1:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits