Page MenuHomePhabricator

BUG: non-circular read/unread dots in Echo notifications
Open, Needs TriagePublic

Description

@alexhollender (originally in T225260) wrote:

  1. Some of the read/unread dots are not circles

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 9 2019, 10:02 PM

Some of the read/unread dots are not circles

I believe this is because of an em vs px thing. cc @Volker_E who worked on making these circles actually circular before (on desktop, at least)

For read notifications the dots have gray backgrounds, which doesn't communicate that they are interactive. They should have a white background.

That's a simple design change that's easy to make if @Cntlsn / @RHo agree. (It may also be worth asking @Pginer-WMF about, since he designed this originally.) For completeness, could you (@alexhollender) also specify what the hover color should be for these circles? They currently turn a darker gray on hover.

For read notifications the dots have gray backgrounds, which doesn't communicate that they are interactive. They should have a white background.

That's a simple design change that's easy to make if @Cntlsn / @RHo agree. (It may also be worth asking @Pginer-WMF about, since he designed this originally.) For completeness, could you (@alexhollender) also specify what the hover color should be for these circles? They currently turn a darker gray on hover.

After thinking about this some more I'm wondering if (in addition to a white background) a blue outline (#3366cc) would help to further communicate that it's a toggle-able element:

desktopmobile

Regarding your question about hover, I think if we went with a blue outline then light blue (#eaf3ff), shown above on the desktop screenshot, would make sense.

Lastly, I'm now wondering if I should move this change over to T225535, and leave this task to just be able the non-circular dots issue?

+1 for the blue outline/white background comment by Alex and that this ticket should only care about the non-circular icons. Both make sense.

+1 for the blue outline too

Lastly, I'm now wondering if I should move this change over to T225535, and leave this task to just be able the non-circular dots issue?

The blue dot is in the Echo extension, so if you want to break this up you'll need to create a new ticket tagged Echo rather than add on to T225535 - two repos, two different considerations.

alexhollender renamed this task from UX problems with read/unread dots in Echo notifications to BUG: non-circular read/unread dots in Echo notifications.Jul 23 2019, 11:35 PM
alexhollender updated the task description. (Show Details)

Lastly, I'm now wondering if I should move this change over to T225535, and leave this task to just be able the non-circular dots issue?

The blue dot is in the Echo extension, so if you want to break this up you'll need to create a new ticket tagged Echo rather than add on to T225535 - two repos, two different considerations.

I've de-scoped this ticket respectively and created T228819, which contains the same changes as T225535, plus the update to the dot color/outline. Hopefully that isn't too confusing : )

Hey @alexhollender as far as the bug, is the Readers Web team planning to work on this?

@JTannerWMF the Echo extension is maintained by Growth and this change would also impact the desktop product so this should probably be discussed by a Growth designer and implemented by a Growth developer.

Moving to upcoming Q1 column for Growth developers