Create HtmlCacheUpdater service class to normalize purging code
Closed, ResolvedPublic
Actions

Description

This would help to concentrate CDN purging code in a single place, improving modularity and helping to de-couple the code.

(this task was created to enable tracking for a pre-existing patch).

Details

Subject	Repo	Branch	Lines +/-
Hard-deprecate Title::purgeSquid(), deprecated in 1.35	mediawiki/core	master	+3 -1
SubmissionHandler: Avoid use of deprecated Title::purgeSquid	mediawiki/extensions/Flow	master	+4 -2
Avoid use of deprecated Title::purgeSquid	mediawiki/extensions/FlaggedRevs	master	+14 -8
Add small HtmlCacheUpdater service class to normalize purging code (2)	mediawiki/core	master	+390 -132
Add small HtmlCacheUpdater service class to normalize purging code	mediawiki/core	master	+298 -118

Customize query in gerrit

Related Objects

Mentioned In: T263929: purgeList.php maintenance script not doing anything
T250208: Update Wikibase to use HtmlCacheUpdater service instead of doing things directly
T124418: Investigate massive increase in htmlCacheUpdate jobs in Dec/Jan

Event Timeline

daniel created this task.Aug 7 2019, 2:00 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 7 2019, 2:00 PM

daniel added a project: User-Daniel.Aug 7 2019, 2:01 PM

Change 528824 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Add small HtmlCacheUpdater service class to normalize purging code

https://gerrit.wikimedia.org/r/528824

gerritbot added a project: Patch-For-Review.Aug 7 2019, 2:34 PM

Untagging core platform team inbox since the ticket is already categorized.

Change 528924 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] Add small HtmlCacheUpdater service class to normalize purging code

https://gerrit.wikimedia.org/r/528924

@Pchelolo, @WDoranWMF: My intention was to get this into Clinic Duty, since it's a code review request from another team. It fits the decoupling initiative conceptually, but having this ticket on hold until we pick up that initiative doesn't make sense.

I suppose if it's not for the initiative, it shouldn't be tagged as such - but we don't have any other way to tag something as decoupling related. Perhaps we need a board-less tag for that?

For now, I'm putting this into the External Code Review column for the CD team.

daniel moved this task from Inbox to External Code Review Needed on the Platform Team Workboards (Clinic Duty Team) board.Aug 8 2019, 2:00 PM

I went through the patch and it looks like it DRT, but I'd like @Krinkle to give it another pass before we merge it.

• mobrovac moved this task from External Code Review Needed to Blocked Externally on the Platform Team Workboards (Clinic Duty Team) board.Aug 12 2019, 1:12 PM

aaron moved this task from Inbox, needs triage to Doing (old) on the Performance-Team board.Aug 12 2019, 7:43 PM

aaron moved this task from Doing (old) to Blocked (old) on the Performance-Team board.Aug 12 2019, 7:46 PM

Change 528824 abandoned by Krinkle:
Add small HtmlCacheUpdater service class to normalize purging code

Reason:
Further reviewed and iterated upon at https://gerrit.wikimedia.org/r/#/c/mediawiki/core/ /528924/

https://gerrit.wikimedia.org/r/528824

daniel triaged this task as Medium priority.Sep 30 2019, 2:55 PM

daniel moved this task from Blocked Externally to External Code Review Needed on the Platform Team Workboards (Clinic Duty Team) board.Oct 1 2019, 10:14 AM

(Pending response on Gerrit.)

(moving to Blocked on the CPT board until the CR is ready to be re-reviewed)

gerritbot mentioned this in T124418: Investigate massive increase in htmlCacheUpdate jobs in Dec/Jan.Jan 13 2020, 9:32 PM

Krinkle added a project: MediaWiki-Page-derived-data.Feb 10 2020, 9:29 PM

Anomie moved this task from Blocked Externally to External Code Review In Progress on the Platform Team Workboards (Clinic Duty Team) board.Mar 24 2020, 8:33 PM

Change 528924 merged by jenkins-bot:
[mediawiki/core@master] Add small HtmlCacheUpdater service class to normalize purging code (2)

https://gerrit.wikimedia.org/r/528924

Maintenance_bot removed a project: Patch-For-Review.Apr 14 2020, 2:11 PM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.28; 2020-04-14).Apr 14 2020, 3:00 PM

Addshore mentioned this in T250208: Update Wikibase to use HtmlCacheUpdater service instead of doing things directly.Apr 14 2020, 5:20 PM

aaron closed this task as Resolved.Apr 17 2020, 10:01 AM

DannyS712 mentioned this in T263929: purgeList.php maintenance script not doing anything.Sep 27 2020, 3:30 AM

Change 993163 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/FlaggedRevs@master] Avoid use of deprecated Title::purgeSquid

https://gerrit.wikimedia.org/r/993163

Change 993164 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/Flow@master] SubmissionHandler: Avoid use of deprecated Title::purgeSquid

https://gerrit.wikimedia.org/r/993164

Change 993165 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] Hard-deprecate Title::purgeSquid(), deprecated in 1.35

https://gerrit.wikimedia.org/r/993165

Change 993164 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] SubmissionHandler: Avoid use of deprecated Title::purgeSquid

https://gerrit.wikimedia.org/r/993164

Change 993163 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Avoid use of deprecated Title::purgeSquid

https://gerrit.wikimedia.org/r/993163

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.16; 2024-01-30).Jan 26 2024, 6:00 PM

Change 993165 merged by jenkins-bot: