Page MenuHomePhabricator

Create HtmlCacheUpdater service class to normalize purging code
Open, Needs TriagePublic

Description

This would help to concentrate CDN purging code in a single place, improving modularity and helping to de-couple the code.

(this task was created to enable tracking for a pre-existing patch).

Event Timeline

daniel created this task.Aug 7 2019, 2:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 7 2019, 2:00 PM

Change 528824 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Add small HtmlCacheUpdater service class to normalize purging code

https://gerrit.wikimedia.org/r/528824

Pchelolo added a subscriber: Pchelolo.

Untagging core platform team inbox since the ticket is already categorized.

Change 528924 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] Add small HtmlCacheUpdater service class to normalize purging code

https://gerrit.wikimedia.org/r/528924

daniel added a subscriber: WDoranWMF.

@Pchelolo, @WDoranWMF: My intention was to get this into Clinic Duty, since it's a code review request from another team. It fits the decoupling initiative conceptually, but having this ticket on hold until we pick up that initiative doesn't make sense.

I suppose if it's not for the initiative, it shouldn't be tagged as such - but we don't have any other way to tag something as decoupling related. Perhaps we need a board-less tag for that?

For now, I'm putting this into the External Code Review column for the CD team.

I went through the patch and it looks like it DRT, but I'd like @Krinkle to give it another pass before we merge it.

aaron moved this task from Inbox to Doing on the Performance-Team board.Aug 12 2019, 7:43 PM