Page MenuHomePhabricator

Page creation log should not display the content of deleted pages
Open, Needs TriagePublic

Description

  • vandal creates a page with abusive language (with no edit summary, as is typical for vandals)
  • page gets deleted
  • abusive content gets preserved in page creation log (which uses first N characters of the content as autosummary) and requires extra effort from administrators to remove

This is not ideal. We should customize the page creation log formatter to hide the summary if the page got deleted (but that seems like a potential performance problem as a I don't think we have a way to do a mass page lookup for a mass log record lookup), or revdelete the creation log comment automatically when the page gets deleted, or just not put the page content in the summary in the first place.

See also: T12331: Introduce page creation log

Event Timeline

Tgr created this task.Aug 13 2019, 3:40 PM
Restricted Application added subscribers: MGChecker, Aklapper. · View Herald TranscriptAug 13 2019, 3:40 PM
binbot added a subscriber: binbot.Aug 13 2019, 3:48 PM
JJMC89 added a subscriber: JJMC89.Aug 13 2019, 4:51 PM

just not put the page content in the summary in the first place

I think this is the best option for simplicity. I'd also say that content shouldn't be put in the edit summary of page creation revisions or added in the deletion summaries for similar reasons.

Nirmos added a subscriber: Nirmos.Aug 21 2019, 4:14 PM

Caused T24999 and probably other leakages

Change 552484 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Remove autogeneration of Deletion summary.

https://gerrit.wikimedia.org/r/552484

Tgr added a comment.Nov 22 2019, 5:27 PM

Caused T24999 and probably other leakages

This task is in no way related to T24999 (which is about a bug in the deletion autosummary generation algorithm).

Ammarpad removed Ammarpad as the assignee of this task.Dec 26 2019, 9:10 AM

This task is in no way related to T24999 (which is about a bug in the deletion autosummary generation algorithm).

No. Certainly not "in no way". If Article::generateReason/T24999 is not generating the reason at all (or if it were to be removed now) then this bug wouldn't exist in the first place.

Platonides renamed this task from Page creation log should not display the content of deleted pages to Recent changes new page entries should not display the content of deleted pages.Thu, Jul 9, 10:09 PM
Platonides renamed this task from Recent changes new page entries should not display the content of deleted pages to Page creation log should not display the content of deleted pages.