Page MenuHomePhabricator

UploadFromChunks.php: Call to undefined method MediaWiki\FileBackend\FSFile\TempFSFileFactory::getTempFSFile()
Closed, ResolvedPublic

Description

Error

Request ID: XWbJrQpAEDcAABSPSkwAAAAC
Request URL: commons.wikimedia.org/w/api.php

message
[XWbJrQpAEDcAABSPSkwAAAAC] /w/api.php   PHP Fatal Error from line 164 of /srv/mediawiki/php-1.34.0-wmf.20/includes/upload/UploadFromChunks.php: Call to undefined method MediaWiki\FileBackend\FSFile\TempFSFileFactory::getTempFSFile()
trace
#0 /srv/mediawiki/php-1.34.0-wmf.20/includes/upload/UploadFromChunks.php(164): NO_FUNCTION_GIVEN()
#1 /srv/mediawiki/php-1.34.0-wmf.20/includes/api/ApiUpload.php(256): UploadFromChunks->concatenateChunks()
#2 /srv/mediawiki/php-1.34.0-wmf.20/includes/api/ApiUpload.php(132): ApiUpload->getChunkResult(array)
#3 /srv/mediawiki/php-1.34.0-wmf.20/includes/api/ApiUpload.php(104): ApiUpload->getContextResult()
#4 /srv/mediawiki/php-1.34.0-wmf.20/includes/api/ApiMain.php(1595): ApiUpload->execute()
#5 /srv/mediawiki/php-1.34.0-wmf.20/includes/api/ApiMain.php(533): ApiMain->executeAction()
#6 /srv/mediawiki/php-1.34.0-wmf.20/includes/api/ApiMain.php(504): ApiMain->executeActionWithErrorHandling()
#7 /srv/mediawiki/php-1.34.0-wmf.20/api.php(86): ApiMain->execute()
#8 /srv/mediawiki/w/api.php(3): include(string)
#9 {main}
Impact

53 hits in the last 15 minutes, after deploying wmf.20 to group 1, 134 in the last 24 hours. Not seen before that.

Notes

Blocking the train.


Request ID: XWbKWgpAAE4AAHbdMzgAAAAF
Request URL: jobrunner.discovery.wmnet/rpc/RunSingleJob.php

message
[XWbKWgpAAE4AAHbdMzgAAAAF] [no req]   Error from line 164 of /srv/mediawiki/php-1.34.0-wmf.20/includes/upload/UploadFromChunks.php: Call to undefined method MediaWiki\FileBackend\FSFile\TempFSFileFactory::getTempFSFile()
trace
#0 /srv/mediawiki/php-1.34.0-wmf.20/includes/jobqueue/jobs/AssembleUploadChunksJob.php(65): UploadFromChunks->concatenateChunks()
#1 /srv/mediawiki/php-1.34.0-wmf.20/extensions/EventBus/includes/JobExecutor.php(64): AssembleUploadChunksJob->run()
#2 /srv/mediawiki/rpc/RunSingleJob.php(76): JobExecutor->execute(array)
#3 {main}
Impact

48 hits in the last 15 minutes, after deploying wmf.20 to group 1, 89 in the last 24 hours. Not seen before that.

Notes

Blocking the train.

Details

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 28 2019, 6:43 PM
zeljkofilipin triaged this task as Unbreak Now! priority.Aug 28 2019, 6:43 PM
zeljkofilipin updated the task description. (Show Details)
Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptAug 28 2019, 6:44 PM

IIUC correctly it should be changed to call newTempFSFile.

And this is the kind of errors that phan would catch instantly. Generally speaking, that huge list of suppressions in MW core should really be butchered.

Change 533078 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Revert "TempFSFileFactory service"

https://gerrit.wikimedia.org/r/533078

Change 533079 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Fix call to non-existing TempFSFileFactory::getTempFSFile()

https://gerrit.wikimedia.org/r/533079

Mentioned in SAL (#wikimedia-operations) [2019-08-28T19:15:34Z] <James_F> Live hacking php-1.34.0-wmf.20/includes/upload/UploadFromChunks.php on mwdebug1002 for T231488

Change 533080 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Remove @group Broken from ApiUploadTest

https://gerrit.wikimedia.org/r/533080

Change 533078 abandoned by Jforrester:
Revert "TempFSFileFactory service"

https://gerrit.wikimedia.org/r/533078

Change 533082 had a related patch set uploaded (by Krinkle; owner: Daniel Kinzler):
[mediawiki/core@wmf/1.34.0-wmf.20] Fix call to non-existing TempFSFileFactory::getTempFSFile()

https://gerrit.wikimedia.org/r/533082

Mentioned in SAL (#wikimedia-operations) [2019-08-28T19:39:13Z] <jforrester@deploy1001> Synchronized php-1.34.0-wmf.20/includes/upload/UploadFromChunks.php: T231488 Speculatively hot-deploy fix ahead of landing in git (duration: 00m 54s)

Jdforrester-WMF lowered the priority of this task from Unbreak Now! to High.Aug 28 2019, 7:49 PM

Change 533082 merged by jenkins-bot:
[mediawiki/core@wmf/1.34.0-wmf.20] Fix call to non-existing TempFSFileFactory::getTempFSFile()

https://gerrit.wikimedia.org/r/533082

Jdforrester-WMF closed this task as Resolved.Aug 28 2019, 8:04 PM
Jdforrester-WMF assigned this task to daniel.

Change 533079 merged by jenkins-bot:
[mediawiki/core@master] Fix call to non-existing TempFSFileFactory::getTempFSFile()

https://gerrit.wikimedia.org/r/533079

mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:06 PM

Why did phan not catch this?

Why did phan not catch this?

And this is the kind of errors that phan would catch instantly. Generally speaking, that huge list of suppressions in MW core should really be butchered.

There are too many suppressions. I'm working on it at https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/533177/.

Change 533283 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] WIP: Rework ApiUploadTest

https://gerrit.wikimedia.org/r/533283

Change 533080 abandoned by Jforrester:
Remove @group Broken from ApiUploadTest

Reason:
Let's go with I923bf82d07db.

https://gerrit.wikimedia.org/r/533080