Page MenuHomePhabricator
Create Task
Maniphest T232024

Branch REL1_34 for MediaWiki and deployed extensions
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
Provide `branch-version.py` for tarball release branchingmediawiki/tools/releasemaster+255 -147
Set manual branchpoint for mediawiki/core REL1_34mediawiki/tools/releasemaster+2 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Sep 4 2019, 6:42 PM
Jdforrester-WMF added a parent task: T232030: Mark MediaWiki core as 1.35.0-alpha once REL1_34 is branched.Sep 4 2019, 6:46 PM
Jdforrester-WMF changed the task status from Open to Stalled.Sep 4 2019, 9:30 PM
Jdforrester-WMF added a project: Release-Engineering-Team-TODO (201909).
Jdforrester-WMF added a subscriber: thcipriani.

To be done on 2019-09-30 alongside the wmf.25 branch cut in T220750 which @thcipriani will be doing.

WDoranWMF moved this task from Inbox to Tracking/Watching on the Platform Engineering board.Sep 5 2019, 4:54 PM
Reedy mentioned this in T151425: Enlarge Popular Password File to 100,000 entries and enforce the new minimum in the config.Sep 5 2019, 11:07 PM
Jdforrester-WMF closed subtask T232025: Configure CI to support REL1_34 as Resolved.Sep 12 2019, 11:37 PM
CCicalese_WMF moved this task from Blocker to Create Release on the MW-1.34-release board.Sep 20 2019, 9:06 PM
Jdforrester-WMF added a comment.Sep 30 2019, 5:20 PM

Patches once it's branched:

Jdforrester-WMF changed the task status from Stalled to Open.Oct 1 2019, 6:41 PM
thcipriani assigned this task to dduvall.Oct 2 2019, 2:15 PM
thcipriani edited projects, added Release-Engineering-Team-TODO (201910); removed Release-Engineering-Team-TODO (201909).
thcipriani added subscribers: dduvall, • mmodell.

Tentatively assigning to @dduvall following IRC discussion on Monday.

Really this is a @dduvall @mmodell pairing item since @mmodell's branch.py expertise is required.

thcipriani triaged this task as Medium priority.Oct 2 2019, 2:16 PM
Paladox subscribed.Oct 2 2019, 2:17 PM
RhinosF1 subscribed.Oct 2 2019, 8:33 PM
Stashbot added a comment.Oct 4 2019, 6:34 PM

Mentioned in SAL (#wikimedia-releng) [2019-10-04T18:34:10Z] <marxarelli> branching REL1_34 for all wmf-deployed extensions, mediawiki/tools/release/make-release/branch.py REL1_34 --bundle wmf --branchpoint wmf/1.34.0-wmf.25 --core-version 1.34.0 cc: T232024

Stashbot added a comment.Oct 4 2019, 6:55 PM

Mentioned in SAL (#wikimedia-releng) [2019-10-04T18:55:30Z] <marxarelli> branching REL1_34 for remaining extensions/skins and core, mediawiki/tools/release/make-release/branch.py REL1_34 --bundle '*' --core --branchpoint master --core-version 1.34.0 (note: core branchpoint is overridden in settings.yaml at base of wmf/1.34.0-wmf.25) cc: T232024

gerritbot added a comment.Oct 4 2019, 7:09 PM

Change 540946 had a related patch set uploaded (by Dduvall; owner: Dduvall):
[mediawiki/tools/release@master] Set manual branchpoint for mediawiki/core REL1_34

https://gerrit.wikimedia.org/r/540946

gerritbot added a project: Patch-For-Review.Oct 4 2019, 7:09 PM
Stashbot added a comment.Oct 4 2019, 7:34 PM

Mentioned in SAL (#wikimedia-releng) [2019-10-04T19:34:49Z] <marxarelli> re-running mediawiki/tools/release/make-release/branch.py --bundle '*' ... due to https://gerrit.wikimedia.org/r/c/mediawiki/tools/release/+/540953 cc: T232024

gerritbot added a comment.Oct 4 2019, 11:54 PM

Change 540946 abandoned by Dduvall:
Set manual branchpoint for mediawiki/core REL1_34

Reason:
Currently reworking the script in a way that makes this unnecessary

https://gerrit.wikimedia.org/r/540946

Maintenance_bot removed a project: Patch-For-Review.Oct 5 2019, 12:10 AM
gerritbot added a comment.Oct 5 2019, 12:30 AM

Change 540979 had a related patch set uploaded (by Dduvall; owner: Dduvall):
[mediawiki/tools/release@master] Provide branch-version.py for tarball release branching

https://gerrit.wikimedia.org/r/540979

gerritbot added a project: Patch-For-Review.Oct 5 2019, 12:30 AM
gerritbot added a comment.Oct 7 2019, 11:59 PM

Change 540979 merged by jenkins-bot:
[mediawiki/tools/release@master] Provide branch-version.py for tarball release branching

https://gerrit.wikimedia.org/r/540979

Maintenance_bot removed a project: Patch-For-Review.Oct 8 2019, 12:10 AM
dduvall closed this task as Resolved.Oct 8 2019, 5:25 PM

The REL1_34 branch has been created for all active repos and core was prepared with submodules from the "base" bundle. I initially had some trouble with the branch.py script but got it fixed up in the end. I also moved its implementation to a shared module and created a branch-version.py script which should ease the entire process for the next branch cut.

See https://www.mediawiki.org/wiki/Release_branching for details.

hashar mentioned this in T264365: mediawiki/extensions and mediawiki/skins missing the REL1_XX branches.Jan 3 2024, 9:03 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL