Note that two cards are shown at the tools column, one for the reference and another for the specific kind of reference ("website" in the example below):

I spent some time today to understand how this works in VE and Cite extension.

• Even if Cite extension is installed, the wiki should have MediaWiki:Visualeditor-cite-tool-definition.json‎(example) to actually get reference type specific reference context items(the cards in CX tools column, or popups in VE)
• Cite extension creates custom context items for each of the cite tools in the MediaWiki:Visualeditor-cite-tool-definition.json using ve.ui.MWReference.init.js. Each of those ContextItems are sub classes of ve.ui.MWCitationContextItem which is a sub class of ve.ui.MWReferenceContextItem.
• So a wiki with MediaWiki:Visualeditor-cite-tool-definition.json and Cite extension, every reference node will get one of "Web", "News", "Jounal", "Book" reference contextItems.
• But CX also subclasses ve.ui.MWReferenceContextItem and creates ve.ui.CXReferenceContextItem which takes care of adaptation status of template between source-target language. This is shown as general Reference context item.
• So A reference node gets both ContextItems. Clicking on "Web", "News", "Jounal", "Book" context items opens the Citation editor, while CX's context items first opens a template editor and then a reference editor

As per my understanding, to avoid multiple contextItems, and to properly customize references so that adaptations status can be rendered, ve.ui.CXReferenceContextItem should inherit the GeneratedMWCitationContextItem classes for each of "Web", "News", "Jounal", "Book" citations. But that is not straight forward as far as I can see.

@DLynch Is my understanding correct?

Any recommendations to customize the ContextItems for "Web", "News", "Jounal", "Book" etc?

(Please cc anybody else who maintain this part of code in VE. Thanks)

@santhosh That's all correct, yes.

In T232330#7242716, @santhosh wrote:

As per my understanding, to avoid multiple contextItems, and to properly customize references so that adaptations status can be rendered, ve.ui.CXReferenceContextItem should inherit the GeneratedMWCitationContextItem classes for each of "Web", "News", "Jounal", "Book" citations. But that is not straight forward as far as I can see.

Any recommendations to customize the ContextItems for "Web", "News", "Jounal", "Book" etc?

I think you could subclass each of them in a loop, much like how Cite generates them in a loop. Something like this:

function addCxSubclass( parentContextItem ) {
	var contextItem = function CXGeneratedMWCitationContextItem() {
		/* ... */
		// Parent constructor
		parentContextItem.apply( this, arguments );
	};
	OO.inheritClass( contextItem, parentContextItem );

	// Override any methods here
	// (Or you could use OO.mixinClass())
	contextItem.prototype.getRendering = function () {
		/* ... */
		return contextItem.super.prototype.getRendering.apply( this, arguments );
	};

	ve.ui.contextItemFactory.register( contextItem );
}

// Note: Don't iterate directly with `for ( name in ve.ui.contextItemFactory.registry )`,
// because we're modifying that object in the loop body
var names = Object.keys( ve.ui.contextItemFactory.registry );
for ( var i = 0; i < names.length; i++ ) {
	var name = names[ i ];
	if ( name.slice( 0, 5 ) === 'cite-' ) {
		var parentContextItem = ve.ui.contextItemFactory.lookup( name );
		addCxSubclass( parentContextItem );
	}
}

Change 740780 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] Reference support: Customize Cite ContextIttem classes for references

https://gerrit.wikimedia.org/r/740780

Thanks @matmarex. That helped.

Screenshot after the fix:

Change 740780 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Reference support: Customize Cite ContextItem classes for references

https://gerrit.wikimedia.org/r/740780

I assume this is ready for QA (probably deployed already). Correct if wrong.

The cards are no longer duplicated. However, the card shows now as empty with no details of the reference until you open it:

@santhosh if you think this is an unrelated issue, feel free to create a separate ticket.

Change 760901 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] CX: Avoid empty reference cards when clicked

https://gerrit.wikimedia.org/r/760901

Change 760901 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX: Avoid empty reference cards when clicked

https://gerrit.wikimedia.org/r/760901

Can you clarify if you need anything from us (Editing)? The patches you wrote looked good to me, and it seems like they fix the issue.

In T232330#7712503, @matmarex wrote:

Can you clarify if you need anything from us (Editing)? The patches you wrote looked good to me, and it seems like they fix the issue.

Thank you. Nothing else needed for this ticket. We need some help from Editng team with https://phabricator.wikimedia.org/T286788#7526054 though.

I see, thanks. Let's continue on T302339: Replace workaround for MWReferenceContextItem in ContentTranslation.

Re-run the test cases from https://phabricator.wikimedia.org/T199512#4629883

• wmf.25: en:Victoria island translated to Catalan with Apertium.

✅ Web site reference	✅ Edit Website reference
✅ Book reference	✅ Edit Book reference

• wmf.25: en:Silent Hill 2 translated to Catalan with Apertium.

❌ Cite news	Edit Cite news reference	Comments
	(1) the reference is recognized as Cite news when a user hovers over it (2) Only two values (fields) of the original Cite news are displayed	The original Cite news reference:
✅ Cite journal	✅ Edit Cite journal reference	Comments
		The original Cite journal reference

Question:

• Cite news seems to be the only reference that presents an issue. Should it be addressed in a separate task?

News is not defined for Cite tool in Catalan wikipedia. It is defined in Spanish wikipedia though. So the behaviour of Cite News at Catalan wikipedia is expected.