Page MenuHomePhabricator

Clicking on images takes you to a black screen due to JS error from MediaViewer using mw.Title internals which have changed
Closed, ResolvedPublic

Description

Example:

Event Timeline

greg triaged this task as Unbreak Now! priority.Sep 10 2019, 7:04 PM
greg created this task.
Restricted Application added subscribers: Liuxinyu970226, Aklapper. · View Herald TranscriptSep 10 2019, 7:04 PM
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

jQuery.Deferred exception: Cannot read property 'toLowerCase' of undefined TypeError: Cannot read property 'toLowerCase' of undefined

I'm blaming Ed.

Not sure why that is my fault, but it looks like it should be .getExtension() instead of .extension.

Ah, yes, ext = this.thumbs[ this.currentIndex ].title.ext.toLowerCase();, reaching into the inner state.

Change 535685 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/MultimediaViewer@master] mmv: Don't try to use internal (now removed) ext property of mw.Title

https://gerrit.wikimedia.org/r/535685

Change 535686 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/3D@master] mmv.3d: Don't try to use internal (now removed) ext property of mw.Title

https://gerrit.wikimedia.org/r/535686

Jdforrester-WMF renamed this task from Clicking on images takes you to a black screen to Clicking on images takes you to a black screen due to JS fatal from MediaViewer using mw.Title internals which have changed.Sep 10 2019, 9:25 PM
Jdforrester-WMF added a subscriber: thiemowmde.
Krinkle renamed this task from Clicking on images takes you to a black screen due to JS fatal from MediaViewer using mw.Title internals which have changed to Clicking on images takes you to a black screen due to JS error from MediaViewer using mw.Title internals which have changed.Sep 10 2019, 10:39 PM

Change 535685 merged by jenkins-bot:
[mediawiki/extensions/MultimediaViewer@master] mmv: Don't try to use internal (now removed) ext property of mw.Title

https://gerrit.wikimedia.org/r/535685

Change 535686 merged by jenkins-bot:
[mediawiki/extensions/3D@master] mmv.3d: Don't try to use internal (now removed) ext property of mw.Title

https://gerrit.wikimedia.org/r/535686

Change 535739 had a related patch set uploaded (by Catrope; owner: Jforrester):
[mediawiki/extensions/MultimediaViewer@wmf/1.34.0-wmf.22] mmv: Don't try to use internal (now removed) ext property of mw.Title

https://gerrit.wikimedia.org/r/535739

Change 535740 had a related patch set uploaded (by Catrope; owner: Jforrester):
[mediawiki/extensions/3D@wmf/1.34.0-wmf.22] mmv.3d: Don't try to use internal (now removed) ext property of mw.Title

https://gerrit.wikimedia.org/r/535740

Change 535739 merged by jenkins-bot:
[mediawiki/extensions/MultimediaViewer@wmf/1.34.0-wmf.22] mmv: Don't try to use internal (now removed) ext property of mw.Title

https://gerrit.wikimedia.org/r/535739

Change 535740 merged by jenkins-bot:
[mediawiki/extensions/3D@wmf/1.34.0-wmf.22] mmv.3d: Don't try to use internal (now removed) ext property of mw.Title

https://gerrit.wikimedia.org/r/535740

Krinkle closed this task as Resolved.Sep 11 2019, 1:30 AM
Krinkle assigned this task to Catrope.

The patches above have fixed some known uses, but I'm concerned that the ext property should've be deprecated first as we may not have caught every case.

The patches above have fixed some known uses, but I'm concerned that the ext property should've be deprecated first as we may not have caught every case.

Yeah. I believe this has also broken part of @Rillke's https://commons.wikimedia.org/wiki/User:Rillke/bigChunkedUpload.js though I'm not advocating we start checking userspace scripts :)

though I'm not advocating we start checking userspace scripts :)

7 search results for title.ext in Commons, 3 of them unnecessary copies of bigChunkedUpload.js (creating simple unchanged copies of scripts instead of linking to the original seems to be a nuisance in Commons). Nothing in dewiki and enwiki.