EntitySchema: remove dependency on pre-MCR database schema
Closed, ResolvedPublic
Actions

Description

The extension should not rely on pre-MCR fields in the revision table, and should not assume that the text table is used. Specifically:

remove all references to rev_text_id or ar_text_id.
remove usages of Revision::getRevisionText()
remove reliance on the 'text' flag to Revision::getQueryInfo()

See the parent task(s) for more details.

Care should be taken to maintain backwards compatibility with older versions of MediaWiki, as declared in extension.json.

Details

	Subject	Repo	Branch	Lines +/-
	Remove dependency on pre-MCR database schema	mediawiki/extensions/EntitySchema	master	+28 -27

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T231668 MCR schema migration
Resolved	Zabe	T231674 [Epic] Remove support for writing to the pre-MCR schema
Resolved	daniel	T198557 Remove the ability to write pre-MCR fields, limit the ability to read pre-MCR fields to migration scripts
Resolved	daniel	T198706 Make BackupDumper, WikiExporter and XmlDumpWriter compliant with the MCR revision retrival mechanism (main slot only)
Resolved	BPirkle	T203424 Replace the WikiExporter backup dump streaming mode with batched queries
Resolved	CCicalese_WMF	T242764 Test schema update from old versions to MCR-only schema
Resolved	daniel	T231673 Make SCHEMA_COMPAT_NEW the default MCR migration schema
Resolved	None	T231672 Stop writing to pre-MCR fields in WMF production
Resolved	None	T231671 [EPIC] Ensure all direct or indirect access to pre-MCR fields is gated with the MCR migration stage and emits a warning if any pre-MCR schema fields are accessed
Resolved	CCicalese_WMF	T231693 No direct or indirect access to pre-MCR fields is ungated
Resolved	daniel	T198341 Remove all references to the rev_text_id and ar_text_id fields
Resolved	• holger.knust	T233353 EntitySchema: remove dependency on pre-MCR database schema
Resolved	daniel	T238958 Remove pre-MCR schema fields during update
Resolved	None	T174047 Hide deprecated/unused fields on toolforge replica [MCR]

Event Timeline

daniel created this task.Sep 19 2019, 7:48 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 19 2019, 7:48 PM

daniel moved this task from Backlog to Ready on the Platform Team Workboards (Architecture Review Workboard) board.Sep 19 2019, 7:54 PM

daniel moved this task from Ready to Doing on the Platform Team Workboards (Architecture Review Workboard) board.Sep 20 2019, 9:21 AM

Change 538688 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/EntitySchema@master] Remove dependency on pre-MCR database schema

https://gerrit.wikimedia.org/r/538688

gerritbot added a project: Patch-For-Review.Sep 23 2019, 6:36 PM

• Pchelolo closed this task as Resolved.Sep 27 2019, 5:31 PM

• Pchelolo moved this task from Doing to Done on the Platform Team Workboards (Architecture Review Workboard) board.

Change 538688 merged by jenkins-bot:
[mediawiki/extensions/EntitySchema@master] Remove dependency on pre-MCR database schema

https://gerrit.wikimedia.org/r/538688

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.25; 2019-10-01).Sep 27 2019, 7:00 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 27 2019, 7:10 PM

CCicalese_WMF mentioned this in T198341: Remove all references to the rev_text_id and ar_text_id fields.Oct 21 2019, 6:18 PM