Maniphest T198557

Remove the ability to write pre-MCR fields, limit the ability to read pre-MCR fields to migration scripts
Closed, ResolvedPublic
Actions

Description

Once all code has been ported to use the new MCR schema, B/C code for writing the legacy schema should be removed:

remove support for writing pre-MCR schema from RevisionStore, WikiPage, and related classes
move support for reading pre-MCR schema out of RevisionStore and friends, into code that is specific to the update process. We'll probably need to keep it there forever, but there is no reason to have it in the main code base.
remove $wgMultiContentRevisionSchemaMigrationStage variable. We should probably still have code that checks if that variable is set to something other than READ_NEW | WRITE_NEW. In that case, MediaWiki should fail with a meaningful error message, telling the wiki's owner to update the schema.

This requires the removal of all references to rev_text_id and ar_rev_id, and any other direct access to the legacy schema, in the code base (including extensions).

Details

	Subject	Repo	Branch	Lines +/-
	MovePage: Remove pre-MCR code	mediawiki/core	master	+0 -17
	Remove compat code for pre-MCR schema.	mediawiki/core	master	+733 -2 K

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Declined		dchen	T118706 Conduct heuristic evaluation of image upload and insert flow in VisualEditor
Open		None	T115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
Open		None	T115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
Duplicate		None	T115864 Figure out if the description of the image can be used as the caption on-wiki
Open	Feature	None	T53032 When inserting an image, set its caption by default to be the Commons image description
Open	BUG REPORT	None	T12863 Links on commons upload summaries do not link to commons
Open		None	T5498 Image history is confusing
Stalled		None	T96384 Integrate file revisions with description page history
Open	Feature	None	T39534 Wikimedia Commons should support searching by color
Duplicate		None	T39535 Wikimedia Commons should support filtering by color
Resolved		None	T19503 Provide metadata support on Wikimedia Commons
Open		None	T122038 Moving/Deleting a video file does not move/delete subtitles files, nor does it inform the file mover of their existence
Open		None	T135221 Make TimedText content an integral part of the File page
Open	Feature	None	T2167 Use a dedicated interface for adding meta-data like interwiki links, rather than wikitext
Open		None	T132072 Integrate page meta-data as a new content model revision slot for consistency and atomicity
Resolved		None	T51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
Resolved		None	T68108 [Epic] Store media information for files on Wikimedia Commons as structured data
Open	Feature	None	T14963 allow per-page exceptions to spam blacklist
Open		None	T203157 Make the spam whitelist its own slot
Open	Feature	None	T56140 Move TemplateData to its own JSON-content namespace and associate with Template-namespace, or to its own TemplateData content model and revision slot
Stalled		None	T174043 Deploy Multi-Content Revisions
Open		None	T174022 Implement multi-content revisions
Invalid		None	T198492 Create a maintenance script to drop rev_text_id and ar_text_id from the database.
Resolved		None	T231668 MCR schema migration
Resolved		Zabe	T231674 [Epic] Remove support for writing to the pre-MCR schema
Resolved		daniel	T198557 Remove the ability to write pre-MCR fields, limit the ability to read pre-MCR fields to migration scripts
Resolved		daniel	T198706 Make BackupDumper, WikiExporter and XmlDumpWriter compliant with the MCR revision retrival mechanism (main slot only)
Resolved		BPirkle	T203424 Replace the WikiExporter backup dump streaming mode with batched queries
Resolved		CCicalese_WMF	T242764 Test schema update from old versions to MCR-only schema

Event Timeline

daniel triaged this task as Medium priority.Jul 1 2018, 12:18 PM

daniel created this task.

daniel mentioned this in T198492: Create a maintenance script to drop rev_text_id and ar_text_id from the database..

daniel added a subtask: T198312: Set the WMF cluster to use the new MCR-only schema.Jul 1 2018, 12:21 PM

daniel added a subtask: T198706: Make BackupDumper, WikiExporter and XmlDumpWriter compliant with the MCR revision retrival mechanism (main slot only).Jul 3 2018, 12:48 PM

daniel mentioned this in T174047: Hide deprecated/unused fields on toolforge replica [MCR].Sep 11 2018, 2:03 PM

daniel closed subtask T198561: Make "write both, read new" the default MCR migration stage for fresh MediaWiki installs / for CI as Resolved.Sep 11 2018, 2:26 PM

daniel reopened subtask T198561: Make "write both, read new" the default MCR migration stage for fresh MediaWiki installs / for CI as Open.Sep 11 2018, 5:55 PM

daniel closed subtask T198561: Make "write both, read new" the default MCR migration stage for fresh MediaWiki installs / for CI as Resolved.Sep 12 2018, 6:59 PM

CCicalese_WMF added projects: Platform Engineering (MCR), Platform Team Legacy (Later).Oct 3 2018, 7:00 PM

CCicalese_WMF moved this task from Inbox to Later on the Multi-Content-Revisions board.

CCicalese_WMF moved this task from Later to Tech Debt on the Multi-Content-Revisions board.Oct 4 2018, 3:00 PM

CCicalese_WMF edited projects, added Multi-Content-Revisions (Tech Debt); removed Multi-Content-Revisions.

daniel updated the task description. (Show Details)Jan 21 2019, 2:41 PM

daniel added a subtask: T198341: Remove all references to the rev_text_id and ar_text_id fields.Jan 21 2019, 2:44 PM

@BPirkle want to look into this? No need to drop other stuff if you are busy. This is just something that's coming up, and seems like something you could take on.

I'm happy to, but it appears that I cannot edit or claim the task.

I was, however, able to claim T198341. I'll start there.

In T198557#4961828, @BPirkle wrote:

I'm happy to, but it appears that I cannot edit or claim the task.

That's odd, there should not be any restrictions to that effect. @Aklapper can you have a look? Thanks!

Krinkle moved this task from Backlog to Deprecate/Remove on the MW-1.33-release board.Apr 12 2019, 2:07 AM

daniel closed subtask T198706: Make BackupDumper, WikiExporter and XmlDumpWriter compliant with the MCR revision retrival mechanism (main slot only) as Resolved.May 15 2019, 10:03 PM

@daniel Given 1.33 has already been cut and scheduled to be released this month, is this something we should defer to the MW 1.34 milestone instead? Or do we have reason to backport it to 1.33 with limited testing? (Or perhaps has this already been resolved?)

Agree, this should be moved to 1.34.

In T198557#5247134, @CCicalese_WMF wrote:

Agree, this should be moved to 1.34.

Sadly, yes. This is very close to done, but didn't quite make it in.

Krinkle mentioned this in T214308: Force usage of MCR aware database schema.Jun 14 2019, 2:58 PM

Krinkle moved this task from Blocker to Deprecate/Remove on the MW-1.34-release board.Jun 15 2019, 12:28 AM

WDoranWMF moved this task from Later to Mop Column on the Platform Team Legacy board.Jul 5 2019, 2:09 PM

WDoranWMF removed a project: Platform Team Legacy (Later).

WDoranWMF moved this task from MCR to mop on the Platform Engineering board.Jul 26 2019, 6:39 PM

WDoranWMF edited projects, added Core Platform Team Initiatives (MCR); removed Platform Engineering (MCR).

CCicalese_WMF edited projects, added Core Platform Team Initiatives (MCR Schema Migration); removed Core Platform Team Initiatives (MCR).Aug 1 2019, 3:38 AM

daniel renamed this task from Remove support for legacy pre-MCR schema to Remove support for writing to the pre-MCR schema.Aug 5 2019, 11:25 AM

daniel updated the task description. (Show Details)

Krinkle unsubscribed.Aug 27 2019, 2:10 PM

CCicalese_WMF added a parent task: T231674: [Epic] Remove support for writing to the pre-MCR schema.Aug 30 2019, 10:48 PM

CCicalese_WMF removed a subtask: T198341: Remove all references to the rev_text_id and ar_text_id fields.Aug 30 2019, 10:51 PM

CCicalese_WMF removed a subtask: T214308: Force usage of MCR aware database schema.Aug 30 2019, 11:43 PM

CCicalese_WMF removed a subtask: T198312: Set the WMF cluster to use the new MCR-only schema.Aug 30 2019, 11:48 PM

CCicalese_WMF removed a subtask: T198561: Make "write both, read new" the default MCR migration stage for fresh MediaWiki installs / for CI.Aug 31 2019, 12:10 AM

Hey there, should this be moved to 1.35? The cut is a couple of weeks away? If it needs to go out in 1.34, is there anything I can do to help get it out of the door?

In T198557#5469771, @Jdforrester-WMF wrote:

Hey there, should this be moved to 1.35? The cut is a couple of weeks away? If it needs to go out in 1.34, is there anything I can do to help get it out of the door?

Yes, removing the code can wait. We should default to "new schema only" in 1.34, but that's tracked in a separate ticket.

daniel renamed this task from Remove support for writing to the pre-MCR schema to Remove the ability to write pre-MCR fields, limit the ability to read pre-MCR fields to migration scripts.Sep 6 2019, 8:46 AM

Krinkle moved this task from Blocker to To deprecate or remove on the MW-1.35-release board.Oct 11 2019, 10:45 PM

CCicalese_WMF added projects: Story, Platform Team Workboards (User Stories).Nov 23 2019, 4:48 PM

Change 558581 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] [DNM] Remove compat code for pre-MCR schema.

https://gerrit.wikimedia.org/r/558581

gerritbot added a project: Patch-For-Review.Dec 17 2019, 4:24 PM

Moving to clinic duty, since I'm working on this now.

daniel moved this task from Inbox to Waiting for Review on the Platform Team Workboards (Clinic Duty Team) board.Dec 17 2019, 4:25 PM

daniel moved this task from Waiting for Review to Doing(WIP:5) on the Platform Team Workboards (Clinic Duty Team) board.Jan 6 2020, 11:34 AM

daniel closed subtask T242764: Test schema update from old versions to MCR-only schema as Resolved.Feb 24 2020, 8:19 PM

daniel moved this task from Doing(WIP:5) to Waiting for Review on the Platform Team Workboards (Clinic Duty Team) board.Feb 24 2020, 8:44 PM

Anomie moved this task from Waiting for Review to Doing(WIP:5) on the Platform Team Workboards (Clinic Duty Team) board.Mar 11 2020, 8:10 PM

• eprodromou edited projects, added Platform Team Workboards (Initiatives); removed Platform Team Workboards (Clinic Duty Team).Mar 17 2020, 3:48 PM

• eprodromou moved this task from Later to Now on the Platform Team Workboards (Initiatives) board.

• eprodromou removed a project: Platform Team Workboards (Initiatives).Mar 17 2020, 5:37 PM

Change 558581 merged by jenkins-bot:
[mediawiki/core@master] Remove compat code for pre-MCR schema.

https://gerrit.wikimedia.org/r/558581

The above patch makes it so that wgContentHandlerUseDB is ignored and always true, with the note @todo remove once no extensions read it any more. - see https://gerrit.wikimedia.org/r/#/q/topic:wgContentHandlerUseDB for removing uses from all repositories hosted on gerrit

Change 583606 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] MovePage: Remove pre-MCR code

https://gerrit.wikimedia.org/r/583606

gerritbot added a project: Patch-For-Review.Mar 26 2020, 2:24 PM

Change 583606 merged by jenkins-bot:
[mediawiki/core@master] MovePage: Remove pre-MCR code

https://gerrit.wikimedia.org/r/583606

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.26; 2020-03-31).Mar 26 2020, 4:00 PM

@daniel @Anomie Is there anything remaining to be done for this task?

It's done, as far as I know

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:41 PM

Remove the ability to write pre-MCR fields, limit the ability to read pre-MCR fields to migration scriptsClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

Remove the ability to write pre-MCR fields, limit the ability to read pre-MCR fields to migration scripts
Closed, ResolvedPublic
Actions

Related Objects
Search...