Force usage of MCR aware database schema
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

By the next release (1.34), MediaWiki should no longer support writing to only the MCR-unaware legacy revision storage schema.

RevisionStore already has several checks for $mcrMigrationStage in the constructor. This means that it should now fail if SCHEMA_COMPAT_WRITE_NEW is not set.

Details

	Subject	Repo	Branch	Lines +/-
	Remove tests that were skipped for MCR-enabled schema	mediawiki/core	master	+0 -136
	Force usage of MCR aware database schema	mediawiki/core	master	+5 -959

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T231668 MCR schema migration
Resolved	Zabe	T231674 [Epic] Remove support for writing to the pre-MCR schema
Resolved	daniel	T231673 Make SCHEMA_COMPAT_NEW the default MCR migration schema
Resolved	• Clarakosi	T214308 Force usage of MCR aware database schema
Resolved	daniel	T198706 Make BackupDumper, WikiExporter and XmlDumpWriter compliant with the MCR revision retrival mechanism (main slot only)
Resolved	BPirkle	T203424 Replace the WikiExporter backup dump streaming mode with batched queries

Event Timeline

daniel triaged this task as Medium priority.Jan 21 2019, 2:40 PM

daniel created this task.

daniel added a subtask: T198706: Make BackupDumper, WikiExporter and XmlDumpWriter compliant with the MCR revision retrival mechanism (main slot only).Jan 21 2019, 2:42 PM

daniel closed subtask T198706: Make BackupDumper, WikiExporter and XmlDumpWriter compliant with the MCR revision retrival mechanism (main slot only) as Resolved.May 15 2019, 10:03 PM

CCicalese_WMF edited projects, added Platform Team Workboards; removed Platform Team Legacy (Later).Jun 10 2019, 2:56 PM

CCicalese_WMF moved this task from Not a real column to Team 3 on the Platform Team Workboards board.

CCicalese_WMF edited projects, added Platform Team Workboards (Team 3); removed Platform Team Workboards.

CCicalese_WMF moved this task from Backlog to Ready on the Platform Team Workboards (Team 3) board.

CCicalese_WMF set the point value for this task to 1.

• kchapman subscribed.Jun 10 2019, 2:58 PM

• WDoranWMF subscribed.Jun 10 2019, 2:58 PM

Per T198557#5247134, no longer aimed at MW 1.33. (Not adding MW 1.34, because the parent task tracks that already.)

CCicalese_WMF moved this task from Ready to Backlog on the Platform Team Workboards (Team 3) board.Jul 1 2019, 2:48 PM

• WDoranWMF moved this task from Backlog to mop on the Platform Team Workboards (Team 3) board.Jul 17 2019, 4:45 PM

• WDoranWMF removed a project: Platform Team Workboards (Team 3).

• WDoranWMF moved this task from MCR to mop on the Platform Engineering board.Jul 26 2019, 6:39 PM

• WDoranWMF edited projects, added Core Platform Team Initiatives (MCR); removed Platform Engineering (MCR).

CCicalese_WMF edited projects, added Core Platform Team Initiatives (MCR Schema Migration); removed Core Platform Team Initiatives (MCR).Aug 1 2019, 3:42 AM

daniel added a subtask: T200918: Make sure code that accesses legacy pre-MCR fields triggers warnings before switching off WRITE_OLD (compat) mode..Aug 27 2019, 1:04 PM

Krinkle unsubscribed.Aug 27 2019, 2:10 PM

CCicalese_WMF edited parent tasks, added: T231673: Make SCHEMA_COMPAT_NEW the default MCR migration schema; removed: T198557: Remove the ability to write pre-MCR fields, limit the ability to read pre-MCR fields to migration scripts.Aug 30 2019, 11:43 PM

CCicalese_WMF removed a subtask: T200918: Make sure code that accesses legacy pre-MCR fields triggers warnings before switching off WRITE_OLD (compat) mode..

daniel added a project: MW-1.34-release.Sep 6 2019, 8:47 AM

daniel updated the task description. (Show Details)

Why is this tagged Wikidata? Is Wikibase incompatible with the new schema or something? (It looks like production is currently configured to write both but read new – perhaps Wikibase still reads old somewhere?)

In T214308#5499106, @Lucas_Werkmeister_WMDE wrote:

Why is this tagged Wikidata? Is Wikibase incompatible with the new schema or something? (It looks like production is currently configured to write both but read new – perhaps Wikibase still reads old somewhere?)

I think this was just inherited. T231668 has been under the Wikidata umbrella because of SDC. I'll untag.

daniel added a project: Platform Team Workboards (Architecture Review Workboard).Sep 20 2019, 12:15 PM

daniel updated the task description. (Show Details)

daniel moved this task from Backlog to Ready on the Platform Team Workboards (Architecture Review Workboard) board.Sep 23 2019, 5:15 PM

daniel updated the task description. (Show Details)Sep 23 2019, 5:29 PM

Change 538977 had a related patch set uploaded (by Clarakosi; owner: Clarakosi):
[mediawiki/core@master] Force usage of MCR aware database schema

https://gerrit.wikimedia.org/r/538977

gerritbot added a project: Patch-For-Review.Sep 24 2019, 10:08 PM

daniel moved this task from Ready to Doing on the Platform Team Workboards (Architecture Review Workboard) board.Sep 25 2019, 9:01 AM

daniel moved this task from Doing to Waiting for Review on the Platform Team Workboards (Architecture Review Workboard) board.

daniel moved this task from Waiting for Review to Doing on the Platform Team Workboards (Architecture Review Workboard) board.Sep 26 2019, 8:40 PM

Change 538977 merged by jenkins-bot:
[mediawiki/core@master] Force usage of MCR aware database schema

https://gerrit.wikimedia.org/r/538977

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.25; 2019-10-01).Sep 27 2019, 6:00 PM

• Clarakosi closed this task as Resolved.Sep 27 2019, 6:24 PM

• Clarakosi claimed this task.

• Clarakosi moved this task from Doing to Done on the Platform Team Workboards (Architecture Review Workboard) board.

Change 539609 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] Remove tests that were skipped for MCR-enabled schema

https://gerrit.wikimedia.org/r/539609

Change 539609 merged by jenkins-bot:
[mediawiki/core@master] Remove tests that were skipped for MCR-enabled schema