Maniphest T200918

Make sure code that accesses legacy pre-MCR fields triggers warnings before switching off WRITE_OLD (compat) mode.
Closed, ResolvedPublic
Actions

Description

To get warnings, we should:

undo T201164: Temporarily disable deprecation warnings for code that accesses rev_text_id or the text table directly.
make the DB abstraction layer when something uses the rev_text_id or ar_text_id fields in a select.
make the DB abstraction layer when something uses the rev_content_model and rev_content_format in a select.

There seems to be no goo way to make the DB abstract layer issue such warnings though. We will probably have to hack something in. Regular expressions against the generated SQL, if all else fails...

Details

	Subject	Repo	Branch	Lines +/-
	Log a warning when the 'text' flag is used with getQueryInfo()	mediawiki/core	master	+1 -3

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T231668 MCR schema migration
Resolved	Zabe	T231674 [Epic] Remove support for writing to the pre-MCR schema
Resolved	daniel	T198557 Remove the ability to write pre-MCR fields, limit the ability to read pre-MCR fields to migration scripts
Resolved	daniel	T198706 Make BackupDumper, WikiExporter and XmlDumpWriter compliant with the MCR revision retrival mechanism (main slot only)
Resolved	BPirkle	T203424 Replace the WikiExporter backup dump streaming mode with batched queries
Resolved	CCicalese_WMF	T242764 Test schema update from old versions to MCR-only schema
Resolved	daniel	T231673 Make SCHEMA_COMPAT_NEW the default MCR migration schema
Resolved	None	T231672 Stop writing to pre-MCR fields in WMF production
Resolved	None	T231671 [EPIC] Ensure all direct or indirect access to pre-MCR fields is gated with the MCR migration stage and emits a warning if any pre-MCR schema fields are accessed
Resolved	None	T231699 A warning is emitted if any pre-MCR fields are accessed
Resolved	None	T200918 Make sure code that accesses legacy pre-MCR fields triggers warnings before switching off WRITE_OLD (compat) mode.
Resolved	daniel	T238958 Remove pre-MCR schema fields during update
Resolved	None	T174047 Hide deprecated/unused fields on toolforge replica [MCR]

Event Timeline

daniel triaged this task as Medium priority.Aug 1 2018, 4:55 PM

daniel created this task.

daniel mentioned this in T201164: Temporarily disable deprecation warnings for code that accesses rev_text_id or the text table directly.Aug 3 2018, 11:17 AM

daniel updated the task description. (Show Details)

daniel added a subtask: T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo()..Aug 3 2018, 11:25 AM

CCicalese_WMF added projects: Platform Team Legacy (Later), Platform Engineering (MCR: Deployment).Oct 3 2018, 5:09 PM

CCicalese_WMF moved this task from MCR: Deployment to MCR on the Platform Engineering board.Oct 4 2018, 3:12 PM

CCicalese_WMF edited projects, added Platform Engineering (MCR); removed Platform Engineering (MCR: Deployment).

daniel closed subtask T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo(). as Resolved.Apr 17 2019, 11:11 AM

daniel reopened subtask T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo(). as Open.Apr 17 2019, 11:14 AM

daniel mentioned this in T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo()..Apr 17 2019, 12:04 PM

• WDoranWMF moved this task from Later to Mop Column on the Platform Team Legacy board.Jul 5 2019, 2:12 PM

• WDoranWMF removed a project: Platform Team Legacy (Later).

• WDoranWMF moved this task from MCR to mop on the Platform Engineering board.Jul 26 2019, 6:39 PM

• WDoranWMF edited projects, added Core Platform Team Initiatives (MCR); removed Platform Engineering (MCR).

CCicalese_WMF edited projects, added Core Platform Team Initiatives (MCR Schema Migration); removed Core Platform Team Initiatives (MCR).Aug 1 2019, 3:52 AM

daniel added a parent task: T214308: Force usage of MCR aware database schema.Aug 27 2019, 1:04 PM

daniel renamed this task from Make sure code that accesses the text table or uses rev_text_id triggers warnings before switching to write-new to Make sure code that accesses legacy pre-MCR fields triggers warnings before switching off WRITE_OLD (compat) mode..Aug 27 2019, 1:19 PM

CCicalese_WMF added a parent task: T231693: No direct or indirect access to pre-MCR fields is ungated.Aug 30 2019, 10:33 PM

CCicalese_WMF removed a parent task: T183487: MCR schema migration stage 3: stop using legacy fields.Aug 30 2019, 10:47 PM

CCicalese_WMF removed a parent task: T214308: Force usage of MCR aware database schema.Aug 30 2019, 11:44 PM

CCicalese_WMF removed a subtask: T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo()..Aug 30 2019, 11:51 PM

CCicalese_WMF edited parent tasks, added: T231699: A warning is emitted if any pre-MCR fields are accessed; removed: T231693: No direct or indirect access to pre-MCR fields is ungated.Aug 30 2019, 11:58 PM

CCicalese_WMF added a project: Platform Team Workboards (Architecture Review Workboard).Sep 17 2019, 4:09 PM

• WDoranWMF moved this task from Backlog to Engineering Tasks Ready for Estimation on the Platform Team Workboards (Architecture Review Workboard) board.Sep 17 2019, 4:09 PM

daniel updated the task description. (Show Details)Sep 17 2019, 4:54 PM

daniel moved this task from Engineering Tasks Ready for Estimation to Ready on the Platform Team Workboards (Architecture Review Workboard) board.Sep 20 2019, 10:23 AM

daniel updated the task description. (Show Details)Sep 23 2019, 5:53 PM

daniel moved this task from Ready to Blocked on the Platform Team Workboards (Architecture Review Workboard) board.Sep 30 2019, 12:22 PM

Change 539921 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Log a warning when the 'text' flag is used with getQueryInfo()

https://gerrit.wikimedia.org/r/539921

gerritbot added a project: Patch-For-Review.Sep 30 2019, 5:27 PM