Page MenuHomePhabricator
Create Task
Maniphest T231673

Make SCHEMA_COMPAT_NEW the default MCR migration schema
Closed, ResolvedPublic
Actions

Description

This is a trivial change but conceptually a milestone.

This is targeted to be complete for the MediaWiki 1.34 release.

Required testing: update.php must work correctly after this change is implemented.

This epic cannot begin until T231671 is complete. Ideally, this epic should not begin until T231672 is complete.

Tasks:

  • in DefaultSettings.php, set $wgMultiContentRevisionSchemaMigrationStage = SCHEMA_COMPAT_NEW;

Details

SubjectRepoBranchLines +/-
Set MCR migration stage to SCHEMA_COMPAT_NEW.mediawiki/coreREL1_34+1 -1
Set MCR migration stage to SCHEMA_COMPAT_NEW.mediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNoneT231668 MCR schema migration
 ResolvedZabeT231674 [Epic] Remove support for writing to the pre-MCR schema
 ResolveddanielT231673 Make SCHEMA_COMPAT_NEW the default MCR migration schema
 Resolved• ClarakosiT214308 Force usage of MCR aware database schema
 ResolvedNoneT231671 [EPIC] Ensure all direct or indirect access to pre-MCR fields is gated with the MCR migration stage and emits a warning if any pre-MCR schema fields are accessed
 ResolvedCCicalese_WMFT231689 Can get bulk access from code that has been using the 'text' for getQueryInfo()
ResolvedCCicalese_WMFT231693 No direct or indirect access to pre-MCR fields is ungated
 ResolveddanielT198341 Remove all references to the rev_text_id and ar_text_id fields
 Resolved• PcheloloT198342 Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo().
 ResolveddanielT198706 Make BackupDumper, WikiExporter and XmlDumpWriter compliant with the MCR revision retrival mechanism (main slot only)
 ResolvedBPirkleT203424 Replace the WikiExporter backup dump streaming mode with batched queries
 Resolved• PcheloloT233356 Flow: remove dependency on pre-MCR database schema
 Resolved• ClarakosiT233357 ReplaceText: remove dependency on pre-MCR database schema
 ResolveddanielT233358 SpamBlacklist: remove dependency on pre-MCR database schema
 Resolved• PcheloloT198343 Replace all calls to Revision::getRevisionText()
 Resolved• PcheloloT228675 Remove direct access to the text table from the Translate extension.
 Resolved• PcheloloT228988 Create batch access interface for page content
 Resolved• PcheloloT233173 Make RevisionStore::newRevisionsFromBatch use BlobStore::getBlobBatch
 Resolved• PcheloloT230834 Create batch access interface for BlobStore
 ResolveddanielT234034 Create low level batch access interface for page content
 ResolveddanielT233350 ActiveAbstract: remove dependency on pre-MCR database schema
 Resolved• holger.knustT233353 EntitySchema: remove dependency on pre-MCR database schema
 Resolved• PcheloloT233355 WikimediaMaintenance: remove dependency on pre-MCR database schema
 ResolvedNoneT231699 A warning is emitted if any pre-MCR fields are accessed
 ResolvedNoneT200918 Make sure code that accesses legacy pre-MCR fields triggers warnings before switching off WRITE_OLD (compat) mode.
 ResolveddanielT236735 Allow WikiExporter to function with MCR-only schema

Event Timeline

CCicalese_WMF triaged this task as Medium priority.Aug 30 2019, 5:43 PM
CCicalese_WMF created this task.
CCicalese_WMF added a project: MW-1.34-release.
CCicalese_WMF mentioned this in T231674: [Epic] Remove support for writing to the pre-MCR schema.Aug 30 2019, 5:47 PM
CCicalese_WMF moved this task from Epic Backlog to Need User Stories on the Platform Team Workboards (Epics) board.Aug 30 2019, 6:18 PM
CCicalese_WMF added a subtask: T214308: Force usage of MCR aware database schema.Aug 30 2019, 11:43 PM
CCicalese_WMF moved this task from Need User Stories to Ready for Engineering on the Platform Team Workboards (Epics) board.Aug 31 2019, 12:38 AM
daniel added a parent task: T231674: [Epic] Remove support for writing to the pre-MCR schema.Sep 1 2019, 1:16 PM
daniel added a subtask: T231671: [EPIC] Ensure all direct or indirect access to pre-MCR fields is gated with the MCR migration stage and emits a warning if any pre-MCR schema fields are accessed.
CCicalese_WMF removed a project: Platform Engineering.Sep 3 2019, 5:00 PM
Jdforrester-WMF subscribed.Sep 5 2019, 9:24 PM

Hey there, should this be moved to 1.35? The cut is a couple of weeks away. If it needs to go out in 1.34, is there anything I can do to help get it out of the door?

daniel subscribed.Sep 6 2019, 8:57 AM
In T231673#5469781, @Jdforrester-WMF wrote:

Hey there, should this be moved to 1.35? The cut is a couple of weeks away. If it needs to go out in 1.34, is there anything I can do to help get it out of the door?

I really hope this can make the cut 1.34. We need a release for this to settle, before we remove the migration code, and it would be really annoying if code for the pre-MCR schema made it into 1.35, since that's an LTS release. We'd have to maintain it for several more years.

The change here is trivial, but it's blocked on fixing some remaining usages of the old schema in core and critical extensions, specifically the Translate extension. CPT has been actively working on this and we have resolved the (hopefully) last big blocker last week, see T228988: Create batch access interface for page content.

We'll keep chipping away at the remaining blockers, and hopefully, we'll be able to flip this switch by the cut-off date.

Jdforrester-WMF added a comment.Sep 6 2019, 6:39 PM

That means that this task should be blocked by a task for fixing the remaining usages… presumably T231671: [EPIC] Ensure all direct or indirect access to pre-MCR fields is gated with the MCR migration stage and emits a warning if any pre-MCR schema fields are accessed?

daniel mentioned this in T198492: Create a maintenance script to drop rev_text_id and ar_text_id from the database..Sep 11 2019, 6:44 AM
daniel mentioned this in T214308: Force usage of MCR aware database schema.Sep 20 2019, 12:17 PM
• Clarakosi closed subtask T214308: Force usage of MCR aware database schema as Resolved.Sep 27 2019, 6:24 PM
CCicalese_WMF moved this task from Ready for Engineering to Doing on the Platform Team Workboards (Epics) board.Oct 22 2019, 12:15 PM
daniel updated the task description. (Show Details)Oct 28 2019, 1:41 PM
daniel updated the task description. (Show Details)
daniel added a subtask: T236735: Allow WikiExporter to function with MCR-only schema.Oct 28 2019, 8:04 PM
gerritbot added a comment.Oct 28 2019, 8:17 PM

Change 546715 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] [DNM] Set MCR migration stage to SCHEMA_COMPAT_NEW.

https://gerrit.wikimedia.org/r/546715

gerritbot added a project: Patch-For-Review.Oct 28 2019, 8:17 PM
daniel added a comment.Oct 28 2019, 8:23 PM
In T231673#5471838, @Jdforrester-WMF wrote:

That means that this task should be blocked by a task for fixing the remaining usages… presumably T231671: [EPIC] Ensure all direct or indirect access to pre-MCR fields is gated with the MCR migration stage and emits a warning if any pre-MCR schema fields are accessed?

Yes.

daniel closed subtask T236735: Allow WikiExporter to function with MCR-only schema as Resolved.Oct 29 2019, 8:48 AM
CCicalese_WMF closed subtask T231671: [EPIC] Ensure all direct or indirect access to pre-MCR fields is gated with the MCR migration stage and emits a warning if any pre-MCR schema fields are accessed as Resolved.Nov 4 2019, 3:38 PM
CCicalese_WMF added a parent task: T232023: Release MW 1.34.Nov 5 2019, 11:14 PM
Krinkle removed a parent task: T232023: Release MW 1.34.Nov 6 2019, 12:55 AM
CCicalese_WMF added subscribers: Krinkle, Reedy.Nov 6 2019, 4:09 PM

@Krinkle, I had added this as a subtask to T232023 at @Reedy's suggestion to indicate that it is blocking the MW 1.34 release.

gerritbot added a comment.Nov 13 2019, 3:02 PM

Change 549903 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Stop creating pre-MCR fields

https://gerrit.wikimedia.org/r/549903

gerritbot added a comment.Nov 18 2019, 3:56 PM

Change 546715 merged by jenkins-bot:
[mediawiki/core@master] Set MCR migration stage to SCHEMA_COMPAT_NEW.

https://gerrit.wikimedia.org/r/546715

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.8; 2019-11-26).Nov 18 2019, 4:00 PM
gerritbot added a comment.Nov 18 2019, 5:29 PM

Change 551592 had a related patch set uploaded (by Jforrester; owner: Daniel Kinzler):
[mediawiki/core@REL1_34] Set MCR migration stage to SCHEMA_COMPAT_NEW.

https://gerrit.wikimedia.org/r/551592

gerritbot added a comment.Nov 22 2019, 9:13 PM

Change 551592 merged by jenkins-bot:
[mediawiki/core@REL1_34] Set MCR migration stage to SCHEMA_COMPAT_NEW.

https://gerrit.wikimedia.org/r/551592

ReleaseTaggerBot added a project: MW-1.34-notes.Nov 22 2019, 10:00 PM
Jdforrester-WMF closed this task as Resolved.Nov 22 2019, 10:07 PM
Jdforrester-WMF assigned this task to daniel.
CCicalese_WMF updated the task description. (Show Details)Nov 22 2019, 11:17 PM
CCicalese_WMF moved this task from Doing to Done! on the Platform Team Workboards (Epics) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL