Page MenuHomePhabricator

Make RevisionStore::newRevisionsFromBatch use BlobStore::getBlobBatch
Closed, ResolvedPublic

Description

We have introduced RevisionStore::newRevisionsFromBatch that is capable of creating a batch of RevisionRecord instances given the batch of database rows. Additionally, in T230834 we've introduced BlobStore::getBlobBatch to fetch a batch of blobs given the addresses. This task is about connecting the two.

RevisionStore::newRevisionsFromBatch has a content option, that indicates that the content of certain slot of all the revisions within the batch should be preloaded. Ideally if this flag is set, we don't want to use the BlobStore::getBlobsBatch for all the slots and then provide them into RevisionStore::newRevisionFromRowAndSlots. Perhaps expanding the public interface of this method wouldn't be too helpful, so an internal version of the method should be created.

Details

Related Gerrit Patches:

Related Objects

StatusSubtypeAssignedTask
OpenNone
OpenNone
Opendaniel
ResolvedCCicalese_WMF
Resolveddaniel
ResolvedNone
ResolvedNone
ResolvedCCicalese_WMF
ResolvedCCicalese_WMF
Resolveddaniel
ResolvedPchelolo
Resolveddaniel
ResolvedBPirkle
ResolvedPchelolo
ResolvedPchelolo
ResolvedPchelolo
ResolvedPchelolo
Resolveddaniel
OpenNone
OpenNone

Event Timeline

Change 537569 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] Use BlobStore::getBlobBatch for RevisionStore::newRevisionsFromBatch

https://gerrit.wikimedia.org/r/537569

Change 537569 merged by jenkins-bot:
[mediawiki/core@master] Use BlobStore::getBlobBatch for RevisionStore::newRevisionsFromBatch

https://gerrit.wikimedia.org/r/537569