| • alexhollender_WMF | |
| Oct 23 2019, 10:59 PM |
| F34438804: Screen Shot 2021-05-03 at 2.03.35 PM.png | |
| May 3 2021, 12:04 PM |
| F31506338: image.png | |
| Jan 9 2020, 6:17 PM |
| F31506341: image.png | |
| Jan 9 2020, 6:17 PM |
| F31477226: T236328.png | |
| Dec 16 2019, 3:28 AM |
| F31053616: Screenshot_20191107-100427.png | |
| Nov 7 2019, 4:35 AM |
| F30877358: image.png | |
| Oct 23 2019, 11:01 PM |
| F30877352: image.png | |
| Oct 23 2019, 10:59 PM |
| F30877351: image.png | |
| Oct 23 2019, 10:59 PM |
On the Recent changes and Watchlist pages in advanced mode the username should appear on its own line.
.mw-userlink {
display: block;
clear: both;
}| AC | Status | Details |
|---|---|---|
| 1 | ❌ | T236328#5743123 |
Since we've already broken up the text-blog as it appears on desktop I think we should continue on and put the username on its own line
Change 548531 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] username should appear on its own line on RecentChanges and Watchlist
Are we sure this is helping readability and current use cases of these pages? Could we eventually add a user icon to make this simpler scannable?
There have been complaints about the size of links and how close together they are (see T237204) so theoretically this could help with that. Increasing the font-size seems worth considering as well.
Does this need more discussion or can we go ahead with the original plan (note we can always do follow ups - that patch is pretty small)
I do not think we need to start the username on a new line on a tablet. This would just make the page long. Tablet is pretty much like desktop if you use it in landscape mode.
@pmiazga @nray @Jdrewniak @Niedzielski feel free to pick this task up/revise it if it needs any follow ups while I'm away. Hopefully it is a straightforward self explanatory patch, but let me know now if you have any questions.
Change 548531 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] username should appear on its own line on RecentChanges and Watchlist
Status: ❌ FAIL
OS: macOS Catalina
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX
**QA instructions
test on the beta cluster, recent changes and watchlist pages (https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:RecentChanges?hidebots=1&hidecategorization=1&hideWikibase=1&limit=50&days=7&enhanced=1&urlversion=2)
❌ AC1: username should appear on its own line
The username appears on its own line, but it doesn't match the updated image in the task description.
Change 562273 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[mediawiki/skins/MinervaNeue@master] username & userlinks should appear on a separate line on RecentChanges and Watchlist
Change 562273 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] username & userlinks should appear on a separate line on RecentChanges and Watchlist
This bug description doesn't look accurate any more. What's left to do here? I'm not seeing the gaps described in T236328#5790599
I see only one of these issues (gap between user name and next line). @alexhollender - are we okay to close this?
