@matmarex I can't find where you said this but I noticed your comment (whereever it was!) about semicolon-separator in some cases having an extraneous trailing space. I think having the space in the message is a symptom of bad separation between the presentation and content.
Special:LinksHere seems to be the only other user of the semicolon-separator. I'd like this page to also use pseudo elements in future, so I think the extraneous space needs to be removed in translations rather than from the CSS. It should not be part of this message.

Change 549919 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Remove extraneous semicolons on the history page and DOCUMENT!

https://gerrit.wikimedia.org/r/549919

We'll need to run through the QA again once this latest patch has been merged so I've unchecked the boxes in the description.

regarding the checklist: "on watchlist page there should be a semicolon after title (pending better understanding on wiki)" - this was one of the complaints of "something broken" where this was not expected/wanted

How can this be a dupe, @Huji, if what I reported happens since aa9b5f17107c2c8b30b0765c82bd2a8019f2b935, which was deployed yesterday 0:00 UTC?

In T233649#5649813, @Urbanecm wrote:

How can this be a dupe, @Huji, if what I reported happens since aa9b5f17107c2c8b30b0765c82bd2a8019f2b935, which was deployed yesterday 0:00 UTC?

I was attempting to close it as a duplicate too. Better to consolidate effort here. The QA would make sure it is anywhere it supposed to be and does not appear where it should not.

@Urbanecm we could keep it separate, and treat it as a side effect of this task, but like Ammarpad, I think it is best to keep the discussion consolidated in one task. In an effort to fix something on this task, a lot of regressions have been introduced. It is best to discuss them all here (and keep updating the QA steps in the task definition.

Okay, that makes sense.

In T233649#5648517, @Jdlrobson wrote:

@matmarex I can't find where you said this but I noticed your comment (whereever it was!) about semicolon-separator in some cases having an extraneous trailing space. I think having the space in the message is a symptom of bad separation between the presentation and content.

What there is presentation? Japanese and Chinese don't use space after (full-width) semicolon, and French seems to want space also before: https://translatewiki.net/wiki/Special:Translations?message=Semicolon-separator&namespace=8

FYI, the latest state we are in results in the addition of a Persian semicolon (right one) before (i.e. to the right of) the date string (wrong place) on fawiki, and an unnecessary space is also added after it:

Can we just get this last update pulled back - it obviously needs more discussion.

In T233649#5649829, @Nikerabbit wrote:

In T233649#5648517, @Jdlrobson wrote:

@matmarex I can't find where you said this but I noticed your comment (whereever it was!) about semicolon-separator in some cases having an extraneous trailing space. I think having the space in the message is a symptom of bad separation between the presentation and content.

What there is presentation? Japanese and Chinese don't use space after (full-width) semicolon, and French seems to want space also before: https://translatewiki.net/wiki/Special:Translations?message=Semicolon-separator&namespace=8

I'm not sure what you are asking here. Could you rephrase?
It's perfectly fine to have a space in the translated message. If there are more than one spaces they will be collapsed down to one. What I'm saying is that if you don't have a space the UI should separate the different bits of information in a watchlist/recent changes row.

I've tested https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/549919 pretty extensively and I'm pretty sure this covers all the edge cases we've highlighted. I've updated the QA steps and have been relying on these to confirm the new patch works as expected - please let me know if any edge cases are missing from those QA steps.

Note on Special:Contributions with Vector, .mw-title class is got by Flow Discussion page title.

example:

04:09, 10 November 2019 (diff | hist) . . +26‎ . . Test ''topic'' - 20191110040911 on Talk:Flow QA;

This semicolon is unexpected; at least, it should not be linked.

Regarding "but doing so makes the page inconsistent with the recent changes page " - wasn't this also just added? The semicolon is unnecessary on this page as well. And also it doesn't seem to be "after the title" but actually "before the date" which makes even less sense to precede a timestamp with "; ". These elements are already distinct.

And the QA steps 1&2 appear to contradict:
"The semicolon should not appear on Minerva RecentChanges"
followed by
" The semicolon should appear after any page title on Minerva RecentChanges"

How can these possibly both be true? Please take all this extra unwanted semicolons and toss them.

But doing so makes the page inconsistent with the recent changes page

The semicolon on recent changes has always been in the interface. You can check out an old version of MediaWiki to confirm this.

And the QA steps 1&2 appear to contradict:

Thanks for pointing this out. The URL was correct but not the link label.

Please take all this extra unwanted semicolons and toss them.

@Xaosflux the ultimate goal here is to give a better experience to mobile users who have been at a disadvantage for many years. I understand it's frustrating but dealing with code that hasn't been touched in almost a decade and that lacks documentation of how it's supposed to work sometimes results in unexpected consequences. I'm trying my very best to resolve all these issues and improve the code for everyone. I appreciate your patience and understanding.

@Jdlrobson - the goal seems fine, but it has spilled completely outside of the "mobile user" UX here, if this was contained to mobile most of this discussion wouldn't be ongoing.

@Jdlrobson I think you can merge patch if you want.. This is screenshot from history page.

Special:Contribs look simular.

@ovasileva What "points" which you usually set means?

Change 549919 merged by jenkins-bot:
[mediawiki/core@master] Remove extraneous semicolons in unintended places and DOCUMENT!

https://gerrit.wikimedia.org/r/549919

Change 550559 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@wmf/1.35.0-wmf.5] Remove extraneous semicolons in unintended places and DOCUMENT!

https://gerrit.wikimedia.org/r/550559

completely outside of the "mobile user" UX here, if this was contained to mobile most of this discussion wouldn't be ongoing.

Mobile uses exactly the same HTML as desktop which is the challenge here. We've made dozens of changes in the past few months like this without disrupting desktop but I misjudged this one and unfortunately it didn't quite go too plan....!
Anyway It happens... but I'm afraid we will have to get more comfortable with these kind of short-term frustrations if we want to move the site forward technologically.

In terms of the fix....

The fix is up on the beta cluster now and I've run through the test cases and I'm not seeing any semicolons where they didn't use to be. If you have time, I'd really appreciate any editors checking the links in the description that it behaves as expected and super thanks in advance to @Zoranzoki21 for taking care of the SWAT. You are a star! <3

In T233649#5658465, @Jdlrobson wrote:

completely outside of the "mobile user" UX here, if this was contained to mobile most of this discussion wouldn't be ongoing.

Mobile uses exactly the same HTML as desktop which is the challenge here. We've made dozens of changes in the past few months like this without disrupting desktop but I misjudged this one and unfortunately it didn't quite go too plan....!
Anyway It happens... but I'm afraid we will have to get more comfortable with these kind of short-term frustrations if we want to move the site forward technologically.

In terms of the fix....

The fix is up on the beta cluster now and I've run through the test cases and I'm not seeing any semicolons where they didn't use to be. If you have time, I'd really appreciate any editors checking the links in the description that it behaves as expected and super thanks in advance to @Zoranzoki21 for taking care of the SWAT. You are a star! <3

Oh thank you! Sure, I will do everything what I can to make WMF projects be good place. I checked too, everything looks good now.

Change 550559 merged by jenkins-bot:
[mediawiki/core@wmf/1.35.0-wmf.5] Remove extraneous semicolons in unintended places and DOCUMENT!

https://gerrit.wikimedia.org/r/550559

Mentioned in SAL (#wikimedia-operations) [2019-11-12T23:49:43Z] <catrope@deploy1001> Synchronized php-1.35.0-wmf.5/includes/changes/ChangesList.php: Remove extraneous semicolons (T233649), part 1 (duration: 00m 53s)

Mentioned in SAL (#wikimedia-operations) [2019-11-12T23:50:59Z] <catrope@deploy1001> Synchronized php-1.35.0-wmf.5/resources/src/mediawiki.interface.helpers.styles.less: Remove extraneous semicolons (T233649), part 2 (duration: 00m 52s)

The unexpected semicolons appear to now be gone from:
Special:Contributions
Page History

Are still on:
Special:RecentChanges
Special:Watchlist

Was there a reason these are needed on the last two pages ever discovered?

Those semi colons have always been on Watchlist and RecentChanges pages (you can visit older wikis to confirm). It's not clear if they are needed or were ever needed and if needed why they are semicolons and not one of the other visual separators.

I added some documentation in the code explaining that at a future date we might want to remove them altogether but in my opinion that should be part of a larger design review on desktop.

In T233649#5658010, @Zoranzoki21 wrote:

@ovasileva What "points" which you usually set means?

It's a general estimate of the relative risk associated to each task - it gives us a rough idea of difficulty and an even more vague idea of how long sometime might potentially take.

In T233649#5660494, @Xaosflux wrote:

The unexpected semicolons appear to now be gone from:
Special:Contributions
Page History

Are still on:
Special:RecentChanges
Special:Watchlist

Was there a reason these are needed on the last two pages ever discovered?

I can't reproduce semicolon problems on Special:RecentChanges and Special:Watchlist...

Special:Watchlist

Special:RecentChanges

[off topic]

In T233649#5658010, @Zoranzoki21 wrote:

What "points" which you usually set means?

@Zoranzoki21: See Kanban and Scrum on https://www.mediawiki.org/wiki/Phabricator/Project_management (and please ask general questions that are unrelated to the specific topic of a task in support channels instead - thanks! :) )

In T233649#5664392, @Aklapper wrote:

[off topic]

In T233649#5658010, @Zoranzoki21 wrote:

What "points" which you usually set means?

@Zoranzoki21: See Kanban and Scrum on https://www.mediawiki.org/wiki/Phabricator/Project_management (and please ask general questions that are unrelated to the specific topic of a task in support channels instead - thanks! :) )

I got reply already, thank you!

In T233649#5658010, @Zoranzoki21 wrote:

@ovasileva What "points" which you usually set means?

See https://www.mediawiki.org/wiki/Reading/Web/Team/Story_estimation

AC2: The semicolon should appear after any page title o
❌ AC4: Confirm on RecentChanges in Farsi language on Vector (u

Click the cog and untick "group results by page". This is interfering with your test runs.

AC3: The semicolon should appear after any log entry

Looks like the URL was right but the label was wrong. This should be tested in Vector not Minerva.

❓ AC6: make sure you are able to view suppressed revisions (ask for permission if you can't). Confirm that there are no semicolons on a history page where you are an admin and a revision has been suppressed by an admin - test url

I am uncertain what a suppressed revision looks like. Here is what I see.

The line with the strike through Username or IP removed is a suppressed revision. Sorry for the ambiguity.

AC8: on watchlist page there should be a semicolon after title (

I am seeing Special:EditWatchlist in the screenshot. Please test again on https://en.wikipedia.beta.wmflabs.org/wiki/Special:Watchlist?hidepreviousrevisions=1&hidecategorization=1&hideWikibase=1&limit=250&days=3&urlversion=2 making sure you've not grouped changes by name.

AC9: on Special:Contribs in Vector there is no semicolon after the text (del/undel) (for privileged users)

I realise this now requires sysop privilege and I can't grant it. However I can confirm this is fixed:

Click the cog and untick "group results by page". This is interfering with your test runs.

So-called "Enhanced RC" should be supported.

So-called "Enhanced RC" should be supported.

Why do you think it is not supported? This page wasn't impacted by the regression and the test case hadn't specified the mode to be using. That doesn't mean it's not supported... can you elaborate what you think we've missed @Nemo_bis ?

❓ AC8: on watchlist page there should be a semicolon after title
https://en.wikipedia.beta.wmflabs.org/wiki/Special:Watchlist?hidepreviousrevisions=1&hidecategorization=1&hideWikibase=1&limit=250&days=3&urlversion=2
I wasn't able to see any results. I increased the range to 30 days. Here's what I see:

tried this out - still not seeing the semicolon though

I see the semicolon. I think we have different configurations judging by the spacing to the left of your entries. This is fine..