Page MenuHomePhabricator
Create Task
Maniphest T237048

[Bug] Commons Structured Data clicks through to Wikidata in Dropdown
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  • open chrome on an android device
  • go to https://commons.m.wikimedia.org/wiki/File:GOR_Ranggajati_Sumber.jpg
  • click on the structured data tab
  • start typing in the text box under 'Items portrayed in this file'
  • select one of the suggestions
  • your suggestion should be added as a value, but instead you go to wikidata (works fine on desktop)

This has ripple effects for using tools like AC/DC on mobile or a tablet: https://commons.wikimedia.org/wiki/Help_talk:Gadget-ACDC#Bug_on_Android_tablet_and_mobile

Details

SubjectRepoBranchLines +/-
Handle middle clicks on autocomplete suggestions differentlymediawiki/extensions/WikibaseMediaInfomaster+21 -29
Explicitly prevent default link behavior for entity lookup optionsmediawiki/extensions/WikibaseMediaInfomaster+24 -5
Customize query in gerrit

Related Objects

Event Timeline

Astinson created this task.Oct 31 2019, 7:37 PM
Restricted Application added projects: Wikidata, Structured-Data-Backlog. · View Herald TranscriptOct 31 2019, 7:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• Ramsey-WMF added a comment.Oct 31 2019, 8:04 PM

@Astinson Hello. Just to clarify: this is an issue when attempting to select an entity listed in the autosuggest text box when you start typing?

Astinson added a comment.Oct 31 2019, 8:43 PM

yeah, so I start typing, and try to select one of the options: but it opens a new tab. I am on Android devices, editing in Chrome, asking for the desktop version of the site so that I can edit the Structured Data -- in particular I would like to be able to do AC/DC while watching tv, while using a tablet :P

• Ramsey-WMF assigned this task to egardner.Oct 31 2019, 8:51 PM
• Ramsey-WMF added a subscriber: egardner.

Okay. So what I'm guessing is that the functionality implemented for T224604 isn't compatible with Chrome on at least some Android devices (seems to work fine on iOS.). Gonna throw this over to @egardner for further insight.

Masumrezarock100 subscribed.Nov 1 2019, 12:16 AM
Tohaomg subscribed.Nov 29 2019, 11:33 AM

I faced the same issue and I tested it in different situations. This bug appears only on Android devices, but not on Apple devices. On Android devices (I tested it on several devices) it appears in all browsers (tested Opera, Chrome and built-in browser) in both desktop and mobile versions. So this must be an Android related problem.

Tohaomg added a subscriber: • SandraF_WMF.Nov 29 2019, 11:33 AM
egardner moved this task from Triage to Current Work on the Structured-Data-Backlog board.Dec 2 2019, 5:23 PM
egardner edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.
• Ramsey-WMF reassigned this task from egardner to AnneT.Dec 2 2019, 5:23 PM
AnneT moved this task from Incoming to Doing on the Structured-Data-Backlog (Current Work) board.Dec 4 2019, 10:12 PM
gerritbot added a comment.Dec 5 2019, 4:05 PM

Change 554901 had a related patch set uploaded (by Anne Tomasevich; owner: Anne Tomasevich):
[mediawiki/extensions/WikibaseMediaInfo@master] Explicitly prevent default link behavior for entity lookup options

https://gerrit.wikimedia.org/r/554901

gerritbot added a project: Patch-For-Review.Dec 5 2019, 4:05 PM
gerritbot added a comment.Dec 6 2019, 5:12 PM

Change 554901 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Explicitly prevent default link behavior for entity lookup options

https://gerrit.wikimedia.org/r/554901

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.10; 2019-12-10).Dec 6 2019, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 6 2019, 6:10 PM
AnneT moved this task from Doing to Needs QA on the Structured-Data-Backlog (Current Work) board.Dec 6 2019, 6:21 PM
Premeditated subscribed.Dec 8 2019, 10:56 AM
• Ramsey-WMF added a comment.Dec 14 2019, 1:54 AM

@Astinson this fix should be live on Commons now. Want to give a try?

• Ramsey-WMF moved this task from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.Dec 14 2019, 2:03 AM
Tohaomg added a comment.Dec 14 2019, 3:58 AM
In T237048#5741217, @Ramsey-WMF wrote:

@Astinson this fix should be live on Commons now. Want to give a try?

The bug still occurs.

Sadads subscribed.Dec 16 2019, 1:30 PM

Yep, still occurs for me to: tried adding palm tree to
https://commons.m.wikimedia.org/wiki/File:GOR_Ranggajati_Sumber.jpg#/random
and it opens wikidata.

• Ramsey-WMF moved this task from Verify on Production to Doing on the Structured-Data-Backlog (Current Work) board.Dec 16 2019, 5:28 PM

SDC team will consult Android team for next steps.

• Ramsey-WMF moved this task from Doing to Verify on Production on the Structured-Data-Backlog (Current Work) board.Dec 17 2019, 5:36 PM
• Ramsey-WMF moved this task from Verify on Production to Doing on the Structured-Data-Backlog (Current Work) board.Dec 18 2019, 5:40 PM
Cparle updated the task description. (Show Details)Jan 21 2020, 3:52 PM
Cparle updated the task description. (Show Details)
Cparle updated the task description. (Show Details)
Cparle added subscribers: • Niedzielski, Jdlrobson, Cparle.EditedJan 21 2020, 3:57 PM

@Ramsey-WMF this isn't an Android team issue, it's a mobile web issue. @Niedzielski @Jdlrobson any ideas? We thought this might fix it but it didn't

• Niedzielski added a comment.Jan 23 2020, 8:45 PM

I can repro the issue in the Chromium device emulator on Vector per the description:

  1. Enable device emulation.
  2. Visit https://commons.m.wikimedia.org/wiki/File:GOR_Ranggajati_Sumber.jpg?debug=true&useskin=vector.
  3. View the structured data tab.
  4. Type "a" in the depicts field.
  5. Tap the first entry.

However, I don't actually see the EntityLookupElement class referenced in the linked patch loaded so either I've got something entirely wrong on my end or that's why the change had no effect.

AnneT added a comment.Jan 24 2020, 2:30 PM

Hey @Niedzielski, that component was refactored into EntityAutocompleteInputWidget in a later patch, see here.

• Niedzielski added a comment.Jan 24 2020, 2:56 PM

@AnneT, eek, I'm not seeing that load either! I do see MenuOptionWidget.

AnneT added a comment.Jan 24 2020, 4:49 PM

Oops, the patch I referred to isn't on production yet. EntityLookupElement was refactored to EntityInputWidget, which is live on prod at the moment with the failing onMousedown method.

Stephen suggested this might be an issue related to the way events are connected and fired in OOUI, which I'll start digging into but may need help from the OOUI gods at some point...

AnneT moved this task from Doing to Incoming on the Structured-Data-Backlog (Current Work) board.Feb 25 2020, 3:35 PM
gerritbot added a comment.Mar 3 2020, 3:56 PM

Change 576374 had a related patch set uploaded (by Anne Tomasevich; owner: Anne Tomasevich):
[mediawiki/extensions/WikibaseMediaInfo@master] Handle middle clicks on autocomplete suggestions differently

https://gerrit.wikimedia.org/r/576374

gerritbot added a project: Patch-For-Review.Mar 3 2020, 3:56 PM
AnneT moved this task from Incoming to Code Review on the Structured-Data-Backlog (Current Work) board.Mar 4 2020, 2:49 PM
Cparle moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Mar 6 2020, 11:21 AM
gerritbot added a comment.Mar 6 2020, 11:45 AM

Change 576374 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Handle middle clicks on autocomplete suggestions differently

https://gerrit.wikimedia.org/r/576374

Maintenance_bot removed a project: Patch-For-Review.Mar 6 2020, 12:10 PM
ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.23; 2020-03-10); removed MW-1.35-notes (1.35.0-wmf.10; 2019-12-10).Mar 7 2020, 2:42 PM
• Ramsey-WMF added a subscriber: Etonkovidova.Mar 9 2020, 6:50 PM

@Etonkovidova would you happen to have an Android device you can test this with?

• Ramsey-WMF reassigned this task from AnneT to Etonkovidova.Mar 10 2020, 9:30 PM
• Ramsey-WMF added a subscriber: AnneT.

Elena said she'll "borrow" an Android device to test this with 😄

Etonkovidova closed this task as Resolved.Mar 12 2020, 2:03 AM

Checked in Chrome on Android device (commons wmf.23) - both mobile and desktop mode - the issue's been fixed.

LucasWerkmeister mentioned this in T342507: Support Lookup where menu items have url but do not navigate when clicked.Jul 23 2023, 2:13 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL