Page MenuHomePhabricator

Step 1: make edit based on fix/update choice (impact: high)
Open, HighPublic13 Story Points

Description

Problem:
In T237333 we built the UI part of deciding the right edit flow (fixing or updating a value). We now need to add the correct edit flow in the backend.

BDD

GIVEN a Bridge edit
AND the editor chooses fix
WHEN saving the edit
THEN the new value overwrites the existing value
AND the rank of the value is not changed
AND the qualifiers and references are preserved

GIVEN a Bridge edit
AND the editor chooses update
WHEN saving the edit
THEN the rank of the existing value is set to normal
AND the new value is stored with preferred rank without qualifiers and references
AND the old value keeps the existing qualifiers and references

Acceptance criteria:

  • the new statement is stored with preferred rank (update flow)
  • the old value is either overwritten (fix flow) or kept with normal rank (update flow)

Notes

  • We likely want to do the update flow in two edits to have useful edit summaries.
  • In the update flow we probably want to add the new value first and then make the rank change on the old value.

Event Timeline

Restricted Application added a project: Wikidata. · View Herald TranscriptTue, Nov 19, 3:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Lydia_Pintscher triaged this task as High priority.Tue, Nov 19, 3:42 PM
Lydia_Pintscher moved this task from Backlog to Needs work on the Wikidata-Bridge board.
Charlie_WMDE updated the task description. (Show Details)Thu, Nov 28, 3:24 PM
Lydia_Pintscher moved this task from Needs work to Ready to estimate on the Wikidata-Bridge board.

We likely want to do the update flow in two edits to have useful edit summaries.

Note: Then we cannot ensure that both edits succeed, which could leave the item in an incorrect state.

Charlie_WMDE updated the task description. (Show Details)Tue, Dec 3, 11:09 AM

Estimation of a the story as it's written in this ticket: 13 points
Notes:

  • cost of ownership are higher
  • more error prone - would need communication to the users + follow up action items
  • better out of the box edit summaries

Estimation of the story where we do the edit in a single revision, with an out-of-the-box edit summary (i.e. whatever it currently is without making any changes to it): 13 points
Notes:

  • this would need some sort of communication because of the new edit pattern in the history
  • this will have not great edit summaries and will probably need an edit summary upgrade later

@Lydia_Pintscher we need a product decision here on which story to proceed with.

Charlie_WMDE set the point value for this task to 13.Tue, Dec 3, 12:02 PM
darthmon_wmde renamed this task from make edit based on fix/update choice to Step 1: make edit based on fix/update choice.Thu, Dec 5, 1:07 PM
Lydia_Pintscher renamed this task from Step 1: make edit based on fix/update choice to Step 1: make edit based on fix/update choice (impact: high).Sun, Dec 8, 1:19 PM

Based on discussion with @Jakob_WMDE and @Rosalie_WMDE it should be possible to get a nicer edit summary for this specific usecase based on what they've worked on. Let's make use of that in T233395 and go with 1 edit here.