Page MenuHomePhabricator
Create Task
Maniphest T240259

Implement `unload handlers` for compose
Closed, ResolvedPublic
Actions

Description

When closing a tab or navigating away from the page we should warn the user if they have unsaved changes. This is done with the onbeforeunload handler.

Details

SubjectRepoBranchLines +/-
Add beforeunload handlersmediawiki/extensions/DiscussionToolsmaster+52 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

ppelberg created this task.Dec 9 2019, 8:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 9 2019, 8:11 PM
Esanders updated the task description. (Show Details)Dec 9 2019, 9:04 PM
ppelberg mentioned this in T239966: [Pre-deployment testing] Retaining draft comments/replies.Dec 10 2019, 1:16 AM
Schnark subscribed.Dec 10 2019, 8:19 AM

See https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw-method-confirmCloseWindow

gerritbot added a comment.Dec 10 2019, 3:17 PM

Change 556204 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/DiscussionTools@master] Add beforeunload handlers

https://gerrit.wikimedia.org/r/556204

gerritbot added a project: Patch-For-Review.Dec 10 2019, 3:17 PM
Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.Dec 10 2019, 3:45 PM
gerritbot added a comment.Dec 13 2019, 7:00 PM

Change 556204 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Add beforeunload handlers

https://gerrit.wikimedia.org/r/556204

Maintenance_bot removed a project: Patch-For-Review.Dec 13 2019, 7:10 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.11; 2019-12-17).Dec 13 2019, 8:00 PM
ppelberg mentioned this in T241393: Abandon changes dialog appears unexpectedly .Dec 23 2019, 10:16 PM
matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.Feb 3 2020, 6:55 PM
matmarex added a project: Editing QA.
JTannerWMF edited projects, added Editing-team (Q3 2019-2020 Kanban Board); removed VisualEditor (Current work), Editing-team.Feb 4 2020, 11:14 PM
JTannerWMF moved this task from Needs Discussion / Investigation to QA on the Editing-team (Q3 2019-2020 Kanban Board) board.
JTannerWMF edited projects, added OWC2020 (OWC2020 Replying 1.0); removed OWC2020.Feb 5 2020, 2:44 AM
JTannerWMF moved this task from Inbox to High Priority on the Editing QA board.
JTannerWMF moved this task from Needs Prioritization to Required before Release on the OWC2020 (OWC2020 Replying 1.0) board.Feb 10 2020, 10:24 PM
Ryasmeen subscribed.Feb 10 2020, 11:56 PM

@Esanders: I am getting this warning message from the browser when I am closing the tab without posting a reply that I typed. Also, while navigating away to the other tabs except "Edit Source" tab.

When I type a reply and click on "Edit Source" tab, it navigates away from the page without giving any warning.

Is it the correct behavior?

Ryasmeen moved this task from QA to Blocked / Needs More Work on the Editing-team (Q3 2019-2020 Kanban Board) board.Feb 10 2020, 11:57 PM
Ryasmeen removed a project: Editing QA.
DLynch subscribed.Feb 11 2020, 4:32 PM

My theory is that @Ryasmeen has NWE enabled, and so "edit source" isn't technically a navigation event (because it's just replacing the contents of the current page). We need to special case detecting and canceling this somehow.

@Ryasmeen If you don't have NWE enabled, let me know, because that'd demolish my theory. 😁

Ryasmeen added a comment.Feb 11 2020, 7:02 PM
In T240259#5872964, @DLynch wrote:

My theory is that @Ryasmeen has NWE enabled, and so "edit source" isn't technically a navigation event (because it's just replacing the contents of the current page). We need to special case detecting and canceling this somehow.

@Ryasmeen If you don't have NWE enabled, let me know, because that'd demolish my theory. 😁

@DLynch: You are right :) I had NWE enabled, this doesn't happen when switching to old wikitext editor.

ppelberg added a comment.EditedFeb 12 2020, 12:07 AM
In T240259#5873772, @Ryasmeen wrote:

@DLynch: You are right :) I had NWE enabled, this doesn't happen when switching to old wikitext editor.

Good spot, @DLynch.

In T240259#5872964, @DLynch wrote:

We need to special case detecting and canceling this somehow.

David, can you describe this in a bit more detail? Does "special case detecting and cancelling" refer to writing a patch to make it so the browser displays a warning message [1] before contributors who a) have NWE enabled and b) have started writing a reply click "Edit source"?

  1. Browser warning message: "Leave site? / Changes you made may not be saved."
DLynch added a comment.Feb 12 2020, 12:11 AM

Yes.

ppelberg added a comment.Feb 12 2020, 12:38 AM
In T240259#5874774, @DLynch wrote:

Yes.

Understood. If you have a task already written, please feel free to close this one as a duplicate: T244942

ppelberg mentioned this in T244942: Make `unload handlers` work for contributors using NWE.Feb 12 2020, 12:40 AM
JTannerWMF moved this task from Blocked / Needs More Work to Ready for Sign Off on the Editing-team (Q3 2019-2020 Kanban Board) board.Feb 12 2020, 6:45 PM
ppelberg closed this task as Resolved.Feb 12 2020, 9:40 PM
ppelberg claimed this task.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptFeb 12 2020, 9:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits