Page MenuHomePhabricator

Wikidata updates(?) are triggering "Call to a member function getPageLanguage() on null" on wmf.10 wikis
Closed, ResolvedPublic

Description

Error

MediaWiki version: 1.35.0-wmf.10

message
Call to a member function getPageLanguage() on null

Impact

This is 80% of all current production log noise. Declaring this a train blocker until proven fine.

Notes

Details

Request ID
XfA84gpAIDAAAFtsQEAAAABO
Request URL
https://www.mediawiki.org/w/index.php?title=Category%3aLink_templates&action=info
Stack Trace
exception.trace
#0 /srv/mediawiki/php-1.35.0-wmf.10/extensions/Wikibase/client/includes/Store/DescriptionLookup.php(73): Wikibase\Client\Store\DescriptionLookup->getCentralDescriptions(array)
#1 /srv/mediawiki/php-1.35.0-wmf.10/extensions/Wikibase/client/includes/Store/DescriptionLookup.php(100): Wikibase\Client\Store\DescriptionLookup->getDescriptions(array, array, array)
#2 /srv/mediawiki/php-1.35.0-wmf.10/extensions/Wikibase/client/includes/Hooks/InfoActionHookHandler.php(135): Wikibase\Client\Store\DescriptionLookup->getDescription(Title, string)
#3 /srv/mediawiki/php-1.35.0-wmf.10/extensions/Wikibase/client/includes/Hooks/InfoActionHookHandler.php(117): Wikibase\Client\Hooks\InfoActionHookHandler->handle(RequestContext, array)
#4 /srv/mediawiki/php-1.35.0-wmf.10/includes/Hooks.php(174): Wikibase\Client\Hooks\InfoActionHookHandler::onInfoAction(RequestContext, array)
#5 /srv/mediawiki/php-1.35.0-wmf.10/includes/Hooks.php(202): Hooks::callHook(string, array, array, NULL)
#6 /srv/mediawiki/php-1.35.0-wmf.10/includes/actions/InfoAction.php(127): Hooks::run(string, array)
#7 /srv/mediawiki/php-1.35.0-wmf.10/includes/actions/FormlessAction.php(43): InfoAction->onView()
#8 /srv/mediawiki/php-1.35.0-wmf.10/includes/MediaWiki.php(514): FormlessAction->show()
#9 /srv/mediawiki/php-1.35.0-wmf.10/includes/MediaWiki.php(304): MediaWiki->performAction(CategoryTreeCategoryPage, Title)
#10 /srv/mediawiki/php-1.35.0-wmf.10/includes/MediaWiki.php(967): MediaWiki->performRequest()
#11 /srv/mediawiki/php-1.35.0-wmf.10/includes/MediaWiki.php(530): MediaWiki->main()
#12 /srv/mediawiki/php-1.35.0-wmf.10/index.php(46): MediaWiki->run()
#13 /srv/mediawiki/w/index.php(3): require(string)
#14 {main}

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 11 2019, 12:51 AM
Jdforrester-WMF triaged this task as Unbreak Now! priority.Dec 11 2019, 12:51 AM
Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptDec 11 2019, 12:51 AM
Addshore added a subscriber: Addshore.
Addshore assigned this task to Michael.Dec 11 2019, 10:59 AM
Restricted Application added a project: User-Michael. · View Herald TranscriptDec 11 2019, 10:59 AM

It was indeed an issue with https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/550494/ and an array_merge there.

This merge tries to the use behaviour described below:

If the input arrays have the same string keys, then the later value for that key will overwrite the previous one. If, however, the arrays contain numeric keys, the later value will not overwrite the original value, but will be appended.

however the things being merged have int keys, and the result just ends up broken.

and the tests use $title->resetArticleID( 1 ); so they didn't notice the error

Change 556347 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] Fix idlookup dropping pageids

https://gerrit.wikimedia.org/r/556347

Addshore reassigned this task from Michael to Ladsgroup.Dec 11 2019, 11:26 AM

Amir will backport this one

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptDec 11 2019, 11:26 AM

Doing it as we speak

Macro scap-book:

Change 556353 had a related patch set uploaded (by Ladsgroup; owner: Michael Große):
[mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.10] Fix idlookup dropping pageids

https://gerrit.wikimedia.org/r/556353

Change 556347 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix idlookup dropping pageids

https://gerrit.wikimedia.org/r/556347

Change 556353 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.10] Fix idlookup dropping pageids

https://gerrit.wikimedia.org/r/556353

Mentioned in SAL (#wikimedia-operations) [2019-12-11T12:03:46Z] <ladsgroup@deploy1001> Synchronized php-1.35.0-wmf.10/extensions/Wikibase/data-access: [[gerrit:556353|Fix idlookup dropping pageids (T236691 T240410)]] (duration: 01m 03s)

Some shiny graphs: