Page MenuHomePhabricator
Create Task
Maniphest T241293

VE - Cite should verify required parameters similar to template
Open, Needs TriagePublic
Actions

Description

Checking for required parameters is done in TemplateDialog but not for citations.
Suggestion to invoke checkRequiredParameters (ve.ui.MWTemplateDialog.prototype.checkRequiredParameters) or something similar when adding citation.

How to reproduce

  1. In enwiki open VE, in toolbar select Insert => Template => "Cite-web"
  2. Enter URL (for example: https://www.israelhayom.co.il/article/713227 ) and DONT fill title
  3. Press Insert and expect "Are you sure you want to continue without filling the "Title" field?"
  4. in toolbar select Cite and enter the same URL (or URL for which Zotero fail to extract title)
  5. Expect similar prompt as appeared in 3.

Related Objects

Event Timeline

eranroz created this task.Dec 21 2019, 8:13 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 21 2019, 8:13 AM
eranroz added a subscriber: Kipod.Dec 21 2019, 8:14 AM
Izno added a project: Cite.Dec 21 2019, 3:55 PM
Izno moved this task from Unsorted backlog to External on the Cite board.
IKhitron subscribed.Dec 22 2019, 1:05 PM
matmarex subscribed.Jan 4 2020, 12:37 PM

Note that the checking is done for manual citations (Cite → Manual → Website, etc.); it is only not done for automatic (Citoid) citations.

image.png (2×3 px, 1 MB)

I don't see how this would work for automatic citations. There is no step in which you can edit the citation before you insert it, so the only option provided by that dialog would be to completely cancel inserting the citation, which seems unhelpful to me. And in this workflow the user has never even seen the "Title" field, which the message would refer to.

image.png (2×3 px, 2 MB)

I don't think we should change this behavior.

eranroz added a comment.Jan 4 2020, 1:05 PM

Maybe we can switch to manual insertion if we encounter issue?
(Keep in mind that "Missing or empty title=" isn't part of VE but of specific implementation of Cite web in enwiki)

Izno subscribed.EditedJan 4 2020, 4:16 PM
In T241293#5775089, @matmarex wrote:

I don't see how this would work for automatic citations. There is no step in which you can edit the citation before you insert it [snip]

That would be T174585: Reconsider offering an "edit" button for automatic citations, in NWE

Amire80 mentioned this in T252938: citoid/zotero creates citations without title for makorrishon.co.il, israelhayom.co.il, and news.walla.co.il.May 16 2020, 10:41 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL