| AnneT | |
| Jan 13 2020, 3:47 PM |
| F31699601: Screen Shot 2020-03-23 at 5.44.25 PM.png | |
| Mar 24 2020, 2:41 AM |
| F31532547: ezgif.com-video-to-gif.gif | |
| Jan 24 2020, 7:28 PM |
| F31512546: Screen Shot 2020-01-14 at 3.36.28 PM.png | |
| Jan 14 2020, 8:49 PM |
| F31512534: Screen Shot 2020-01-14 at 2.47.05 PM.png | |
| Jan 14 2020, 8:49 PM |
| F31510832: Screen Shot 2020-01-13 at 10.43.01 AM.png | |
| Jan 13 2020, 3:47 PM |
Steps to Reproduce:
Actual Results:
All text and number inputs are in LTR mode, including the autocomplete widget to select a property:
Expected Results:
All inputs should be in RTL mode.
| AC | Status | Details |
|---|---|---|
| 1 | ❌ | T242627#5830347 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • Ramsey-WMF | T221109 Inconsistent handling of RTL languages in Structured Data UI elements | |||
| Resolved | BUG REPORT | Etonkovidova | T242627 Qualifier text and number inputs are in LTR mode when UI is set to RTL mode |
Change 564774 had a related patch set uploaded (by Anne Tomasevich; owner: Anne Tomasevich):
[mediawiki/extensions/WikibaseMediaInfo@master] Override core CSS so qualifier inputs use UI language direction
This was easily fixed with a line of CSS that's also used for statement widget inputs. I noticed that, on my local site which doesn't have a Hebrew translation of "official website", the qualifier property text appears in English but aligned to the right. This seems to mirror Wikidata's UI, which only changes the language direction in the case of monolingual text.
From my local Commons instance:
From wikidata (title is monolingual text, reference source is not):
We'll need to make sure to use language-specific direction for monolingual text values for top-level statements and qualifiers as part of T231996.
Change 564774 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Override core CSS so qualifier inputs use UI language direction
Status: ❌ FAIL
OS: macOS Catalina
Browser: Chrome
Device: MBP
Test Artifact(s):
View a file with structured data with your UI set to a RTL language (e.g. https://commons.wikimedia.org/wiki/File:Malibu-superbloom.jpg?uselang=he)
Edit a statement that has qualifiers, or try adding a new qualifier and observe the text direction
Actual Results:
❌ AC1: All text and number inputs should be in RTL mode.
The first statement input field is in LTR. Subsequent inputs are in RTL.
Thanks @Edtadros – after discussing with Ramsey I'm going to open a separate task to fix the statement input widget direction.
Checked in production - wmf.24. Generally looks fine - see the screenshot below:
The problem is with entering negative numbers (there might be instances when +is entered or another qualifier for numbers that should follow weak directionality). It filed as T248368: Structured Data on Commons: RTL support for negative numbers.