Page MenuHomePhabricator
Create Task
Maniphest T248422

[regression wmf.25] Mentorship module shows guidance root screen
Closed, ResolvedPublicBUG REPORT
Actions

Description

Based on T244546: Newcomer tasks: guidance root screen -the guidance root screen should appear only for the Help panel. Presently, testwiki (wmf.25) shows it for Mentorship module.

The issue is reproducible in betalabs also.

Steps to Reproduce:

  1. On testwiki (wmf.25) go to Special:Homepage. Click on 'Ask your mentor a question'.
  2. The dialog box opens with buttons to direct a user to a Help desk and to Help links, instead of a mentor User talk page.

After clicking on 'Ask your mentor a question'

Screen Shot 2020-03-24 at 2.12.24 PM.png (543×1 px, 104 KB)

Expected Results:
Clicking on 'Ask your mentor a question' should present a dialog from where a question can be posted on a mentor talk page.

Screen Shot 2020-03-24 at 2.13.00 PM.png (493×939 px, 119 KB)

Details

SubjectRepoBranchLines +/-
Mentorship module: Update for root screen refactormediawiki/extensions/GrowthExperimentswmf/1.35.0-wmf.25+17 -36
Mentorship module: Update for root screen refactormediawiki/extensions/GrowthExperimentsmaster+17 -36
Revert "Help panel: Add root screen buttons"mediawiki/extensions/GrowthExperimentsmaster+122 -248
Revert "Help panel: Fix panel title for ask-help"mediawiki/extensions/GrowthExperimentsmaster+1 -1
Revert "Help panel: Add some padding between button title and subheader"mediawiki/extensions/GrowthExperimentsmaster+0 -1
Revert "Help panel: On mobile, use 'previous' icon for non-home panels"mediawiki/extensions/GrowthExperimentsmaster+2 -10
Revert "Help panel: Add suggested edit button"mediawiki/extensions/GrowthExperimentsmaster+9 -91
Customize query in gerrit

Related Objects
Search...

Event Timeline

Etonkovidova created this task.Mar 24 2020, 9:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 24 2020, 9:17 PM
MMiller_WMF added a parent task: T244546: Newcomer tasks: guidance root screen.Mar 24 2020, 9:25 PM
MMiller_WMF added a project: NewcomerTasks 1.2.
• Catrope edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Mar 24 2020, 9:55 PM
• Catrope claimed this task.Mar 24 2020, 9:58 PM
• Catrope moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
• Catrope subscribed.

This happened because rEGREb5316d1d36cd: Help panel: Add root screen buttons (for T244546: Newcomer tasks: guidance root screen) made significant changes to HelpPanelProcessDialog, without realizing that QuestionPosterDialog is a subclass of it. In other words, the mentorship dialog (and the other "ask a question" dialogs) are implemented as some modifications on top of the help panel, so changing the structure of the help panel broke them.

IMO it doesn't make sense for QuestionPosterDialog to inherit from HelpPanelProcessDialog, it probably makes more sense the other way around (or for both to inherit from a common base class). We can explore refactoring this, or we can make changes to QuestionPosterDialog to account for the restructuring in HelpPanelProcessDialog, but since neither of these things is easy I'm going to revert rEGREb5316d1d36cd: Help panel: Add root screen buttons and its followups for now.

gerritbot added a comment.Mar 24 2020, 9:58 PM

Change 583154 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] Revert "Help panel: Add suggested edit button"

https://gerrit.wikimedia.org/r/583154

gerritbot added a project: Patch-For-Review.Mar 24 2020, 9:58 PM

Change 583155 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] Revert "Help panel: On mobile, use 'previous' icon for non-home panels"

https://gerrit.wikimedia.org/r/583155

gerritbot added a comment.Mar 24 2020, 10:03 PM

Change 583158 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] Revert "Help panel: Fix panel title for ask-help"

https://gerrit.wikimedia.org/r/583158

gerritbot added a comment.Mar 24 2020, 10:03 PM

Change 583159 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] Revert "Help panel: Add some padding between button title and subheader"

https://gerrit.wikimedia.org/r/583159

gerritbot added a comment.Mar 24 2020, 10:05 PM

Change 583160 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] Revert "Help panel: Add root screen buttons"

https://gerrit.wikimedia.org/r/583160

kostajh claimed this task.Mar 25 2020, 8:03 AM

Claiming this one as I have a fix to avoid these reverts.

gerritbot added a comment.Mar 25 2020, 8:12 AM

Change 583288 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Mentorship module: Update for root screen refactor

https://gerrit.wikimedia.org/r/583288

kostajh moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Mar 25 2020, 10:06 AM
gerritbot added a comment.Mar 25 2020, 5:24 PM

Change 583288 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Mentorship module: Update for root screen refactor

https://gerrit.wikimedia.org/r/583288

gerritbot added a comment.Mar 25 2020, 5:28 PM

Change 583154 abandoned by Catrope:
Revert "Help panel: Add suggested edit button"

Reason:
Superseded by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/ /583288

https://gerrit.wikimedia.org/r/583154

gerritbot added a comment.Mar 25 2020, 5:28 PM

Change 583155 abandoned by Catrope:
Revert "Help panel: On mobile, use 'previous' icon for non-home panels"

Reason:
Superseded by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/ /583288

https://gerrit.wikimedia.org/r/583155

gerritbot added a comment.Mar 25 2020, 5:28 PM

Change 583159 abandoned by Catrope:
Revert "Help panel: Add some padding between button title and subheader"

Reason:
Superseded by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/ /583288

https://gerrit.wikimedia.org/r/583159

gerritbot added a comment.Mar 25 2020, 5:28 PM

Change 583158 abandoned by Catrope:
Revert "Help panel: Fix panel title for ask-help"

Reason:
Superseded by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/ /583288

https://gerrit.wikimedia.org/r/583158

gerritbot added a comment.Mar 25 2020, 5:28 PM

Change 583160 abandoned by Catrope:
Revert "Help panel: Add root screen buttons"

Reason:
Superseded by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/ /583288

https://gerrit.wikimedia.org/r/583160

gerritbot added a comment.Mar 25 2020, 5:28 PM

Change 583393 had a related patch set uploaded (by Gergő Tisza; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@wmf/1.35.0-wmf.25] Mentorship module: Update for root screen refactor

https://gerrit.wikimedia.org/r/583393

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.26; 2020-03-31).Mar 25 2020, 6:00 PM
gerritbot added a comment.Mar 25 2020, 6:04 PM

Change 583393 merged by Gergő Tisza:
[mediawiki/extensions/GrowthExperiments@wmf/1.35.0-wmf.25] Mentorship module: Update for root screen refactor

https://gerrit.wikimedia.org/r/583393

Maintenance_bot removed a project: Patch-For-Review.Mar 25 2020, 6:10 PM
Stashbot added a comment.Mar 25 2020, 6:13 PM

Mentioned in SAL (#wikimedia-operations) [2020-03-25T18:13:49Z] <tgr@deploy1001> Synchronized php-1.35.0-wmf.25/extensions/GrowthExperiments/modules/homepage/: SWAT: [[gerrit:583393|Mentorship module: Update for root screen refactor (T248422)]] (duration: 03m 23s)

Tgr moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Mar 25 2020, 6:25 PM
ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.25; 2020-03-24); removed MW-1.35-notes (1.35.0-wmf.26; 2020-03-31).Mar 25 2020, 7:00 PM
Jdforrester-WMF closed this task as Resolved.Mar 25 2020, 7:24 PM
Jdforrester-WMF triaged this task as Unbreak Now! priority.
Jdforrester-WMF added a parent task: T233873: 1.35.0-wmf.25 deployment blockers.
Etonkovidova added a comment.Mar 25 2020, 10:31 PM

Checked in betalabs and testwiki (wmf.25) - the Mentorship dialog is back to normal. Will do additional check in target wikis.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits