Page MenuHomePhabricator
Create Task
Maniphest T251398

Categories not shown when switched from source editor
Closed, ResolvedPublic
Actions

Description

Steps to reproduce

  1. Open any article on cswiki
  2. Click Editovat zdroj (Edit source)
  3. Switch to VisualEditor
  1. Open any article on cswiki
  2. Click Editovat (Edit)
  3. Compare

Expected behavior
Both results should look the same, there should be no difference between article directly opened in VE or switched from source editor.

Current behavior
When switched from source editor to VE, categories at the bottom of the page in VE are missing.

Configuration
reproduced in Firefox 75.0, but reported also for Chrome, IE and Safari: https://cs.wikipedia.org/wiki/Wikipedie:Pod_l%C3%ADpou_(technika)#Mizej%C3%ADc%C3%AD_kategorie

Details

SubjectRepoBranchLines +/-
Always rebuild category list from Parsoid data on surfaceReadymediawiki/extensions/VisualEditormaster+13 -6
Customize query in gerrit

Related Objects

Event Timeline

Dvorapa created this task.Apr 29 2020, 11:00 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 29 2020, 11:00 AM
Draceane awarded a token.Apr 29 2020, 11:17 AM
MrJaroslavik subscribed.Apr 29 2020, 11:20 AM
Dvorapa updated the task description. (Show Details)Apr 29 2020, 2:32 PM
Jan_Kepler subscribed.Apr 29 2020, 3:04 PM
Jan_Kepler added a comment.Apr 29 2020, 3:06 PM

It's not only on cs.wiki, I tested it on sk.wiki, pl.wiki and de.wiki.

Janbery subscribed.Jun 15 2020, 8:10 PM
JTannerWMF added a project: Editing-team (Q3 2019-2020 Kanban Board).Jun 16 2020, 3:40 PM
JTannerWMF moved this task from Needs Discussion / Investigation to Ready for Development on the Editing-team (Q3 2019-2020 Kanban Board) board.
JTannerWMF moved this task from To Triage to Triaged on the VisualEditor board.
MBinder_WMF edited projects, added Editing-team (Kanban Board); removed Editing-team (Q3 2019-2020 Kanban Board).Jul 9 2020, 4:53 PM
JTannerWMF moved this task from Incoming to Ready to Be Worked On on the Editing-team (Kanban Board) board.Jul 9 2020, 4:53 PM
DLynch claimed this task.Jul 13 2020, 6:57 PM
DLynch moved this task from Ready to Be Worked On to Doing on the Editing-team (Kanban Board) board.
gerritbot added a comment.Jul 13 2020, 7:19 PM

Change 612403 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] Always rebuild category list from Parsoid data on surfaceReady

https://gerrit.wikimedia.org/r/612403

gerritbot added a project: Patch-For-Review.Jul 13 2020, 7:19 PM
DLynch moved this task from Doing to Code Review on the Editing-team (Kanban Board) board.Jul 13 2020, 7:20 PM
matmarex subscribed.Jul 17 2020, 2:37 PM

This problem also occurs when you're using a single edit tab and open the editor from an &action=edit URL, and the patch also resolves that case.

matmarex mentioned this in T145268: Always show and update the category display at the end of the page when editing in VE.Jul 17 2020, 2:38 PM
gerritbot added a comment.Jul 17 2020, 4:01 PM

Change 612403 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Always rebuild category list from Parsoid data on surfaceReady

https://gerrit.wikimedia.org/r/612403

Maintenance_bot removed a project: Patch-For-Review.Jul 17 2020, 4:10 PM
matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Jul 17 2020, 4:12 PM
matmarex added a project: Editing QA.
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.1; 2020-07-21).Jul 17 2020, 5:00 PM
• Whatamidoing-WMF subscribed.Sep 23 2020, 9:54 PM

Will this solve the problem that User:Refiona describes at https://www.mediawiki.org/wiki/Topic:Vtf86rvpkhgl0jo0 ? First, only one category was visible; then, after putting all the categories in the correct order, none of them were visible in visual mode. That means that none of them could be removed from the visual editor.

ppelberg moved this task from Inbox to Low Priority on the Editing QA board.Oct 1 2020, 11:17 PM
matmarex added a comment.Oct 3 2020, 5:58 PM
In T251398#6489618, @Whatamidoing-WMF wrote:

Will this solve the problem that User:Refiona describes at https://www.mediawiki.org/wiki/Topic:Vtf86rvpkhgl0jo0 ? First, only one category was visible; then, after putting all the categories in the correct order, none of them were visible in visual mode. That means that none of them could be removed from the visual editor.

It was an unrelated problem, I replied in the topic on mediawiki.org.

Ryasmeen edited projects, added Verified; removed Editing QA.Oct 8 2020, 6:15 PM
matmarex moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Oct 9 2020, 3:49 PM
ppelberg closed this task as Resolved.Oct 16 2020, 12:49 AM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptOct 16 2020, 12:49 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL