| dbarratt | |
| May 7 2020, 1:11 AM |
| F31817506: timeline_divided.png | |
| May 14 2020, 9:25 AM |
Problem
Tasks like T252030 will introduce new dependencies to the row formatter that are not needed by the Timeline Pager. This will create a pass through dependency.
Solution
Flatten the dependency hierarchy be creating a factory for the row formatter.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T139810 RFC: Overhaul the CheckUser extension | |||
| Resolved | Niharika | T236225 [Epic] CheckUser 2.0 Improvements | |||
| Resolved | Niharika | T237595 CU 2.0: Timeline tab | |||
| Resolved | dmaza | T247641 CU 2.0: Add variant display to the Timeline result list | |||
| Declined | dmaza | T252033 Have user links follow the same behavior as in SpecialCheckUser | |||
| Declined | STran | T252667 Look up revisions for the Timeline in batch | |||
| Resolved | Tchanders | T252030 Display comments after checking that the user has the right permissions if the revision was suppressed | |||
| Resolved | Tchanders | T252695 Update Structured Discussions Implementation of SpecialCheckUserGetLinksFromRow to CheckUserGetLinksFromRow | |||
| Resolved | Tchanders | T252031 Make TimelineRowFormatter::getLinks do the same checks as it is currently done in SpecialCheckUser | |||
| Resolved | dmaza | T252089 Create a factory for the row formatter |
Change 594818 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[mediawiki/extensions/CheckUser@master] Create a factory for the Timeline Row Formatter
Change 594615 had a related patch set uploaded (by Dbarratt; owner: Dmaza):
[mediawiki/extensions/CheckUser@master] Add date grouping and future dependencies to TimelineRowFormatter
Change 594615 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Add date grouping and future dependencies to TimelineRowFormatter
Entries in the Timeline tab are now divided into days.
On my local vagrant, I tested that entries were put into the correct days by taking a sample of days and comparing the results to what was in the database.