Page MenuHomePhabricator

Create a factory for the row formatter
Closed, ResolvedPublic

Description

Problem
Tasks like T252030 will introduce new dependencies to the row formatter that are not needed by the Timeline Pager. This will create a pass through dependency.

Solution
Flatten the dependency hierarchy be creating a factory for the row formatter.

Event Timeline

dbarratt created this task.May 7 2020, 1:11 AM
Restricted Application added a subscriber: Aklapper. ยท View Herald TranscriptMay 7 2020, 1:11 AM

Change 594818 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[mediawiki/extensions/CheckUser@master] Create a factory for the Timeline Row Formatter

https://gerrit.wikimedia.org/r/594818

Change 594615 had a related patch set uploaded (by Dbarratt; owner: Dmaza):
[mediawiki/extensions/CheckUser@master] Add date grouping and future dependencies to TimelineRowFormatter

https://gerrit.wikimedia.org/r/594615

Change 594818 abandoned by Dbarratt:
Create a factory for the Timeline Row Formatter

https://gerrit.wikimedia.org/r/594818

Change 594615 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Add date grouping and future dependencies to TimelineRowFormatter

https://gerrit.wikimedia.org/r/594615

dom_walden added a subscriber: dom_walden.

Entries in the Timeline tab are now divided into days.

On my local vagrant, I tested that entries were put into the correct days by taking a sample of days and comparing the results to what was in the database.

Niharika closed this task as Resolved.May 18 2020, 10:35 PM