1.36.0-wmf.10 deployment blockers
Closed, ResolvedPublicRelease
Actions

Details

Backup Train Conductor: • mmodell
Release Version: 1.36.0-wmf.10
Release Date: Sep 21 2020, 12:00 AM

2020 week 39 1.36-wmf.10 Changes wmf/1.36.0-wmf.10

This MediaWiki Train Deployment is scheduled for the week of Monday, September 21st:

Monday September 21st	Tuesday, September 22nd	Wednesday, September 23rd	Thursday, September 24th	Friday
Backports only.	Branch `wmf.10` and deploy to Group 0 Wikis.	Deploy `wmf.10` to Group 1 Wikis.	Deploy `wmf.10` to all Wikis.	No deployments on fridays

See https://wikitech.wikimedia.org/wiki/Deployments for full schedule.

How this works

Any serious bugs affecting wmf.10 should be added as subtasks beneath this one.
- Use this form to create one.
Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
If you have a risky change in this week's train add a comment to this task using the Risky patch template
For more info about deployment blockers, see Holding the train.

Other Deployments

Previous: 1.36.0-wmf.9

Next: 1.36.0-wmf.11

	Subject	Repo	Branch	Lines +/-
	Branch commit for wmf/1.36.0-wmf.10	mediawiki/core	wmf/1.36.0-wmf.10	+966 -3

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	dancy	T257978 1.36.0-wmf.10 deployment blockers
		Resolved		Urbanecm	T263750 abuse filter matching global_user_groups doesn't work any more

Event Timeline

• mmodell created this task.Jul 14 2020, 8:19 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 14 2020, 8:19 PM

thcipriani assigned this task to brennen.Aug 11 2020, 10:14 PM

thcipriani triaged this task as Medium priority.

thcipriani updated Other Assignee, added: dancy.

thcipriani added a project: Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)).

thcipriani moved this task from INBOX to Deployment on the Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)) board.

brennen added a project: User-brennen.Sep 8 2020, 4:24 PM

hashar subscribed.Sep 8 2020, 7:14 PM

brennen moved this task from Backlog to Next on the User-brennen board.Sep 9 2020, 7:16 PM

Jdforrester-WMF added a subtask: T263014: Argument 2 passed to File::userCan() must be an instance of User, null given, called in /srv/mediawiki/php-1.36.0-wmf.9/includes/filerepo/LocalRepo.php on line 275.Sep 16 2020, 10:52 AM

thcipriani reassigned this task from brennen to dancy.Sep 17 2020, 7:15 PM

thcipriani updated Other Assignee, added: • mmodell; removed: dancy.

thcipriani added a subscriber: brennen.

DannyS712 closed subtask T263014: Argument 2 passed to File::userCan() must be an instance of User, null given, called in /srv/mediawiki/php-1.36.0-wmf.9/includes/filerepo/LocalRepo.php on line 275 as Resolved.Sep 20 2020, 8:47 PM

Reedy mentioned this in T256171: Unescaped message used in HTML within LogEventsList (CVE-2020-25815).Sep 21 2020, 11:01 PM

Change 628979 had a related patch set uploaded (by DannyS712; owner: trainbranchbot):
[mediawiki/core@wmf/1.36.0-wmf.10] Branch commit for wmf/1.36.0-wmf.10

https://gerrit.wikimedia.org/r/628979

gerritbot added a project: Patch-For-Review.Sep 22 2020, 2:08 AM

Change 628979 merged by jenkins-bot:
[mediawiki/core@wmf/1.36.0-wmf.10] Branch commit for wmf/1.36.0-wmf.10

https://gerrit.wikimedia.org/r/628979

• mmodell added a subtask: T263592: Use of Language::commafy with a non-numeric string was deprecated in MediaWiki 1.36. [Called from Language::formatNum].Sep 22 2020, 9:02 PM

• mmodell added a subtask: T263601: ApiQueryGlobalUsage.php Undefined index error when accessing $pageIds.Sep 23 2020, 12:37 PM

Jdforrester-WMF added a subtask: T263642: TypeError when visiting Special:Unblock with no subpage.Sep 23 2020, 2:27 PM

Urbanecm closed subtask T263642: TypeError when visiting Special:Unblock with no subpage as Resolved.Sep 23 2020, 3:58 PM

thcipriani added a subtask: T263675: Undefined class constant 'LIMIT'.Sep 23 2020, 6:18 PM

dancy removed a subtask: T263014: Argument 2 passed to File::userCan() must be an instance of User, null given, called in /srv/mediawiki/php-1.36.0-wmf.9/includes/filerepo/LocalRepo.php on line 275.Sep 23 2020, 11:27 PM

dancy removed subtasks: T263675: Undefined class constant 'LIMIT', T263642: TypeError when visiting Special:Unblock with no subpage, T263601: ApiQueryGlobalUsage.php Undefined index error when accessing $pageIds, T263592: Use of Language::commafy with a non-numeric string was deprecated in MediaWiki 1.36. [Called from Language::formatNum].Sep 23 2020, 11:30 PM

@dancy can I ask why you removed the blocker subtasks instead of resolving them? If T263014: Argument 2 passed to File::userCan() must be an instance of User, null given, called in /srv/mediawiki/php-1.36.0-wmf.9/includes/filerepo/LocalRepo.php on line 275, T263675: Undefined class constant 'LIMIT', and T263601: ApiQueryGlobalUsage.php Undefined index error when accessing $pageIds are no longer blocking the train, they can be closed, but should stay associated with this ticket

Hi @DannyS712. @thcipriani instructed me to remove the non-blocking tasks from the subtasks list. An empty subtasks lists is the indication that there are no outstanding train blockers. Hope that helps!

In T257978#6490003, @dancy wrote:

Hi @DannyS712. @thcipriani instructed me to remove the non-blocking tasks from the subtasks list. An empty subtasks lists is the indication that there are no outstanding train blockers. Hope that helps!

Normally if the tasks are resolved / can be closed they are left associated with the blocker task, eg last week (T257977: 1.36.0-wmf.9 deployment blockers)

In T257978#6490003, @dancy wrote:

Hi @DannyS712. @thcipriani instructed me to remove the non-blocking tasks from the subtasks list. An empty subtasks lists is the indication that there are no outstanding train blockers. Hope that helps!

I don't think we've ever had a solid policy and is mostly up to the train conductors discretion -- if the whole problem is resolved, we usually close the task, but leave it attached to the train. If there's any reason to leave the ticket open (incomplete fix, revert for unblocking train, fix in master is different for fix in train, etc), then we usually remove the subtask.

It's a useful heuristic to say that a train with open subtasks can't roll forward.

In T257978#6490021, @thcipriani wrote:

In T257978#6490003, @dancy wrote:

Hi @DannyS712. @thcipriani instructed me to remove the non-blocking tasks from the subtasks list. An empty subtasks lists is the indication that there are no outstanding train blockers. Hope that helps!

I don't think we've ever had a solid policy and is mostly up to the train conductors discretion -- if the whole problem is resolved, we usually close the task, but leave it attached to the train. If there's any reason to leave the ticket open (incomplete fix, revert for unblocking train, fix in master is different for fix in train, etc), then we usually remove the subtask.

It's a useful heuristic to say that a train with open subtasks can't roll forward.

Okay, good to know. I was just wondering

FYI: I filled T263749, but not sure if it is caused by wmf.10.

Urbanecm added a subtask: T263750: abuse filter matching global_user_groups doesn't work any more.Sep 24 2020, 2:32 PM

Urbanecm closed subtask T263750: abuse filter matching global_user_groups doesn't work any more as Resolved.Sep 24 2020, 4:04 PM

Change 630929 had a related patch set uploaded (by 20after4; owner: 20after4):
[operations/mediawiki-config@master] testwikis wikis to 1.36.0-wmf.11 refs T257978

https://gerrit.wikimedia.org/r/630929

Change 630929 merged by jenkins-bot:
[operations/mediawiki-config@master] testwikis wikis to 1.36.0-wmf.11 refs T257978

https://gerrit.wikimedia.org/r/630929

wmf.10 is everywhere now, and wmf.11 is being rolled out to testwikis right now.

brennen moved this task from Next to Done or Declined on the User-brennen board.Mar 11 2021, 7:10 PM

1.36.0-wmf.10 deployment blockersClosed, ResolvedPublicReleaseActions