Page MenuHomePhabricator
Create Task
Maniphest T258184

Call to undefined method Wikibase\Client\Hooks\OtherProjectsSidebarGenerator::buildProjectLinkSidebarFromItemId()
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

MediaWiki version: 1.35.0-wmf.41

message
Call to undefined method Wikibase\Client\Hooks\OtherProjectsSidebarGenerator::buildProjectLinkSidebarFromItemId()

Impact

37 events in the past hour. ArticlePlaceholder not available.

Notes

Remaining AC:

  • see if the restored method that is now unused can/should be moved to ArticlePlaceholder
  • create an phpunit integration test that covers the special page actually rendering an item

Details

Request ID
6c35d025-2d41-482a-b8ba-275e056cd5fc
Request URL
https://nn.wikipedia.org/wiki/Spesial:AboutTopic/Q17391659
Stack Trace
exception.trace
#0 /srv/mediawiki/php-1.35.0-wmf.41/extensions/ArticlePlaceholder/includes/AboutTopicRenderer.php(128): ArticlePlaceholder\AboutTopicRenderer->setOtherProjectsLinks(Wikibase\DataModel\Entity\ItemId, OutputPage)
#1 /srv/mediawiki/php-1.35.0-wmf.41/extensions/ArticlePlaceholder/includes/Specials/SpecialAboutTopic.php(173): ArticlePlaceholder\AboutTopicRenderer->showPlaceholder(Wikibase\DataModel\Entity\ItemId, Language, User, OutputPage)
#2 /srv/mediawiki/php-1.35.0-wmf.41/extensions/ArticlePlaceholder/includes/Specials/SpecialAboutTopic.php(131): ArticlePlaceholder\Specials\SpecialAboutTopic->showContent(string)
#3 /srv/mediawiki/php-1.35.0-wmf.41/includes/specialpage/SpecialPage.php(600): ArticlePlaceholder\Specials\SpecialAboutTopic->execute(string)
#4 /srv/mediawiki/php-1.35.0-wmf.41/includes/specialpage/SpecialPageFactory.php(635): SpecialPage->run(string)
#5 /srv/mediawiki/php-1.35.0-wmf.41/includes/MediaWiki.php(307): MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext)
#6 /srv/mediawiki/php-1.35.0-wmf.41/includes/MediaWiki.php(940): MediaWiki->performRequest()
#7 /srv/mediawiki/php-1.35.0-wmf.41/includes/MediaWiki.php(543): MediaWiki->main()
#8 /srv/mediawiki/php-1.35.0-wmf.41/index.php(53): MediaWiki->run()
#9 /srv/mediawiki/php-1.35.0-wmf.41/index.php(46): wfIndexMain()
#10 /srv/mediawiki/w/index.php(3): require(string)
#11 {main}
SubjectRepoBranchLines +/-
Re add OtherProjectsSidebarGenerator::buildProjectLinkSidebarFromItemIdmediawiki/extensions/WikibaseREL1_35+14 -0
Add test for buildProjectLinkSidebarFromItemIdmediawiki/extensions/Wikibasemaster+29 -5
Add integration test for buildProjectLinkSidebarFromItemIdmediawiki/extensions/ArticlePlaceholdermaster+152 -0
Revert "Removes OtherProjectsSidebar hook"mediawiki/extensions/Wikibasemaster+377 -4
Re add OtherProjectsSidebarGenerator::buildProjectLinkSidebarFromItemIdmediawiki/extensions/Wikibasemaster+14 -0
Re add OtherProjectsSidebarGenerator::buildProjectLinkSidebarFromItemIdmediawiki/extensions/Wikibasewmf/1.35.0-wmf.41+14 -0
Revert "Revert "Removes OtherProjectsSidebar hook""mediawiki/extensions/Wikibasewmf/1.35.0-wmf.41+3 -374
Revert "Removes OtherProjectsSidebar hook"mediawiki/extensions/Wikibasewmf/1.35.0-wmf.41+375 -4
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Jul 16 2020, 3:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 16 2020, 3:00 PM
Addshore subscribed.Jul 16 2020, 3:01 PM
Lucas_Werkmeister_WMDE added a subscriber: Tpt.Jul 16 2020, 3:02 PM

OtherProjectsSidebarGenerator::buildProjectLinkSidebarFromItemId() was removed by @Tpt in I2175ba536d – “This hook is not used anymore”. It seems that’s not quite true.

Addshore added a comment.Jul 16 2020, 3:02 PM

Broken by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/608219

Ladsgroup subscribed.Jul 16 2020, 3:04 PM
Lucas_Werkmeister_WMDE claimed this task.Jul 16 2020, 3:04 PM

Apparently the hook is supposed to be replaced by WikibaseClientSiteLinksForItem in other extensions, and WikimediaBadges was updated, but ArticlePlaceholder wasn’t. I think for wmf.41 we can just revert that commit, and then worry about updating ArticlePlaceholder later (I’m not sure how much work it would be).

Ladsgroup added a subscriber: Lydia_Pintscher.Jul 16 2020, 3:05 PM
gerritbot added a comment.Jul 16 2020, 3:05 PM

Change 613168 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Revert "Removes OtherProjectsSidebar hook"

https://gerrit.wikimedia.org/r/613168

gerritbot added a project: Patch-For-Review.Jul 16 2020, 3:05 PM

Change 613170 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.41] Revert "Removes OtherProjectsSidebar hook"

https://gerrit.wikimedia.org/r/613170

gerritbot added a comment.Jul 16 2020, 3:15 PM

Change 613188 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] Readd OtherProjectsSidebarGenerator::buildProjectLinkSidebarFromItemId

https://gerrit.wikimedia.org/r/613188

gerritbot added a comment.Jul 16 2020, 3:36 PM

Change 613170 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.41] Revert "Removes OtherProjectsSidebar hook"

https://gerrit.wikimedia.org/r/613170

Stashbot added a comment.Jul 16 2020, 3:51 PM

Mentioned in SAL (#wikimedia-operations) [2020-07-16T15:51:10Z] <lucaswerkmeister-wmde@deploy1001> Synchronized php-1.35.0-wmf.41/extensions/Wikibase/: Backport: [[gerrit:613170|Revert "Revert "Removes OtherProjectsSidebar hook"" (T258184)]] (duration: 01m 02s)

gerritbot added a comment.Jul 16 2020, 3:54 PM

Change 613194 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.41] Revert "Revert "Removes OtherProjectsSidebar hook""

https://gerrit.wikimedia.org/r/613194

gerritbot added a comment.Jul 16 2020, 3:55 PM

Change 613194 merged by Lucas Werkmeister (WMDE):
[mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.41] Revert "Revert "Removes OtherProjectsSidebar hook""

https://gerrit.wikimedia.org/r/613194

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.41; 2020-07-14).Jul 16 2020, 4:00 PM
Lucas_Werkmeister_WMDE added a comment.Jul 16 2020, 4:06 PM
In T258184#6312696, @gerritbot wrote:

Change 613170 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.41] Revert "Removes OtherProjectsSidebar hook"

https://gerrit.wikimedia.org/r/613170

Okay, so this one didn’t work, lots of logstash errors:

TypeError from line 52 of /srv/mediawiki/php-1.35.0-wmf.41/extensions/Wikibase/client/includes/Hooks/OtherProjectsSidebarGenerator.php: Argument 2 passed to Wikibase\Client\Hooks\OtherProjectsSidebarGenerator::__construct() must be an instance of Wikibase\Client\Hooks\SiteLinksForDisplayLookup, instance of Wikibase\Lib\Store\CachingSiteLinkLookup given

Let’s try this one instead:

In T258184#6312628, @gerritbot wrote:

Change 613188 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] Readd OtherProjectsSidebarGenerator::buildProjectLinkSidebarFromItemId

https://gerrit.wikimedia.org/r/613188

gerritbot added a comment.Jul 16 2020, 4:10 PM

Change 613173 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Addshore):
[mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.41] Re add OtherProjectsSidebarGenerator::buildProjectLinkSidebarFromItemId

https://gerrit.wikimedia.org/r/613173

gerritbot added a comment.Jul 16 2020, 4:33 PM

Change 613188 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Re add OtherProjectsSidebarGenerator::buildProjectLinkSidebarFromItemId

https://gerrit.wikimedia.org/r/613188

gerritbot added a comment.Jul 16 2020, 4:40 PM

Change 613173 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.41] Re add OtherProjectsSidebarGenerator::buildProjectLinkSidebarFromItemId

https://gerrit.wikimedia.org/r/613173

Stashbot added a comment.Jul 16 2020, 4:45 PM

Mentioned in SAL (#wikimedia-operations) [2020-07-16T16:45:06Z] <lucaswerkmeister-wmde@deploy1001> Synchronized php-1.35.0-wmf.41/extensions/Wikibase/: Backport: [[gerrit:613173|Re add OtherProjectsSidebarGenerator::buildProjectLinkSidebarFromItemId (T258184)]] (duration: 01m 02s)

Lucas_Werkmeister_WMDE added a comment.Jul 16 2020, 4:49 PM

Alright, that seems to have resolved the production error.

Leaving the task open in case ArticlePlaceholder should be ported to something else (I might look more into it tomorrow).

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.1; 2020-07-21).Jul 16 2020, 5:00 PM
Tpt added a comment.Jul 16 2020, 6:24 PM

@Lucas_Werkmeister_WMDE @Addshore Thank you very much for having handled this error and sorry for having introduced it. You are amazing!

gerritbot added a comment.Jul 16 2020, 7:07 PM

Change 613168 abandoned by Addshore:
[mediawiki/extensions/Wikibase@master] Revert "Removes OtherProjectsSidebar hook"

Reason:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/ /613188 is merged on master now

https://gerrit.wikimedia.org/r/613168

Addshore closed this task as Resolved.Jul 16 2020, 7:08 PM
In T258184#6313471, @Tpt wrote:

@Lucas_Werkmeister_WMDE @Addshore Thank you very much for having handled this error and sorry for having introduced it. You are amazing!

My bad for not spotting it in CR! :)

Addshore reopened this task as Open.Jul 16 2020, 7:09 PM
In T258184#6313066, @Lucas_Werkmeister_WMDE wrote:

Leaving the task open in case ArticlePlaceholder should be ported to something else (I might look more into it tomorrow).

Just saw this so reopening.
Might be nice to file another task to track that though.
And potentially introducing 1 new integration style test for the special page which would have caught this

Addshore moved this task from Incoming to Done on the ArticlePlaceholder board.Jul 16 2020, 7:10 PM
darthmon_wmde added a project: Wikidata-Campsite.Jul 20 2020, 9:13 AM
darthmon_wmde moved this task from Incoming to Prioritized Wikidata Tech Backlog (prioritised from top to bottom) on the Wikidata-Campsite board.
darthmon_wmde moved this task from Prioritized Wikidata Tech Backlog (prioritised from top to bottom) to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.Jul 20 2020, 11:00 AM
darthmon_wmde edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Jul 20 2020, 11:15 AM
Michael subscribed.Jul 21 2020, 1:15 PM
This comment was removed by Michael.
Michael updated the task description. (Show Details)Jul 21 2020, 1:15 PM
Krinkle moved this task from Untriaged to Jul 2020 on the Wikimedia-production-error board.Jul 22 2020, 6:54 PM
Krinkle removed a project: Patch-For-Review.
guergana.tzatchkova moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 4 2020, 9:40 AM
Michael updated the task description. (Show Details)Aug 4 2020, 9:46 AM
gerritbot added a comment.Aug 4 2020, 3:56 PM

Change 618337 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/ArticlePlaceholder@master] WIP: Add integration test for buildProjectLinkSidebarFromItemId

https://gerrit.wikimedia.org/r/618337

gerritbot added a project: Patch-For-Review.Aug 4 2020, 3:56 PM
gerritbot added a comment.Aug 5 2020, 10:59 AM

Change 618516 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] Add test for buildProjectLinkSidebarFromItemId

https://gerrit.wikimedia.org/r/618516

• Pablo-WMDE mentioned this in T259744: Argument 3 passed to CachingFallbackLabelDescriptionLookup::buildCacheKey() must be of the type string, null given.Aug 6 2020, 9:26 AM
• toan moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 7 2020, 12:32 PM
gerritbot added a comment.Aug 10 2020, 9:54 AM

Change 618337 merged by jenkins-bot:
[mediawiki/extensions/ArticlePlaceholder@master] Add integration test for buildProjectLinkSidebarFromItemId

https://gerrit.wikimedia.org/r/618337

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.4; 2020-08-11); removed MW-1.36-notes (1.36.0-wmf.1; 2020-07-21).Aug 10 2020, 10:00 AM
ItamarWMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 10 2020, 10:08 AM
gerritbot added a comment.Aug 11 2020, 11:06 AM

Change 618516 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add test for buildProjectLinkSidebarFromItemId

https://gerrit.wikimedia.org/r/618516

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.5; 2020-08-18); removed MW-1.36-notes (1.36.0-wmf.4; 2020-08-11).Aug 11 2020, 12:00 PM
Michael removed a project: Patch-For-Review.Aug 14 2020, 3:35 PM

As far as I can tell, all associated patches have been either merged or abandoned.

Lucas_Werkmeister_WMDE closed this task as Resolved.Aug 19 2020, 2:44 PM
Lucas_Werkmeister_WMDE moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

I think we can close this. The method is restored, its test is back, and we have an integration test in ArticlePlaceholder.

Lucas_Werkmeister_WMDE added a comment.Aug 19 2020, 2:45 PM
  • see if the restored method that is now unused can/should be moved to ArticlePlaceholder

Not trivially – it uses two private methods of OtherProjectsSidebarGenerator.

lucamauri subscribed.Nov 15 2020, 9:06 PM
In T258184#6396602, @Lucas_Werkmeister_WMDE wrote:

I think we can close this. The method is restored, its test is back, and we have an integration test in ArticlePlaceholder.

I don't think this problem is fixed.
In my own installation Ihave final MW 1.35 an the latest ArticlePlaceholder version, but I am getting the error right now:

Error from line 261 of /var/www/mw/wt/extensions/ArticlePlaceholder/includes/AboutTopicRenderer.php: Call to undefined method Wikibase\Client\Hooks\OtherProjectsSidebarGenerator::buildProjectLinkSidebarFromItemId()

Backtrace:

#0 /var/www/mw/wt/extensions/ArticlePlaceholder/includes/AboutTopicRenderer.php(128): ArticlePlaceholder\AboutTopicRenderer->setOtherProjectsLinks()
#1 /var/www/mw/wt/extensions/ArticlePlaceholder/includes/Specials/SpecialAboutTopic.php(170): ArticlePlaceholder\AboutTopicRenderer->showPlaceholder()
#2 /var/www/mw/wt/extensions/ArticlePlaceholder/includes/Specials/SpecialAboutTopic.php(131): ArticlePlaceholder\Specials\SpecialAboutTopic->showContent()
#3 /var/www/mw/wt/includes/specialpage/SpecialPage.php(600): ArticlePlaceholder\Specials\SpecialAboutTopic->execute()
#4 /var/www/mw/wt/includes/specialpage/SpecialPageFactory.php(635): SpecialPage->run()
#5 /var/www/mw/wt/includes/MediaWiki.php(307): MediaWiki\SpecialPage\SpecialPageFactory->executePath()
#6 /var/www/mw/wt/includes/MediaWiki.php(940): MediaWiki->performRequest()
#7 /var/www/mw/wt/includes/MediaWiki.php(543): MediaWiki->main()
#8 /var/www/mw/wt/index.php(53): MediaWiki->run()
#9 /var/www/mw/wt/index.php(46): wfIndexMain()
#10 {main}
Addshore added a comment.Nov 16 2020, 8:29 AM

final MW 1.35 an the latest ArticlePlaceholder version

You need 1.35 of mediawiki, wikibase and ArticlePlaceholder.
It's likely that having latest of ArticlePlaceholder and 1.35 of everything else is causing your issue.

gerritbot added a comment.May 24 2021, 8:06 PM

Change 693658 had a related patch set uploaded (by Reedy; author: Addshore):

[mediawiki/extensions/Wikibase@REL1_35] Re add OtherProjectsSidebarGenerator::buildProjectLinkSidebarFromItemId

https://gerrit.wikimedia.org/r/693658

gerritbot added a project: Patch-For-Review.May 24 2021, 8:06 PM
gerritbot added a comment.May 24 2021, 8:26 PM

Change 693658 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@REL1_35] Re add OtherProjectsSidebarGenerator::buildProjectLinkSidebarFromItemId

https://gerrit.wikimedia.org/r/693658

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL