Page MenuHomePhabricator
Create Task
Maniphest T259154

Uncaught Error: Offset lies inside child of strange size
Closed, ResolvedPublic
Actions

Description

https://logstash.wikimedia.org/app/kibana#/context/logstash-*/clienterror/AXOa0c4iNoG2jwpwBI3q?_a=h@2d4bdf1&_g=h@1251ff0

Uncaught Error: Offset lies inside child of strange size
at VeCeDocument.ve.ce.Document.getNodeAndOffset  URL1:368:583
at VeCeSurface.ve.ce.Surface.annotationsAtModelSelection  URL1:496:215
at VeCeSurface.ve.ce.Surface.onDocumentMouseDown  URL1:436:739
at HTMLDivElement.dispatch  URL2:124:742
at HTMLDivElement.elemData.handle  URL2:121:388

URL1: https://ca.wikipedia.org/w/load.php?lang=ca&modules=ext.visualEditor.core%2Cmediawiki&skin=vector&version=1aqte
URL2: https://ca.wikipedia.org/w/load.php?lang=ca&modules=ext.eventLogging%2CwikimediaEvents%7Cext.uls.common%2Ccompactlinks%2Cinterface%7Cjquery%2Coojs-ui-core%2Coojs-ui-widgets%7Cjquery.tablesorter.styles%7Cjquery.uls.data%7Cmediawiki.base%2Cwidgets%7Cmediawiki.ui.button%7Cmw.cx.init.Translation%7Cmw.cx.tools.IssueTrackingTool%7Cmw.cx.ui.Categories%2CHeader%2CInfobar%2CPageTitleWidget%2CTranslationToolWidget%2CTranslationView%7Coojs-ui-core.icons%7Coojs-ui-toolbars.icons%7Coojs-ui-widgets.icons%7Coojs-ui-windows.icons%7Coojs-ui.styles.icons-accessibility%2Cicons-content%2Cicons-editing-advanced%2Cicons-editing-core%2Cicons-interactions%2Cicons-user%2Cicons-wikimedia%2Cindicators%7Cve.ui.CXDesktopContext&skin=vector&version=1ymci

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (8b37f95f1)mediawiki/extensions/VisualEditormaster+1 -1
Catch errors from getNodeAndOffset in ve.ce.Surface#focusVisualEditor/VisualEditormaster+10 -3
Update VE core submodule to master (53af216aa)mediawiki/extensions/VisualEditormaster+23 -15
Catch errors from getNodeAndOffset in annotationsAtModelSelectionVisualEditor/VisualEditormaster+14 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Jul 29 2020, 4:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 29 2020, 4:40 PM
Arrbee moved this task from Needs Triage to Check & Move on the ContentTranslation board.Aug 17 2020, 12:11 PM
Krinkle moved this task from Untriaged to Aug 2020 on the Wikimedia-production-error board.Aug 26 2020, 7:03 PM
ppelberg subscribed.Aug 27 2020, 4:20 PM

The Editing Team is assuming that the Language Team will look into this. If we've assumed incorrectly, please let us know.

ppelberg moved this task from To Triage to Triaged on the VisualEditor board.Aug 27 2020, 4:20 PM
Esanders updated the task description. (Show Details)Sep 11 2020, 12:01 PM
gerritbot added a comment.Sep 17 2020, 12:03 PM

Change 628076 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Catch errors from getNodeAndOffset in annotationsAtModelSelection

https://gerrit.wikimedia.org/r/628076

gerritbot added a project: Patch-For-Review.Sep 17 2020, 12:03 PM
Esanders subscribed.Sep 17 2020, 12:14 PM

I'm going to fix this group of tasks with a try/catch in annotationsAtModelSelection, so no further action needed.

gerritbot added a comment.Sep 17 2020, 12:14 PM

Change 628076 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Catch errors from getNodeAndOffset in annotationsAtModelSelection

https://gerrit.wikimedia.org/r/628076

gerritbot added a comment.Sep 17 2020, 12:21 PM

Change 628077 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (53af216aa)

https://gerrit.wikimedia.org/r/628077

gerritbot added a comment.Sep 17 2020, 6:20 PM

Change 628077 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (53af216aa)

https://gerrit.wikimedia.org/r/628077

Maintenance_bot removed a project: Patch-For-Review.Sep 17 2020, 7:11 PM
matmarex added a project: Editing-team (Kanban Board).Sep 17 2020, 7:22 PM
matmarex moved this task from Incoming to Blocked / Needs More Work on the Editing-team (Kanban Board) board.Sep 17 2020, 7:24 PM
matmarex subscribed.

Instead of QA, we should check the logs to confirm this error has disappeared after the patches are deployed.

Nikerabbit subscribed.Sep 28 2020, 2:47 PM

This seems to be still happening :/

matmarex moved this task from Blocked / Needs More Work to Ready to Be Worked On on the Editing-team (Kanban Board) board.Oct 2 2020, 2:35 AM

Indeed, still happening: https://logstash.wikimedia.org/goto/eb49328ae40cd98228c251f5e4c27600

image.png (405×2 px, 45 KB)

ppelberg added a parent task: T264487: Confirm client-side errors are no longer occurring .Oct 3 2020, 1:42 AM
Umherirrender added a project: JavaScript.Oct 5 2020, 5:03 PM
JTannerWMF removed projects: JavaScript, Editing-team (Kanban Board), Wikimedia-production-error, ContentTranslation, VisualEditor.Oct 14 2020, 3:09 PM
JTannerWMF added projects: VisualEditor, Wikimedia-production-error, JavaScript, Editing-team (Tracking).Oct 14 2020, 3:14 PM
matmarex edited projects, added Editing-team (Kanban Board), ContentTranslation; removed Editing-team (Tracking).Oct 14 2020, 3:32 PM
gerritbot added a comment.Nov 9 2020, 11:23 AM

Change 640091 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] Catch errors from getNodeAndOffset in ve.ce.Surface#focus

https://gerrit.wikimedia.org/r/640091

gerritbot added a project: Patch-For-Review.Nov 9 2020, 11:23 AM
matmarex moved this task from Ready to Be Worked On to Code Review on the Editing-team (Kanban Board) board.Nov 9 2020, 11:23 AM
• Rileych moved this task from Check & Move to Upstream/Other teams on the ContentTranslation board.Nov 9 2020, 3:22 PM
gerritbot added a comment.Nov 11 2020, 11:00 PM

Change 640091 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Catch errors from getNodeAndOffset in ve.ce.Surface#focus

https://gerrit.wikimedia.org/r/640091

Maintenance_bot removed a project: Patch-For-Review.Nov 11 2020, 11:10 PM
Esanders assigned this task to matmarex.Nov 14 2020, 2:36 PM
Esanders moved this task from Code Review to Ready for Sign Off on the Editing-team (Kanban Board) board.
Esanders added a project: Skipped QA.
gerritbot added a comment.Nov 16 2020, 10:27 PM

Change 641268 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (8b37f95f1)

https://gerrit.wikimedia.org/r/641268

gerritbot added a project: Patch-For-Review.Nov 16 2020, 10:27 PM
gerritbot added a comment.Nov 16 2020, 10:55 PM

Change 641268 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (8b37f95f1)

https://gerrit.wikimedia.org/r/641268

Maintenance_bot removed a project: Patch-For-Review.Nov 16 2020, 11:11 PM
ppelberg closed this task as Resolved.Nov 17 2020, 2:49 AM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptNov 17 2020, 2:49 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL