| • Prtksxna | |
| Aug 25 2020, 2:42 AM |
| F32269955: image.png | |
| Sep 11 2020, 12:19 PM |
| F32254448: portrait_to_landscape_expanded.png | |
| Sep 10 2020, 1:14 PM |
| F32254450: portrait_to_landscape_notexpanded.png | |
| Sep 10 2020, 1:14 PM |
| F32254443: empty_mobile_drawer.png | |
| Sep 10 2020, 1:14 PM |
| F32254457: scrolling_more_content.png | |
| Sep 10 2020, 1:14 PM |
| F32254445: empty_mobile_drawer_landscape.png | |
| Sep 10 2020, 1:14 PM |
| F32254453: landscape_to_portrait_expanded.png | |
| Sep 10 2020, 1:14 PM |
| F32254455: landscape_to_portrait_notexpanded.png | |
| Sep 10 2020, 1:14 PM |
Background
| Current design | F27057381 |
| Recent discussion | T259755 |
| Explorations | https://wikimedia.invisionapp.com/freehand/Block-Message-UI-options-mklLvnOcQ |
Design
 |  |
Acceptance criteria
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T190946 Epic: Improve the mobile block experiences | |||
| Resolved | None | T189717 Better handle block reasons on mobile (specifically templates and HTML comments) | |||
| Resolved | Tchanders | T261178 Block modal on mobile: Create designs that include full reason |
Yep, I think so. Let me know if you need any more details.
Actually scratch that, I might have some changes.
Change 624045 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/MobileFrontend@master] Redesign the mobile block message drawer to show long reasons
I was thinking the reason would already be visable and the "See More" would just scroll the user upward with something like this:
window.scroll({
top: 300, // Whatever the height of the space above the drawer is.
behavior: 'smooth' // Works in modern browsers, ignored in older ones (afaik)
});basically it would just smooth scroll the drawer to the top (or as high as it goes).
@Prtksxna What do you think? Do you like it exposing it on "See More" or should it scroll?
I don't think I understand the different between exposing and scrolling. Is what you're proposing different from what @Tchanders had demo'd during stand-up?
Right now, the only way to get to the reason is by clicking "See More", which pops the content into the drawer.
Originally I was thinking that tapping "See More" would scroll the viewport. In other words, the reason is there regardless if you tap "See More."
Change 624045 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Redesign the mobile block message drawer to show long reasons
@Tchanders For indefinite blocks, I don't see any value in the expiry field, just says Block will expire in :
Change 626199 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/MobileFrontend@master] Restore check for duration in BlockMessageDetails
@dom_walden The expiry field isn't supposed to show at all if the block is indefinite - that's a regression due to accidentally removing a check for the duration.
Should be fixed in the patch above.
Couple of questions/potential issues for @Tchanders @Prtksxna :
All the screenshots above are from iPhone 11, but I have reproduced all these issues with other devies (Android, Windows Phone). I have only been able to test on browserstack, though, not physical devices. Someone might want to confirm these issues on physical devices, as I don't have access to any.
Thanks @dom_walden - I can confirm all of these after testing on a real Android phone.
This is a regression - filed as T262662.
- I find weird behaviour when I change the orientation when the drawer is visible
It looks as though the block message drawer didn't support the landscape orientation before. E.g. here's how it appeared with a long reason (it's not scrollable):
@Prtksxna @Niharika Do we want to add support for the horizontal orientation?
- I find sometimes I can reveal more of the drawer's content when I scroll. Is this deliberate? Is this T261178#6439649?
This isn't deliberate - it's also not the suggestion from that comment (@Prtksxna will file that separately).
It's another regression, and looked even worse on Android/Chrome - filed as T262666.
Thanks @dom_walden - I can confirm all of these after testing on a real Android phone.
This is a regression - filed as T262662.
- I find weird behaviour when I change the orientation when the drawer is visible
It looks as though the block message drawer didn't support the landscape orientation before. E.g. here's how it appeared with a long reason (it's not scrollable):
@Prtksxna @Niharika Do we want to add support for the horizontal orientation?
I think we can not care about it. It's low priority for me.
Change 626199 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Restore check for duration in BlockMessageDetails
Thanks everyone for raising those bugs.
I don't think there is anything more to do here.
The bug with infinite expiries seems to be fixed.