Page MenuHomePhabricator

Discussion tools misplaces signature with lists
Closed, ResolvedPublic

Assigned To
Authored By
Urbanecm
Sep 18 2020, 1:09 AM
Referenced Files
F35484113: Screenshot 2022-08-22 at 16.30.26.png
Aug 22 2022, 3:33 PM
F35484111: Screenshot 2022-08-22 at 16.29.05.png
Aug 22 2022, 3:33 PM
F32354086: image.png
Sep 18 2020, 1:09 AM
Tokens
"Like" token, awarded by Izno."Like" token, awarded by Novem_Linguae."Like" token, awarded by Jack_who_built_the_house."Love" token, awarded by Iniquity.

Description

Today, I discovered that when I include a list in discussion tools' interface, the signature is placed at the end of the last item, instead of at a new line. See:

image.png (819×1 px, 91 KB)

Can we code that as an exception?

Event Timeline

In visual mode it actually behaves the way you want. I think we didn't do it for wikitext because we didn't want to get into wikitext parsing.

As a workaround, you can type ~~~~ yourself on a new line (on generally, wherever you want the signature to be), and the tool won't add an extra signature.

matmarex moved this task from Backlog to Triaged on the DiscussionTools board.

In visual mode it actually behaves the way you want. I think we didn't do it for wikitext because we didn't want to get into wikitext parsing.

I still don't like adding more logic that depends on wikitext parsing, but maybe at this point this is worth making an exception.

Change 820839 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Add signature on separate line if wikitext comment ends with a list

https://gerrit.wikimedia.org/r/820839

Change 820839 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Add signature on separate line if wikitext comment ends with a list

https://gerrit.wikimedia.org/r/820839

EAkinloose subscribed.

✅ Discussion tools places on a new line as expected

Screenshot 2022-08-22 at 16.29.05.png (626×2 px, 95 KB)

Screenshot 2022-08-22 at 16.30.26.png (528×2 px, 130 KB)