Page MenuHomePhabricator
Create Task
Maniphest T273006

MediumSpecificBagOStuff.php Undefined offset errors
Closed, ResolvedPublic
Actions

Description

A bunch of these showed up after deploying 1.36.0-wmf.28 to group0:

Sample url: www.mediawiki.org/w/load.php?lang=fr&modules=ext.echo.styles.badge%7Cext.uls.pt%7Cext.visualEditor.desktopArticleTarget.noscript%7Cext.wikimediaBadges%7Coojs-ui.styles.icons-alerts%7Cskins.vector.styles.legacy&only=styles&skin=vector

ErrorException: PHP Notice: Undefined offset: 1

The offset varies. Values between 1 and 6 were seen.

Stack Trace
from /srv/mediawiki/php-1.36.0-wmf.28/includes/libs/objectcache/MediumSpecificBagOStuff.php(1094)
#0 /srv/mediawiki/php-1.36.0-wmf.28/includes/libs/objectcache/MediumSpecificBagOStuff.php(1094): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.36.0-wmf.28/includes/libs/objectcache/RedisBagOStuff.php(282): MediumSpecificBagOStuff->updateOpStats(string, array, array)
#2 /srv/mediawiki/php-1.36.0-wmf.28/includes/libs/objectcache/MediumSpecificBagOStuff.php(617): RedisBagOStuff->doSetMulti(array, integer, integer)
#3 /srv/mediawiki/php-1.36.0-wmf.28/includes/resourceloader/dependencystore/KeyValueDependencyStore.php(84): MediumSpecificBagOStuff->setMulti(array, integer, integer)
#4 /srv/mediawiki/php-1.36.0-wmf.28/includes/resourceloader/ResourceLoader.php(613): Wikimedia\DependencyStore\KeyValueDependencyStore->storeMulti(string, array, integer)
#5 /srv/mediawiki/php-1.36.0-wmf.28/includes/deferred/MWCallableUpdate.php(38): ResourceLoader->{closure}()
#6 /srv/mediawiki/php-1.36.0-wmf.28/includes/deferred/DeferredUpdates.php(513): MWCallableUpdate->doUpdate()
#7 /srv/mediawiki/php-1.36.0-wmf.28/includes/deferred/DeferredUpdates.php(390): DeferredUpdates::attemptUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactoryMulti)
#8 /srv/mediawiki/php-1.36.0-wmf.28/includes/deferred/DeferredUpdates.php(221): DeferredUpdates::run(MWCallableUpdate, Wikimedia\Rdbms\LBFactoryMulti, Monolog\Logger, BufferingStatsdDataFactory, string)
#9 /srv/mediawiki/php-1.36.0-wmf.28/includes/deferred/DeferredUpdatesScope.php(267): DeferredUpdates::{closure}(MWCallableUpdate, integer)
#10 /srv/mediawiki/php-1.36.0-wmf.28/includes/deferred/DeferredUpdatesScope.php(196): DeferredUpdatesScope->processStageQueue(integer, integer, Closure)
#11 /srv/mediawiki/php-1.36.0-wmf.28/includes/deferred/DeferredUpdates.php(242): DeferredUpdatesScope->processUpdates(integer, Closure)
#12 /srv/mediawiki/php-1.36.0-wmf.28/includes/MediaWiki.php(1117): DeferredUpdates::doUpdates(string)
#13 /srv/mediawiki/php-1.36.0-wmf.28/includes/MediaWiki.php(853): MediaWiki->restInPeace()
#14 /srv/mediawiki/php-1.36.0-wmf.28/includes/MediaWiki.php(865): MediaWiki->{closure}()
#15 /srv/mediawiki/php-1.36.0-wmf.28/load.php(56): MediaWiki->doPostOutputShutdown()
#16 /srv/mediawiki/php-1.36.0-wmf.28/load.php(38): wfLoadMain()
#17 /srv/mediawiki/w/load.php(3): require(string)
#18 {main}

Details

SubjectRepoBranchLines +/-
objectcache: fix broken for loop in RedisBagOStuff::doSetMulti()mediawiki/corewmf/1.36.0-wmf.28+7 -4
objectcache: fix broken for loop in RedisBagOStuff::doSetMulti()mediawiki/coremaster+7 -4
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 DeclinedReleasedancyT271342 1.36.0-wmf.28 deployment blockers
 ResolvedaaronT273006 MediumSpecificBagOStuff.php Undefined offset errors

Event Timeline

dancy created this task.Jan 26 2021, 9:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 26 2021, 9:00 PM
dancy mentioned this in T271342: 1.36.0-wmf.28 deployment blockers.Jan 26 2021, 9:02 PM
dancy triaged this task as Unbreak Now! priority.Jan 26 2021, 9:05 PM
brennen added projects: User-brennen, MediaWiki-libs-BagOStuff, Platform Engineering.Jan 26 2021, 9:07 PM
brennen subscribed.

Tentatively tagging Platform Engineering, per Developers/Maintainers list.

Reedy added a project: Wikimedia-production-error.Jan 26 2021, 9:07 PM
• holger.knust edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.Jan 26 2021, 9:09 PM
dancy updated the task description. (Show Details)Jan 26 2021, 9:09 PM
• holger.knust moved this task from Inbox to Ready (WIP:5) on the Platform Team Workboards (Clinic Duty Team) board.Jan 26 2021, 9:09 PM
daniel added subscribers: aaron, daniel.Jan 26 2021, 9:10 PM

The code in question was touched yesterday, see https://gerrit.wikimedia.org/r/c/mediawiki/core/+/652572. @aaron, can you have a look?

RhinosF1 subscribed.Jan 26 2021, 9:14 PM
dancy added a parent task: T271342: 1.36.0-wmf.28 deployment blockers.Jan 26 2021, 9:44 PM
brennen moved this task from Backlog to Logs/Train on the User-brennen board.Jan 26 2021, 11:03 PM
aaron added a comment.Jan 27 2021, 3:54 AM

I can repro with

./srv_paratest --filter BagOStuff --use-bagostuff=redis

should be an easy fix.

gerritbot added a comment.Jan 27 2021, 6:09 AM

Change 658780 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] objectcache: fix broken for loop in RedisBagOStuff::doSetMulti()

https://gerrit.wikimedia.org/r/658780

gerritbot added a project: Patch-For-Review.Jan 27 2021, 6:09 AM
Agusbou2015 subscribed.Jan 27 2021, 1:39 PM
dancy added a comment.Jan 27 2021, 5:10 PM

@aaron, is https://gerrit.wikimedia.org/r/658780 sufficient to take care of this problem or do I need https://gerrit.wikimedia.org/r/c/mediawiki/core/+/658781 as well?

hashar subscribed.Jan 27 2021, 6:08 PM
gerritbot added a comment.Jan 27 2021, 7:34 PM

Change 658939 had a related patch set uploaded (by Krinkle; owner: Aaron Schulz):
[mediawiki/core@wmf/1.36.0-wmf.28] objectcache: fix broken for loop in RedisBagOStuff::doSetMulti()

https://gerrit.wikimedia.org/r/658939

Krinkle assigned this task to aaron.Jan 27 2021, 7:38 PM
Krinkle moved this task from Untriaged to Jan 2021 on the Wikimedia-production-error board.
Krinkle moved this task from General to libs/objectcache on the MediaWiki-libs-BagOStuff board.
gerritbot added a comment.Jan 27 2021, 8:05 PM

Change 658780 merged by jenkins-bot:
[mediawiki/core@master] objectcache: fix broken for loop in RedisBagOStuff::doSetMulti()

https://gerrit.wikimedia.org/r/658780

aaron added a comment.Jan 27 2021, 8:32 PM
In T273006#6781053, @dancy wrote:

@aaron, is https://gerrit.wikimedia.org/r/658780 sufficient to take care of this problem or do I need https://gerrit.wikimedia.org/r/c/mediawiki/core/+/658781 as well?

Just the first patch.

gerritbot added a comment.Jan 27 2021, 8:44 PM

Change 658939 merged by jenkins-bot:
[mediawiki/core@wmf/1.36.0-wmf.28] objectcache: fix broken for loop in RedisBagOStuff::doSetMulti()

https://gerrit.wikimedia.org/r/658939

Stashbot added a comment.Jan 27 2021, 8:58 PM

Mentioned in SAL (#wikimedia-operations) [2021-01-27T20:58:49Z] <brennen@deploy1001> Synchronized php-1.36.0-wmf.28/includes/libs/objectcache/RedisBagOStuff.php: Backport: [[gerrit:658780|objectcache: fix broken for loop in RedisBagOStuff::doSetMulti() (T273006)]] (duration: 01m 07s)

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.29; 2021-02-02).Jan 27 2021, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 27 2021, 9:10 PM
brennen added a comment.Jan 27 2021, 9:18 PM

Just the first patch.

This is currently on testwikis. Per conversation with @dancy at train handoff, waiting for validation on that before rolling train forward.

aaron closed this task as Resolved.Jan 27 2021, 9:51 PM

Logstash no longer shows the errors after the deploy.

dancy added a comment.Jan 27 2021, 10:06 PM

Thanks aaron!

DLynch mentioned this in T273634: MediumSpecificBagOStuff undefined index errors on article pages.Feb 2 2021, 3:57 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits