⚓ T279693 .plainlinks doesn’t work with Timeless

Subject	Repo	Branch	Lines +/-
Stop using the legacy skin feature	mediawiki/skins/Timeless	master	+18 -38
Create the `content-links` (and -external) ResourceLoaderSkinModule feature	mediawiki/core	master	+177 -77
Include plain link styling via elements feature	mediawiki/skins/Timeless	master	+1 -0

Status	Subtype	Assigned	Task
Resolved	Release	dancy	T281161 1.37.0-wmf.20 deployment blockers
Resolved		Jdlrobson	T89981 Split the `legacy` feature on ResourceLoaderSkinModule into non-legacy manageable and reusable parts and deprecate use of the feature
Resolved		None	T279455 Release MW 1.36.0
Resolved		thcipriani	T279462 Release 1.36.0-rc.0
Resolved		Jdlrobson	T278576 Remove non-critical path interface styles out of legacy feature into more appropriate homes
Resolved	BUG REPORT	Jdlrobson	T279693 .plainlinks doesn’t work with Timeless

Tacsipacsi created this task.Apr 8 2021, 4:55 PM

I suspect that this appearance of the table of contents is the same root cause.

Smaller text and the title is centered instead of left.

Xaosflux added a subscriber: Jdlrobson.Apr 9 2021, 11:24 AM

Izno mentioned this in T89981: Split the `legacy` feature on ResourceLoaderSkinModule into non-legacy manageable and reusable parts and deprecate use of the feature.Apr 9 2021, 2:27 PM

In T279693#6985564, @Izno wrote:

I suspect that this appearance of the table of contents is the same root cause.

Now a report of the TOC issue for Modern.

PeterBowman subscribed.Apr 10 2021, 6:01 PM

Izno added projects: Modern, Desktop Improvements (Vector 2022).Apr 10 2021, 8:44 PM

In T279693#6985564, @Izno wrote:

I suspect that this appearance of the table of contents is the same root cause.

Smaller text and the title is centered instead of left.

There could certainly be the same root cause, but I'm not seeing what this has to do with missing support for .plainlinks classing. Either this task should be expanded to explain what it is about or this should probably be split to another report.

Vahurzpu subscribed.Apr 12 2021, 12:53 AM

Change 678785 had a related patch set uploaded (by Mainframe98; author: Mainframe98):

[mediawiki/skins/Timeless@master] Stop using the legacy skin feature

https://gerrit.wikimedia.org/r/678785

gerritbot added a project: Patch-For-Review.Apr 13 2021, 7:56 AM

Will investigate

Amorymeltzer subscribed.Apr 15 2021, 11:47 AM

Change 679898 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Timeless@master] Include plain link styling via elements feature

https://gerrit.wikimedia.org/r/679898

gerritbot added a project: Patch-For-Review.Apr 15 2021, 5:41 PM

So I think the issue can be fixed by Timeless enabling the elements feature?
Please raise a new issue for the table of contents. The underline looks like an intentional part of the skin. https://github.com/wikimedia/mediawiki-skins-Timeless/blob/master/resources/screen-common.less#L732

Now a report of the TOC issue for Modern.

Not sure what this has to do with Modern. Please open a new task describing the Modern problem.

Reedy moved this task from Blocker to Not a blocker on the MW-1.36-release board.Apr 15 2021, 6:14 PM

In T279693#7003658, @Jdlrobson wrote:

So I think the issue can be fixed by Timeless enabling the elements feature?
Please raise a new issue for the table of contents. The underline looks like an intentional part of the skin. https://github.com/wikimedia/mediawiki-skins-Timeless/blob/master/resources/screen-common.less#L732

Now a report of the TOC issue for Modern.

Not sure what this has to do with Modern. Please open a new task describing the Modern problem.

I didn't say anything about an underline.