Page MenuHomePhabricator

.plainlinks doesn’t work with Timeless
Closed, ResolvedPublicBUG REPORT

Description

class="plainlinks" doesn’t work on page view using Timeless skin, at least on d:Talk:Q11696. This is a new regression probably in MW-1.36-notes (1.36.0-wmf.38; 2021-04-06) and seems to be caused by b24bff67ed1c/T278575.

Event Timeline

I suspect that this appearance of the table of contents is the same root cause.

Smaller text and the title is centered instead of left.

I suspect that this appearance of the table of contents is the same root cause.

Now a report of the TOC issue for Modern.

I suspect that this appearance of the table of contents is the same root cause.

Smaller text and the title is centered instead of left.

There could certainly be the same root cause, but I'm not seeing what this has to do with missing support for .plainlinks classing. Either this task should be expanded to explain what it is about or this should probably be split to another report.

Change 678785 had a related patch set uploaded (by Mainframe98; author: Mainframe98):

[mediawiki/skins/Timeless@master] Stop using the legacy skin feature

https://gerrit.wikimedia.org/r/678785

Change 679898 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Timeless@master] Include plain link styling via elements feature

https://gerrit.wikimedia.org/r/679898

So I think the issue can be fixed by Timeless enabling the elements feature?
Please raise a new issue for the table of contents. The underline looks like an intentional part of the skin. https://github.com/wikimedia/mediawiki-skins-Timeless/blob/master/resources/screen-common.less#L732

Now a report of the TOC issue for Modern.

Not sure what this has to do with Modern. Please open a new task describing the Modern problem.

So I think the issue can be fixed by Timeless enabling the elements feature?
Please raise a new issue for the table of contents. The underline looks like an intentional part of the skin. https://github.com/wikimedia/mediawiki-skins-Timeless/blob/master/resources/screen-common.less#L732

Now a report of the TOC issue for Modern.

Not sure what this has to do with Modern. Please open a new task describing the Modern problem.

I didn't say anything about an underline.

Smaller text and the title is centered instead of left.

Now at T280285: Table of contents post-legacy styles split font size is smaller and in Timeless has centered heading as requested.

Change 681488 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Create the `content-links` ResourceLoaderSkinModule feature

https://gerrit.wikimedia.org/r/681488

Change 679898 abandoned by Jdlrobson:

[mediawiki/skins/Timeless@master] Include plain link styling via elements feature

Reason:

See https://gerrit.wikimedia.org/r/c/mediawiki/core/ /681488

https://gerrit.wikimedia.org/r/679898

Change 681488 merged by jenkins-bot:

[mediawiki/core@master] Create the `content-links` (and -external) ResourceLoaderSkinModule feature

https://gerrit.wikimedia.org/r/681488

Change 678785 abandoned by Mainframe98:

[mediawiki/skins/Timeless@master] Stop using the legacy skin feature

Reason:

I2d600a7d9768942b331f0de1dd1183e438144ad5 is probably better

https://gerrit.wikimedia.org/r/678785