Page MenuHomePhabricator
Create Task
Maniphest T280276

[Design] Link inspector button style fixes
Closed, ResolvedPublic
Actions

Assigned To
• mewoph
Authored By
RHo
Apr 15 2021, 5:33 PM
Project Tags
Referenced Files
F34407988: Screen Shot 2021-04-19 at 2.14.07 PM.png
Apr 19 2021, 9:18 PM
F34407984: Screen Shot 2021-04-19 at 2.13.24 PM.png
Apr 19 2021, 9:18 PM
F34407986: Screen Shot 2021-04-19 at 2.14.14 PM.png
Apr 19 2021, 9:18 PM
F34401683: link_inspector_desktop.png
Apr 16 2021, 7:37 PM
F34401681: link_inspector_mobile.png
Apr 16 2021, 7:37 PM
F34400382: image.png
Apr 15 2021, 5:33 PM
F34400388: image.png
Apr 15 2021, 5:33 PM
F34400380: image.png
Apr 15 2021, 5:33 PM
Subscribers
Aklapper
Etonkovidova
kostajh
• mewoph
RHo

Description

  1. Selected Yes/No button colour

Expected - Background colour of the selected button is Accent30

image.png (352×116 px, 3 KB)

Actual

image.png (470×138 px, 5 KB)

  1. Preview and Next button icon and text colors

Expected - Preview and Next button icon and text colors should be Base20
Actual - icon and text is in Base10

image.png (202×86 px, 2 KB)

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Add a link: update button colors in link inspectorMewOphaswongsemediawiki/extensions/GrowthExperimentsmaster+27 -6
Customize query in gerrit

Related Objects
Search...

Event Timeline

RHo created this task.Apr 15 2021, 5:33 PM
Herald added a subscriber: Aklapper. · View Herald TranscriptApr 15 2021, 5:33 PM
RHo mentioned this in T269644: Add a link: link inspector.Apr 15 2021, 6:06 PM
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:47 PM
• mewoph claimed this task.EditedApr 16 2021, 5:12 PM
• mewoph moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
• mewoph subscribed.

ToggleButtonWidget's active state is Accent30 (whereas ButtonWidget's is Accent50). @kostajh already implemented this in T269647: Add a link: rejection dialog.

Previous and next buttons are using ButtonWidget's default color so this might need to be overridden.

• mewoph moved this task from Backlog to April 19 - April 23 on the Add-Link-Structured-Task board.Apr 16 2021, 5:13 PM
• mewoph added a subscriber: kostajh.
gerritbot added a comment.Apr 16 2021, 7:34 PM

Change 680413 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add a link: update button colors in link inspector

https://gerrit.wikimedia.org/r/680413

gerritbot added a project: Patch-For-Review.Apr 16 2021, 7:34 PM
• mewoph added a comment.EditedApr 16 2021, 7:37 PM

Mobile

link_inspector_mobile.png (854×1,508 px, 347 KB)

Desktop

link_inspector_desktop.png (1,074×682 px, 149 KB)

• mewoph moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Apr 16 2021, 7:37 PM
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Apr 19 2021, 10:43 AM
kostajh moved this task from April 19 - April 23 to Done / QA on the Add-Link-Structured-Task board.
gerritbot added a comment.Apr 19 2021, 10:54 AM

Change 680413 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add a link: update button colors in link inspector

https://gerrit.wikimedia.org/r/680413

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 19 2021, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Apr 19 2021, 11:10 AM
Etonkovidova moved this task from QA to Design Review on the Growth-Team (Sprint 0 (Growth Team)) board.Apr 19 2021, 9:18 PM
Etonkovidova subscribed.

Moving to @RHo for a quick review. As per the @mewoph screenshots Acdent30 and Base20 seem to be in place. Here are more screenshots:

Screen Shot 2021-04-19 at 2.13.24 PM.png (680×299 px, 72 KB)
Screen Shot 2021-04-19 at 2.14.14 PM.png (682×275 px, 59 KB)
Screen Shot 2021-04-19 at 2.14.07 PM.png (530×301 px, 63 KB)
RHo closed this task as Resolved.Apr 20 2021, 9:45 AM

Super, thanks!

Urbanecm_WMF removed a project: Growth-Team-Filtering.Feb 5 2022, 4:51 PM
Urbanecm_WMF edited projects, added: GrowthExperiments-NewcomerTasks; removed: GrowthExperiments.Jan 21 2026, 2:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits