| RHo | |
| Apr 15 2021, 5:33 PM |
| F34407988: Screen Shot 2021-04-19 at 2.14.07 PM.png | |
| Apr 19 2021, 9:18 PM |
| F34407984: Screen Shot 2021-04-19 at 2.13.24 PM.png | |
| Apr 19 2021, 9:18 PM |
| F34407986: Screen Shot 2021-04-19 at 2.14.14 PM.png | |
| Apr 19 2021, 9:18 PM |
| F34401683: link_inspector_desktop.png | |
| Apr 16 2021, 7:37 PM |
| F34401681: link_inspector_mobile.png | |
| Apr 16 2021, 7:37 PM |
| F34400382: image.png | |
| Apr 15 2021, 5:33 PM |
| F34400388: image.png | |
| Apr 15 2021, 5:33 PM |
| F34400380: image.png | |
| Apr 15 2021, 5:33 PM |
Expected - Background colour of the selected button is Accent30
Actual
Expected - Preview and Next button icon and text colors should be Base20
Actual - icon and text is in Base10
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Add a link: update button colors in link inspector | mediawiki/extensions/GrowthExperiments | master | +27 -6 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | MMiller_WMF | T252822 [EPIC] Growth: "add a link" structured task 1.0 | |||
| Resolved | kostajh | T268704 Add a link: frontend product specifications | |||
| Resolved | • mewoph | T269644 Add a link: link inspector | |||
| Resolved | • mewoph | T280276 [Design] Link inspector button style fixes |
ToggleButtonWidget's active state is Accent30 (whereas ButtonWidget's is Accent50). @kostajh already implemented this in T269647: Add a link: rejection dialog.
Previous and next buttons are using ButtonWidget's default color so this might need to be overridden.
Change 680413 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):
[mediawiki/extensions/GrowthExperiments@master] Add a link: update button colors in link inspector
Change 680413 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Add a link: update button colors in link inspector
Moving to @RHo for a quick review. As per the @mewoph screenshots Acdent30 and Base20 seem to be in place. Here are more screenshots:
 |  |  |
