Page MenuHomePhabricator

Regression: Inconsistent inner top padding in all popup types
Open, HighPublic3 Estimated Story Points

Description

When a popup (doesn't matter which one, Reference Previews, Page-Previews, with or without an image) opens to the bottom (i.e. the little arrow is at the top), the distance from the top corner of the popup to the text is not the full expected 16px but much less. This is because the arrow is part of the 16px margin, not outside of it.

I did a git bisect and narrowed the issue down to this patch:

Before the patch we had 16px all around:

Screenshot from 2021-04-26 10-58-00.png (165×434 px, 16 KB)

After:

Screenshot from 2021-04-26 10-57-41.png (153×428 px, 17 KB)

Event Timeline

Who will be working on this? WMDE or web. I ask as for web this will be a context switch.

We currently don't have plans to pick this ticket up. The impact is very low. We don't know much about the code and the ticket that introduced it (T269336). I gave it a try (as I always do) to see if I can come up with an easy 1-line fix, but wasn't able to. Would be great if you could put this in your backlog.

ovasileva renamed this task from Inconsistent inner top padding in all popup types to Regression: Inconsistent inner top padding in all popup types.May 5 2021, 2:21 PM
ovasileva raised the priority of this task from Medium to High.May 13 2021, 5:46 PM
Jdrewniak added a subscriber: Jdrewniak.

Change 704883 had a related patch set uploaded (by Nray; author: Nray):

[mediawiki/extensions/Popups@master] POC: Adjust top padding of popup to account for clip path

https://gerrit.wikimedia.org/r/704883

POC above. There are several issues going on here (one of which is the text's margin getting clipped as a result of clip-path which @thiemowmde pointed out).

Change 704883 abandoned by Nray:

[mediawiki/extensions/Popups@master] POC: Adjust top padding of popup to account for clip path

Reason:

POC only. Reopen if helpful

https://gerrit.wikimedia.org/r/704883

nray removed nray as the assignee of this task.Fri, Jul 16, 11:17 PM
nray added a subscriber: nray.

Moving to upcoming per my POC patch above

Change 705510 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Popups@master] Remove the page preview icon hacks

https://gerrit.wikimedia.org/r/705510

Change 704883 restored by Jdlrobson:

[mediawiki/extensions/Popups@master] POC: Adjust top padding of popup to account for clip path

https://gerrit.wikimedia.org/r/704883

Change 704883 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Adjust top padding of popup to account for clip path

https://gerrit.wikimedia.org/r/704883

Jdlrobson added a subscriber: Edtadros.

Change 707671 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/extensions/Popups@master] Fix regression with reference previews

https://gerrit.wikimedia.org/r/707671

cjming added a subscriber: cjming.