Page MenuHomePhabricator
Create Task
Maniphest T281352

Broken settings dialogue for reference previews when in conflict with a skin/gadget
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Description

Reference previews on mobile are implemented quite differently from what we provide with the popups extension. If..

  • I am an anonymous user
  • I have reference previews enabled on desktop view
  • Open the mobile view
  • Hover a page preview
  • Get into the settings using the cogwheel
  • I get this view

Settings Checkbox.png (396×705 px, 24 KB)

Which makes no sense.

Viewing references on mobile works completely differently than in desktop view. When you click a footnote in the text on mobile you get a small "popup" with the content of the reference. This has nothing to do with the Popups extension and you don't see reference previews like in the desktop version. So having a checkbox there, that is a setting for the "desktop" reference previews makes no sense. And since the "mobile" reference previews can't be disabled it makes twice no sense.

Even assuming the user understands, that this checkbox is meant for the "desktop" reference previews, it's showing a wrong setting. It's unchecked even though it's not disabled on the desktop view.

We should probably hide the reference preview setting on mobile.

Details

SubjectRepoBranchLines +/-
Fix settings dialog offering ReferencePreviews when unavailablemediawiki/extensions/Popupsmaster+11 -11
Fix settings dialog offering ReferencePreviews when unavailablemediawiki/extensions/Popupswmf/1.37.0-wmf.3+11 -11
Customize query in gerrit

Related Objects

Event Timeline

WMDE-Fisch created this task.Apr 28 2021, 11:07 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 28 2021, 11:07 AM
WMDE-Fisch added a comment.Apr 28 2021, 11:31 AM

Note: If you're a logged in user, the cogwheel from page previews will get you to the preferences page as expected. There you can see both check boxes with the normal the settings. I'm not sure if there should be an extra hint for reference previews working differently on mobile. I guess it's fine. Users on mobile should be used to the behavior with little popups when interacting with references.

WMDE-Fisch renamed this task from Broken setting for reference previews on mobile view to Broken settings dialogue for reference previews on mobile view.Apr 28 2021, 12:42 PM
WMDE-Fisch updated the task description. (Show Details)
thiemowmde added a project: Regression.Apr 28 2021, 1:24 PM
thiemowmde subscribed.

The fact that ReferencePreviews are listed in the dialog is clearly a bug. Since T243822: Reference -Preview and -Popup shown both with Minerva in desktop mode ReferencePreviews are unavailable in the mobile skin (a.k.a. Minerva). In the patch https://gerrit.wikimedia.org/r/680293 (T277640) we introduced a 3-state model where null means a popup type is not available. We forgot to pass this information to the settings dialog. As of now the only thing the settings dialog respects is the BetaFeature flag, but not if there is a conflict with the skin or a gadget.

The same issue happens when a conflicting gadget is enabled for anonymous users. ReferencePreviews are unavailable then and should not show up in the settings dialog.

thiemowmde renamed this task from Broken settings dialogue for reference previews on mobile view to Broken settings dialogue for reference previews when in conflict with a skin/gadget.Apr 28 2021, 1:26 PM
Lena_WMDE edited projects, added WMDE-TechWish-Sprint-2021-04-28; removed WMDE-TechWish.Apr 28 2021, 1:27 PM
thiemowmde claimed this task.Apr 28 2021, 1:33 PM
thiemowmde moved this task from Sprint Backlog to Review on the WMDE-TechWish-Sprint-2021-04-28 board.
thiemowmde set the point value for this task to 2.
thiemowmde changed the subtype of this task from "Task" to "Bug Report".
gerritbot added a comment.Apr 28 2021, 1:35 PM

Change 683280 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Popups@master] Fix settings dialog offering ReferencePreviews when unavailable

https://gerrit.wikimedia.org/r/683280

gerritbot added a project: Patch-For-Review.Apr 28 2021, 1:35 PM
WMDE-Fisch added a project: Unplanned-Sprint-Work.Apr 28 2021, 2:10 PM
awight subscribed.EditedMay 3 2021, 8:21 AM

While testing the patch, I noticed some unrelated issues with the preferences dialog, with ?useformat=mobile:

image.png (208×540 px, 21 KB)

  • Dragging near the close box causes invisible "Cancel" text to be highlighted and show through the button region.
  • Close button hover area has no left margin and is aligned with dialog border.
awight moved this task from Review to Demo on the WMDE-TechWish-Sprint-2021-04-28 board.May 3 2021, 8:30 AM
gerritbot added a comment.May 3 2021, 8:32 AM

Change 683280 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Fix settings dialog offering ReferencePreviews when unavailable

https://gerrit.wikimedia.org/r/683280

gerritbot added a comment.May 3 2021, 8:47 AM

Change 684079 had a related patch set uploaded (by WMDE-Fisch; author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Popups@wmf/1.37.0-wmf.3] Fix settings dialog offering ReferencePreviews when unavailable

https://gerrit.wikimedia.org/r/684079

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.4; 2021-05-04).May 3 2021, 9:00 AM
WMDE-Fisch added a comment.May 3 2021, 9:13 AM

Backport scheduled for today 1pm
https://wikitech.wikimedia.org/w/index.php?title=Deployments&type=revision&diff=1910480&oldid=1910476

gerritbot added a comment.May 3 2021, 11:08 AM

Change 684079 merged by jenkins-bot:

[mediawiki/extensions/Popups@wmf/1.37.0-wmf.3] Fix settings dialog offering ReferencePreviews when unavailable

https://gerrit.wikimedia.org/r/684079

Maintenance_bot removed a project: Patch-For-Review.May 3 2021, 11:10 AM
Stashbot added a comment.May 3 2021, 11:15 AM

Mentioned in SAL (#wikimedia-operations) [2021-05-03T11:15:00Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.3/extensions/Popups/: a438b641c81fa16faba287407012beaff8b1f3ba: Fix settings dialog offering ReferencePreviews when unavailable (T281352) (duration: 00m 58s)

thiemowmde added subscribers: • Niedzielski, Jdlrobson, Esanders.May 3 2021, 11:51 AM

[…] causes invisible "Cancel" text to be highlighted […]

Another way to reproduce this is to press ⌃+A to mark all text. The word "Cancel" is just the screenreader label of the button, made invisible via color: transparent. The code responsible for this is in MinervaNeue in skinStyles/mediawiki.ui.icon/mediawiki.ui.icon.less, as far as I can see. This is all intentional, as far as I can tell. I can find other buttons with the same issue in other places in the mobile skin.

Close button hover area has no left margin and is aligned with dialog border.

Ah, I see. The light gray background when hovering the close button touches the left dialog border. I'm not sure if this is a mistake. The alignment of the "x" looks fine. The active area is the same on desktop and mobile. The only difference is that mobile does have that gray hover effect. I did a quick git bisect and it appears like it was always like this.

I would not create tickets for this, but ask the Web-Team-Backlog team (e.g. @Esanders, @Jdlrobson or @Niedzielski) to decide if this makes sense.

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.3; 2021-04-27); removed MW-1.37-notes (1.37.0-wmf.4; 2021-05-04).May 3 2021, 12:00 PM
Esanders unsubscribed.May 3 2021, 12:41 PM
awight added a comment.May 3 2021, 4:00 PM

Close button hover area has no left margin and is aligned with dialog border.

Ah, I see. The light gray background when hovering the close button touches the left dialog border. I'm not sure if this is a mistake. The alignment of the "x" looks fine. The active area is the same on desktop and mobile. The only difference is that mobile does have that gray hover effect. I did a quick git bisect and it appears like it was always like this.

I just realized this is an edge case, still should be supported but less common than I thought: ordinary mobile doesn't have hover, this is only visible when using the mobile view on desktop.

Jdlrobson added a comment.May 3 2021, 6:01 PM

< The only difference is that mobile does have that gray hover effect.

Not a problem. No need to create a ticket. We'll unifying these slowly and a few differences between Minerva and Vector are to be expected.

Lena_WMDE moved this task from Backlog to Doing on the Reference Previews board.May 4 2021, 1:56 PM
ECohen_WMDE moved this task from Demo to Done on the WMDE-TechWish-Sprint-2021-04-28 board.May 11 2021, 12:24 PM
Lena_WMDE closed this task as Resolved.May 17 2021, 8:50 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits