| Etonkovidova | |
| Apr 30 2021, 11:58 PM |
| F34448954: lack of scrolling animation to context mobile.mov.gif | |
| May 10 2021, 9:51 AM |
| F34445458: next_item_scroll.gif | |
| May 7 2021, 7:15 PM |
| F34439577: desktop_showAnnotationAndInspector.gif | |
| May 3 2021, 10:11 PM |
| F34439583: mobile_showAnnotationAndInspector.gif | |
| May 3 2021, 10:11 PM |
| F34439214: scrolling_back.gif | |
| May 3 2021, 6:13 PM |
| F34436078: viewport_addlink.gif | |
| Apr 30 2021, 11:58 PM |
as reported by @MMiller_WMF
When I advance to the next link, the window only scrolls so that the link is at the very bottom of the window, hiding the link inspector. It should scroll far enough to put the whole inspector comfortably inside the window.
A similar thing applies for tapping “back” on the suggestion. It would be nice if we gave it a more comfortable margin, rather than just putting the suggested link at the very top of the window. See gif below.
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| Add a link: update scroll offset | MewOphaswongse | mediawiki/extensions/GrowthExperiments | master | +14 -3 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | MMiller_WMF | T252822 [EPIC] Growth: "add a link" structured task 1.0 | |||
| Resolved | kostajh | T268704 Add a link: frontend product specifications | |||
| Resolved | • mewoph | T269644 Add a link: link inspector | |||
| Resolved | • mewoph | T281616 Add link: context item should always be visible |
The bottom offset was added along with the changes for T281496: Add a link: virtual keyboard covers the link inspector on mobile. I'll update the top offset so that when navigating back, the annotation appears a bit lower on the page.
Change 684506 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):
[mediawiki/extensions/GrowthExperiments@master] Add a link: update scroll offset
Change 684506 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Add a link: update scroll offset
Moving to Design review. @RHo - I did not see any specific issues, so it's just for overall quick review. If you don't find any issues, you may mark the task as Resolved.
(click to see the animated gif)
Moving to Design review. @RHo - I did not see any specific issues, so it's just for overall quick review. If you don't find any issues, you may mark the task as Resolved.
- Desktop - does the additional "accommodating" scroll looks ok?
(click to see the animated gif)
- Mobile - all looks fine - the context item is always in the viewport and the scrolling is smooth.
Thanks @Etonkovidova - I am not seeing any scrolling motion for either desktop or mobile (see gifs attached below), but this should be taken care of in T278486.
Lack of scrolling animation (CS Beta) on Mobile
