Page MenuHomePhabricator
Create Task
Maniphest T282506

Add a link: Arrow of the box in Arabic not pointing to the words to link
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
• mewoph
Authored By
Dyolf77_WMF
May 11 2021, 1:15 AM
Tags
Referenced Files
F34450605: vector_linkInspector_RTL.png
May 11 2021, 5:17 PM
F34450514: Screen Shot 2021-05-11 at 8.51.57 AM.png
May 11 2021, 3:54 PM
F34450483: Capture d’écran du 2021-05-11 16-30-30.png
May 11 2021, 3:32 PM
F34449695: Capture d'écran Deepin_zone de sélection _20210511021735.png
May 11 2021, 1:18 AM
F34449689: Capture d'écran Deepin_zone de sélection _20210511020912.png
May 11 2021, 1:15 AM
Subscribers
Aklapper
alaa
Dyolf77_WMF
Etonkovidova
kostajh
• mewoph
MMiller_WMF
View All 9 Subscribers

Description

In Arabic Wikipedia (AND with Arabic as the interface language), the arrow on the top of the box that contains the suggested link, doesn't point to the word in the text.

Capture d'écran Deepin_zone de sélection _20210511020912.png (401×637 px, 60 KB)

But if you switch to English, the box is correct.

Details

SubjectRepoBranchLines +/-
Add a link: fix link inspector calculations for RTLmediawiki/extensions/GrowthExperimentswmf/1.37.0-wmf.5+7 -5
Add a link: fix link inspector calculations for RTLmediawiki/extensions/GrowthExperimentsmaster+7 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

Dyolf77_WMF created this task.May 11 2021, 1:15 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptMay 11 2021, 1:15 AM
Restricted Application added subscribers: alaa, Aklapper. · View Herald Transcript
Dyolf77_WMF added a comment.May 11 2021, 1:18 AM

Here with another web browser (Firefox)

Capture d'écran Deepin_zone de sélection _20210511021735.png (800×1 px, 153 KB)

kostajh triaged this task as Medium priority.May 11 2021, 7:08 AM
kostajh moved this task from Backlog to May 10 - May 14 on the Add-Link board.
kostajh edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
kostajh changed the subtype of this task from "Task" to "Bug Report".
kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
MMiller_WMF added a comment.May 11 2021, 3:23 PM

@Dyolf77_WMF -- was this in beta or in production?

MMiller_WMF added a parent task: T269644: Add a link: link inspector.May 11 2021, 3:24 PM
MMiller_WMF added subscribers: kostajh, • mewoph, Tgr, Etonkovidova.
Dyolf77_WMF added a comment.May 11 2021, 3:25 PM
In T282506#7078682, @MMiller_WMF wrote:

@Dyolf77_WMF -- was this in beta or in production?

Both; in Beta and Production

Dyolf77_WMF added a comment.May 11 2021, 3:32 PM

I tried with another browser (Brave) and I have this:

Capture d’écran du 2021-05-11 16-30-30.png (486×771 px, 86 KB)

• mewoph claimed this task.May 11 2021, 3:45 PM
• mewoph moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
• mewoph added a comment.EditedMay 11 2021, 3:54 PM

Breakdown of the issues here:

  • Arrow should point to the word, link inspector should either be aligned with the start or the end of the annotation. The positioning works with legacy Vector template but not with non-legacy. It looks like the current calculation of the link inspector co-ordinates assumes that the left edge of the article is the edge of the viewport. This assumption breaks down in the new Vector template.

Screen Shot 2021-05-11 at 8.51.57 AM.png (770×1 px, 123 KB)

  • Accept and reject buttons can fit on one line, so they shouldn't be on a separate line. I have this fixed locally, will include along with the changes for this patch.
  • Link suggestion doesn't stay highlighted. This should have been addressed by T281774: Ensure link suggestion stays highlighted.
• mewoph added a comment.May 11 2021, 5:17 PM

Vector w/latest changes

vector_linkInspector_RTL.png (2×2 px, 1 MB)

gerritbot added a comment.May 11 2021, 5:20 PM

Change 689174 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add a link: fix link inspector calculations for RTL

https://gerrit.wikimedia.org/r/689174

gerritbot added a project: Patch-For-Review.May 11 2021, 5:20 PM
• mewoph moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.May 11 2021, 5:20 PM
gerritbot added a comment.May 12 2021, 9:41 AM

Change 689542 had a related patch set uploaded (by Kosta Harlan; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.5] Add a link: fix link inspector calculations for RTL

https://gerrit.wikimedia.org/r/689542

kostajh moved this task from May 10 - May 14 to Done / QA on the Add-Link board.May 12 2021, 9:46 AM
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.May 12 2021, 10:02 AM

Change 689174 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add a link: fix link inspector calculations for RTL

https://gerrit.wikimedia.org/r/689174

gerritbot added a comment.May 12 2021, 11:15 AM

Change 689542 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.5] Add a link: fix link inspector calculations for RTL

https://gerrit.wikimedia.org/r/689542

Maintenance_bot removed a project: Patch-For-Review.May 12 2021, 12:10 PM
Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.May 12 2021, 11:11 PM

Checked in betalabs (for Legacy Vector and Vector). Moving to Test in Production.

Etonkovidova closed this task as Resolved.May 18 2021, 2:06 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits