Page MenuHomePhabricator

Add a link: Arrow of the box in Arabic not pointing to the words to link
Closed, ResolvedPublicBUG REPORT

Description

In Arabic Wikipedia (AND with Arabic as the interface language), the arrow on the top of the box that contains the suggested link, doesn't point to the word in the text.

Capture d'écran Deepin_zone de sélection _20210511020912.png (401×637 px, 60 KB)

But if you switch to English, the box is correct.

Event Timeline

Restricted Application added subscribers: alaa, Aklapper. · View Herald Transcript

Here with another web browser (Firefox)

Capture d'écran Deepin_zone de sélection _20210511021735.png (800×1 px, 153 KB)

kostajh triaged this task as Medium priority.May 11 2021, 7:08 AM
kostajh moved this task from Backlog to May 10 - May 14 on the Add-Link board.
kostajh edited projects, added Growth-Team (Current Sprint); removed Growth-Team.
kostajh changed the subtype of this task from "Task" to "Bug Report".

@Dyolf77_WMF -- was this in beta or in production?

Both; in Beta and Production

I tried with another browser (Brave) and I have this:

Capture d’écran du 2021-05-11 16-30-30.png (486×771 px, 86 KB)

Breakdown of the issues here:

  • Arrow should point to the word, link inspector should either be aligned with the start or the end of the annotation. The positioning works with legacy Vector template but not with non-legacy. It looks like the current calculation of the link inspector co-ordinates assumes that the left edge of the article is the edge of the viewport. This assumption breaks down in the new Vector template.

Screen Shot 2021-05-11 at 8.51.57 AM.png (770×1 px, 123 KB)

  • Accept and reject buttons can fit on one line, so they shouldn't be on a separate line. I have this fixed locally, will include along with the changes for this patch.
  • Link suggestion doesn't stay highlighted. This should have been addressed by T281774: Ensure link suggestion stays highlighted.

Change 689174 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add a link: fix link inspector calculations for RTL

https://gerrit.wikimedia.org/r/689174

Change 689542 had a related patch set uploaded (by Kosta Harlan; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.5] Add a link: fix link inspector calculations for RTL

https://gerrit.wikimedia.org/r/689542

Change 689174 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add a link: fix link inspector calculations for RTL

https://gerrit.wikimedia.org/r/689174

Change 689542 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.5] Add a link: fix link inspector calculations for RTL

https://gerrit.wikimedia.org/r/689542

Checked in betalabs (for Legacy Vector and Vector). Moving to Test in Production.