The JS error when there are no more tasks was fixed in a patch merged yesterday, but it has not been backported. Tagging Search team in case they have ideas why the topic search is not working here.

Not ro.wikipedia specific. fr.wikipedia is also affected, see https://fr.wikipedia.org/wiki/Sp%C3%A9cial:NewcomerTasksInfo. Going to query for more affected wikis via eventlogging data.

In T285577#7178193, @Urbanecm_WMF wrote:

Not ro.wikipedia specific. fr.wikipedia is also affected, see https://fr.wikipedia.org/wiki/Sp%C3%A9cial:NewcomerTasksInfo. Going to query for more affected wikis via eventlogging data.

I ran the following spark query to get an idea how widespread this might be (it turns out it is very widespread).

WITH seImpressions AS (
    SELECT
        dt,
        wiki,
        str_to_map(event.action_data, ";", "=") AS action_data
    FROM event.homepagemodule
    WHERE
        year=2021
        AND month=6
        AND day=25
        AND event.action='impression'
        AND event.module='suggested-edits'
),

taskCountData AS (
    SELECT
        wiki,
        action_data['topics'] AS topics,
        action_data['taskCount'] AS task_count_num,
        CASE
            WHEN action_data['taskCount'] == 0 THEN '0'
            ELSE '>1'
        END AS task_count_human
    FROM seImpressions
    WHERE
        action_data['topics'] != ''
)

SELECT
    wiki,
    task_count_human,
    COUNT(*)
FROM taskCountData
GROUP BY wiki, task_count_human
ORDER BY wiki, task_count_human

and got the following results:

This table has a number of users using suggested edits today (on 2021-06-25) with topic filters enabled for each wiki, split by task_count_human (task_count_human is 0 if suggested edits module was empty with no tasks, and >1 otherwise).

I then checked few wikis where zero results was more frequent than non-zero result numbers, and it turns out a lot of wikis are affected, see below:

• bg.wikipedia
• ca.wikipedia
• da.wikipedia (some users managed to load a non-empty task pool though)
• el.wikipedia
• eu.wikipedia
• fa.wikipedia
• fr.wikipedia
• he.wikipedia
• hi.wikipedia
• hr.wikipedia
• hu.wikipedia
• hy.wikipedia
• id.wikipedia
• and many more, lazy to go through all of them.

Basically topic-based filtering is broken at almost all of our wikis (interestingly, all the pilot wikis still sound to work).

I just tested things out on frwiki, plwiki, and fawiki, and here's what I see from the desktop user's perspective. This is on fawiki:

1. When I go to wiki where i already have topics selected, I see this:

2. When I open the topics dialog and unselect all topics, it goes largely back to normal, but it says “1 of undefined suggestions”:

3. Then when I select a topic again, the dialog tells me “0 articles found”:

4. And after returning to the feed, the feed hasn’t visually changed, except that I can't navigate to the second suggestion (i.e. the right arrow does nothing):

This problem does not affect all wikis. After checking 28 wikis that have Growth features, here is what I see:

Change 701609 had a related patch set uploaded (by Ebernhardson; author: Ebernhardson):

[mediawiki/extensions/CirrusSearch@master] Revert "Add support for ores drafttopic" and "Stop querying ores_articletopics"

https://gerrit.wikimedia.org/r/701609

In T283546#7178286, @Stashbot wrote:

Mentioned in SAL (#wikimedia-operations) [2021-06-25T20:21:12Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.11/extensions/GrowthExperiments/modules/homepage/suggestededits/ext.growthExperiments.Homepage.SuggestedEdits.js: eaec745e4504527d23ddca32eb7fcd531d5553f9: SuggestedEdits: Only log task impression for EditCardWidget (T283546; emergency deployment) (duration: 01m 00s)

Cross-linking a deployment attributed to some other task, but actually done due to this one (to make it less broken).

Under the hood this is using articletopic: biology or similar in search which is returning zero results. The most likely cause is our removal of some BC code that was querying the previous field name. Above patch reverts that removal and should bring the wikis back to acceptable functionality for the time being. Critically this old field that it will be referencing is no longer being updated, so this cannot be a long term solution.

The underlying problem appears to be the new weighted_tags field is missing in the mapping for rowiki (and maybe others). The process we use for reindexing, via foreachwikiindblist, is known to be error prone. The wikis that failed reindexing will need to be identified and resolved before re-deploying the patch.

Change 701425 had a related patch set uploaded (by Ebernhardson; author: Ebernhardson):

[mediawiki/extensions/CirrusSearch@wmf/1.37.0-wmf.11] Revert "Add support for ores drafttopic" and "Stop querying ores_articletopics"

https://gerrit.wikimedia.org/r/701425

Change 701609 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] Revert "Add support for ores drafttopic" and "Stop querying ores_articletopics"

https://gerrit.wikimedia.org/r/701609

Change 701425 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@wmf/1.37.0-wmf.11] Revert "Add support for ores drafttopic" and "Stop querying ores_articletopics"

https://gerrit.wikimedia.org/r/701425

This is supposed to be fixed now.

@EBernhardson -- thank you for fixing this. Do you know approximately what the time period was when users experienced this? We want to note it for our analytics.

@Mmiller0712 it would have rolled out with the train, so starting around june 24, 19:00 UTC.