Page MenuHomePhabricator
Create Task
Maniphest T289827

Add an image: task type info in suggested edits module
Closed, ResolvedPublic
Actions

Description

For this task type in the suggested edits module, here are the details on how it should be listed.

  • Unlike other task types, cards for this task should not display the lead image preview for the article (in Iteration 1, none of the articles will have lead images, but that might not be true for future iterations). Instead, we will display a specific "add image" graphic instead (illustration TBC). See T289824: Add an image: mobile preview card

*Updated final copy - see relevant tab for corresponding QQQ in the copy spreadsheet:

  • Title: Add a suggested image
  • Subtitle: Decide whether an image from Wikimedia Commons should be added to the article.
  • Difficulty level is MEDIUM
  • Robot icon precedes the word MEDIUM
  • Estimated time: 3-5 minutes
  • Tooltip from the "i" icon: Suggestions are generated by machine. The images are from Wikimedia Commons, Wikipedia's collection of freely licensed images.[paragraph break]You will decide whether to add them to the article. You'll also write a caption for them.

Mockup:

image.png (1×1 px, 485 KB)

NOTE: Refer to Figma for up-to-date detailed redline mocks and specs:
https://www.figma.com/file/ULhJr1isDstRbGE5vjYDsr/Add-images-structured-task-[Growth]?node-id=3002%3A8962

Details

SubjectRepoBranchLines +/-
Add an image: update copy & QQQs for suggested edits modulemediawiki/extensions/GrowthExperimentsmaster+12 -7
Add Image: Don't show thumbnails on task cardsmediawiki/extensions/GrowthExperimentsmaster+39 -5
Add Image: do not load page image for addimage tasksmediawiki/extensions/GrowthExperimentsmaster+8 -3
Add Image: Fill in placeholder messagesmediawiki/extensions/GrowthExperimentsmaster+10 -10
Customize query in gerrit

Related Objects
Search...

Event Timeline

MMiller_WMF created this task.Aug 27 2021, 12:30 AM
Tgr mentioned this in T289031: Add Image: Enrich task suggestion list with file names.Sep 7 2021, 3:48 AM
MMiller_WMF triaged this task as High priority.Sep 7 2021, 5:09 PM
MMiller_WMF moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
Tgr claimed this task.Sep 8 2021, 2:02 AM
Tgr moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Sep 8 2021, 2:35 AM

Change 719394 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Add Image: Fill in placeholder messages

https://gerrit.wikimedia.org/r/719394

gerritbot added a project: Patch-For-Review.Sep 8 2021, 2:35 AM
gerritbot added a comment.Sep 8 2021, 4:39 AM

Change 719398 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Add Image: do not load page image for addimage tasks

https://gerrit.wikimedia.org/r/719398

gerritbot added a comment.Sep 8 2021, 4:39 AM

Change 719399 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Add Image: Add tasktype-specific CSS class to task cards

https://gerrit.wikimedia.org/r/719399

Tgr moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 8 2021, 4:42 AM

The icon is the standard "no image" icon for now. Will be updated once @RHo is back (or once someone else can figure out SVG exports from Figma - I ended up with zero-byte files).

Tgr mentioned this in T289824: Add an image: mobile preview card.Sep 8 2021, 4:43 AM
• mewoph added a comment.Sep 8 2021, 3:43 PM

Hi @Tgr I was unable to export from Figma either, but here is the SVG from the prototype.

imageSE-Add.svg1 KBDownload

gerritbot added a comment.Sep 8 2021, 6:28 PM

Change 719394 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add Image: Fill in placeholder messages

https://gerrit.wikimedia.org/r/719394

Tgr added a comment.Sep 9 2021, 1:37 AM
In T289827#7339635, @mewoph wrote:

Hi @Tgr I was unable to export from Figma either, but here is the SVG from the prototype.

Thanks! Updated the patch.

gerritbot added a comment.Sep 9 2021, 1:39 PM

Change 719398 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add Image: do not load page image for addimage tasks

https://gerrit.wikimedia.org/r/719398

kostajh added a comment.Sep 13 2021, 9:56 AM

Title: "Add images to articles"
Tooltip from the "i" icon: "Images can help readers understand a subject. [paragraph break] Images are suggested by machine, and you will decide whether to add them to the article. You'll also write a caption for them."

@RHo @MMiller_WMF these messages both use the plural for image but per T290045: Add an image: image inspector we're just showing a single image. Are we using the plural in case in the future we rework the feature to allow the user to decide between multiple images?

Title: "Add images to articles"

As a suggestion, maybe something like "Match an image with an article", might better express to the user what they'll be doing.

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 13 2021, 9:57 AM

The placeholder image is tracked in T289824: Add an image: mobile preview card so I'm moving this to QA.

kostajh updated the task description. (Show Details)Sep 13 2021, 9:57 AM
MMiller_WMF added a comment.Sep 15 2021, 1:03 AM

@kostajh -- the reason it's plural is because we're referring to the many images the user will encounter as they hopefully do many of the tasks. Since our flow keeps feeding them tasks via the post-edit dialog, the idea is that this one explanation of the task will apply to a whole series that they'll encounter.

As a suggestion, maybe something like "Match an image with an article", might better express to the user what they'll be doing.

@RHo and I were talking about this today, and playing with the phrase "choose images". Rita, do you like "Match" any better than "Add"?

RHo updated the task description. (Show Details)Sep 16 2021, 8:53 PM
MMiller_WMF updated the task description. (Show Details)Sep 24 2021, 10:44 PM

I just updated with the latest mockup and Figma link. There were no visual or specifications changes.

gerritbot added a comment.Sep 30 2021, 10:09 AM

Change 719399 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add Image: Don't show thumbnails on task cards

https://gerrit.wikimedia.org/r/719399

Maintenance_bot removed a project: Patch-For-Review.Sep 30 2021, 10:10 AM
MMiller_WMF updated the task description. (Show Details)Oct 1 2021, 8:23 PM
MMiller_WMF mentioned this in T290791: Add an image: guidance content.Oct 13 2021, 11:13 PM
RHo updated the task description. (Show Details)Nov 8 2021, 11:57 AM
RHo mentioned this in T292730: Add an image: copy.Nov 8 2021, 1:56 PM
RHo updated the task description. (Show Details)Nov 8 2021, 7:16 PM
RHo mentioned this in T290910: Add an image: skip button functionality for image inspector.Nov 9 2021, 5:06 PM
gerritbot added a comment.Nov 10 2021, 11:48 PM

Change 738032 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add an image: update copy & QQQs for suggested edits module

https://gerrit.wikimedia.org/r/738032

gerritbot added a project: Patch-For-Review.Nov 10 2021, 11:48 PM
kostajh added a comment.Nov 11 2021, 11:45 AM

Images are suggested by machine from Wikimedia Commons, which is Wikipedia's collection of freely licensed images.

@RHo @MMiller_WMF Wondering if we could consider alternate wording for this; especially as it gets translated to other languages, I could see it being misconstrued. In English, I can read it as if "there is a Wikimedia Commons machine that provides suggestions".

An alternative might be:

Suggestions are generated by machine. The images are from Wikimedia Commons, Wikipedia's collection of freely licensed images.

RHo added a comment.Nov 12 2021, 8:45 PM
In T289827#7498444, @kostajh wrote:

Images are suggested by machine from Wikimedia Commons, which is Wikipedia's collection of freely licensed images.

@RHo @MMiller_WMF Wondering if we could consider alternate wording for this; especially as it gets translated to other languages, I could see it being misconstrued. In English, I can read it as if "there is a Wikimedia Commons machine that provides suggestions".
An alternative might be:

Suggestions are generated by machine. The images are from Wikimedia Commons, Wikipedia's collection of freely licensed images.

I think we were aiming for brevity but agree this slightly longer removes the ambiguity about the machine suggestion source, and is on the tooltip where we can have a longer text field anyway. I've updated with your suggestion @kostajh in the doc and mocks.

RHo updated the task description. (Show Details)Nov 12 2021, 8:46 PM
Wittylama unsubscribed.Nov 12 2021, 9:06 PM
gerritbot added a comment.Nov 12 2021, 9:45 PM

Change 738032 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add an image: update copy & QQQs for suggested edits module

https://gerrit.wikimedia.org/r/738032

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.9; 2021-11-16).Nov 12 2021, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 12 2021, 10:10 PM
QutieBot added a project: QTE-TestingOverview.Nov 17 2021, 6:18 PM
Etonkovidova closed this task as Resolved.Dec 2 2021, 10:58 PM
MMiller_WMF mentioned this in T298107: Add an image: basic components (desktop).Dec 21 2021, 4:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits