Page MenuHomePhabricator

Add an image: skip button functionality for image inspector
Open, HighPublic

Description

"Not sure" is a quiet button that on selection will bring up a confirmation dialog with the following contents (copy TBC):

  • Header: "Not sure about this image?"
  • Body: "Confirm that you’d like to skip this suggestion."
  • First button: "Skip suggestion" This button takes the user to the "no changes post-edit state" described in T290789: Add an image: post-edit dialog Second button: "Cancel". This button closes the dialog and the user is back on the final suggestion, which is where they tapped/clicked that last skip button that opened the dialog.
NOTE: This task is similar to the "Skip all links" behaviour for Add links documented on T269658.

Event Timeline

Hi @MMiller_WMF @RHo — I wanted to clarify a use case that could end up being rather complicated to support.

  1. Start image suggestions task
  2. Skip
  3. Next task is loaded, start task
  4. Click back (via browser button)

With the current setup, the user will see the article from step 1 in edit mode (based on the URL when they left), but without the structured task since the corresponding session for the task has ended. Do we have to show the structured task flow again in this case?

If that's the case, we might have to rework how a session is determined (or consider an article in additional to the homepage as an entry point for structured task). @kostajh @Tgr please correct me if I'm wrong—my understanding is that this will be a new use case where we go from one in-progress task to another (the closest would be the post-edit dialog, but in that case, the session has ended so we don't need to figure out whether to re-start the session).

In the case of the post-edit dialog we use a fresh search result so we know it will be a valid task. When going back to a previous task page, we don't know whether we got here via skip or the user accepting/rejecting (in which case there's no task anymore). Seems to me like a big effort with questionable benefits to try to handle back-navigation in any useful way.

Hi @MMiller_WMF @RHo — I wanted to clarify a use case that could end up being rather complicated to support.

  1. Start image suggestions task
  2. Skip
  3. Next task is loaded, start task
  4. Click back (via browser button)

With the current setup, the user will see the article from step 1 in edit mode (based on the URL when they left), but without the structured task since the corresponding session for the task has ended. Do we have to show the structured task flow again in this case?

If that's the case, we might have to rework how a session is determined (or consider an article in additional to the homepage as an entry point for structured task). @kostajh @Tgr please correct me if I'm wrong—my understanding is that this will be a new use case where we go from one in-progress task to another (the closest would be the post-edit dialog, but in that case, the session has ended so we don't need to figure out whether to re-start the session).

Hi @mewoph - actually we would NOT want to skip directly to the next task. We would actually want to have a similar workflow to as if the user had skipped all links in the add links task whereby they are returned to the suggested edits feed to select the next task.
One thing that is still TBD is that we may instead rename this to be "Not sure" and potentially bring up a set of "Not sure" reasons every Nth time someone presses this button.

mewoph renamed this task from Add an image: skip button functionality for image inspector to Add an image: skip button functionality for image inspector (PLACEHOLDER).Sep 17 2021, 7:39 PM
mewoph moved this task from In Progress to Incoming on the Growth-Team (Current Sprint) board.

Thanks for confirming @RHo — moving this back to Incoming w/placeholder keyword

@RHo -- I'd like to clarify our specifications here. You wrote that when the user taps "Not sure", they should be taken back to their suggested edits feed, with a dialog in between asking them to confirm. This is different than what we do for links: if the user skips all the links and confirms so in the dialog, they are taken to the post-edit dialog state that looks like this (see T269658 for the original specifications for "add a link"):

image.png (1×764 px, 448 KB)

I think we should do the same behavior for both tasks. Which do you prefer? I think we should align to the links behavior, so if a user skips the image, they get to the post-edit dialog to get another suggestion.

@RHo -- I'd like to clarify our specifications here. You wrote that when the user taps "Not sure", they should be taken back to their suggested edits feed, with a dialog in between asking them to confirm. This is different than what we do for links: if the user skips all the links and confirms so in the dialog, they are taken to the post-edit dialog state that looks like this (see T269658 for the original specifications for "add a link"):

image.png (1×764 px, 448 KB)

I think we should do the same behavior for both tasks. Which do you prefer? I think we should align to the links behavior, so if a user skips the image, they get to the post-edit dialog to get another suggestion.

Hi @MMiller_WMF - sure, we can have them go to the (no changes version) post-edit dialog after confirming the image skip. My minor concern is that showing a confirmation to say "are you sure you're not sure" seems like we want to force a decision, which is not so much thte case with image suggestions. However, this is something that can be addressed in the copy since ultimately it's better to have the confirmation in case it is an accidental tap. I've updated the Figma spec and this task description.

RHo renamed this task from Add an image: skip button functionality for image inspector (PLACEHOLDER) to Add an image: skip button functionality for image inspector.Mon, Oct 4, 1:02 PM
RHo updated the task description. (Show Details)
RHo updated the task description. (Show Details)

Hi @RHo I was looking at the existing skipped all dialog for add link. It looks like we are using the default styling from OOUI MessageDialog which is different from the specs in Figma. Can you confirm whether we should be customizing the dialog styles or if we should stick to the default (for both add link & add image tasks)?

Screen Shot 2021-10-12 at 10.14.21 AM.png (1×708 px, 202 KB)

Hi @RHo I was looking at the existing skipped all dialog for add link. It looks like we are using the default styling from OOUI MessageDialog which is different from the specs in Figma. Can you confirm whether we should be customizing the dialog styles or if we should stick to the default (for both add link & add image tasks)?

Screen Shot 2021-10-12 at 10.14.21 AM.png (1×708 px, 202 KB)

Ahhh thanks for noticing @mewoph. In the interest of not increasing scope for v1 let's use the default MessageDialog styles. As an aside, is there a bug in the OOUI dialog though? Your screenshot shows the Skip all button as being wider than the "Review again" action when the expectation would be that they should be equal width.

image.png (680×776 px, 135 KB)

Change 730313 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add an image: Skip funtionality

https://gerrit.wikimedia.org/r/730313

mewoph added a subscriber: Etonkovidova.

Updated skip all dialogs for add link & add image (Note to @Etonkovidova — the change for this required some refactoring of add link's skip all logic so it would be good to check add link as well, thanks!)

Add link:

addlink_updatedSkipDialog.gif (1×754 px, 1 MB)

Add image;

addimage_skipDialog.gif (1×754 px, 1 MB)

Change 730313 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add an image: Skip funtionality

https://gerrit.wikimedia.org/r/730313