Page MenuHomePhabricator

Add an image: post-edit dialog
Closed, ResolvedPublic

Description

Corresponding task from "add a link": T269659: Add a link: post-edit dialog


This task is about the post-edit dialog that users see after they complete an "add an image" task, either by choosing "yes" and adding a caption, or by choosing "no". This is almost exactly the same as the post-edit dialog we built for "add a link", with only two differences:

  • The suggested task should be another "add an image" task from that user's selected topics of interest (as opposed to it being an "add a link" task).
  • If the user has hit their quality gate limit, they get a different interaction. See T293316: Add an image: minimal quality gate.

Other than that, everything is the same, e.g. if the user accepted the image, they get the get one set of messages, and if they rejected the image, they get a different set.

T295878: Structured tasks: Post-edit message widget uses Success style only when an edit is made, else use the Notice style handles the requirement implicit on this task to change the visual styling of the message widget depending on whether there was an edit made.

Event Timeline

MMiller_WMF renamed this task from Add an image: post-edit dialog to Add an image: post-edit dialog (PLACEHOLDER).Sep 11 2021, 1:06 AM
MMiller_WMF updated the task description. (Show Details)
MMiller_WMF renamed this task from Add an image: post-edit dialog (PLACEHOLDER) to Add an image: post-edit dialog.Oct 13 2021, 9:09 PM
MMiller_WMF removed MMiller_WMF as the assignee of this task.
MMiller_WMF updated the task description. (Show Details)
MMiller_WMF removed a subscriber: Mmiller0712.

I'm assuming that users who are opted into the imagerecommendation experiment group will only have "add image" tasks selected by default (e.g. copyedit or other easy tasks won't be selected) – cc @RHo and @MMiller_WMF to confirm that assumption please.

If so, then the first part of this ("show another image suggestion task") will "just work" the way it did for "add link", and then the quality gate aspect will be handled in T293316: Add an image: minimal quality gate

For link recommendations we explicitly override the user's task type preferences, I imagine we'd do the same here.

@kostajh -- yes, we will want the experiment group to only have images tasks by default.

For @RHo review - the Success style is not present anymore. was it a change in specs somewhere?

the mockuptestwiki wmf.9 - add imagetestwiki wmf.9 - add link
Screen Shot 2021-11-30 at 5.42.45 PM.png (730×442 px, 61 KB)
Screen Shot 2021-11-30 at 5.43.41 PM.png (1×766 px, 156 KB)
Screen Shot 2021-11-30 at 5.49.22 PM.png (924×758 px, 102 KB)

The Notice style is present according to the specs:

Screen Shot 2021-11-30 at 5.44.11 PM.png (1×756 px, 147 KB)

Note: Add link when all suggestions were rejected displays "You've published an edit" - should it be changed to something else?

For @RHo review - the Success style is not present anymore. was it a change in specs somewhere?

the mockuptestwiki wmf.9 - add imagetestwiki wmf.9 - add link
Screen Shot 2021-11-30 at 5.42.45 PM.png (730×442 px, 61 KB)
Screen Shot 2021-11-30 at 5.43.41 PM.png (1×766 px, 156 KB)
Screen Shot 2021-11-30 at 5.49.22 PM.png (924×758 px, 102 KB)

Hi @Etonkovidova - yes this should be corrected when T295878 is completed. At the moment the message has been changed for both scenarios (edit made or not), but in fact per T295878 the green success message colour should be used when an edit is made.

The Notice style is present according to the specs:

Screen Shot 2021-11-30 at 5.44.11 PM.png (1×756 px, 147 KB)

Note: Add link when all suggestions were rejected displays "You've published an edit" - should it be changed to something else?

Ahh thanks for noticing this. If no links are published and there are rejected links then the post-edit dialog should use the same message as when the image is not added as shown above (Thanks for reviewing suggestions. Keep going!). I just tested too and it looks like the regression is happening on mobile only and not for desktop, and seems to be occurring on prod (on testwiki) but not beta! I filed this task T296929: [Regression] Incorrect "publish": message on Add a link mobile when there is not edit made

Thanks, @RHo! Since the issues in my comment will be addressed in separate tasks - closing this task as Resolved.