| ovasileva | |
| Nov 17 2021, 4:59 PM |
| F34917459: Screen Shot 2022-01-13 at 2.58.17 PM.png | |
| Jan 13 2022, 11:04 PM |
| F34917457: Screen Shot 2022-01-13 at 2.57.33 PM.png | |
| Jan 13 2022, 11:04 PM |
| F34913045: Screen Shot 2022-01-10 at 6.03.49 AM.png | |
| Jan 10 2022, 2:05 PM |
| F34913043: Screen Shot 2022-01-10 at 6.00.49 AM.png | |
| Jan 10 2022, 2:05 PM |
Expected:
Observed:
Note: some initial debugging done in T284642: Add yellow talk page message banner to non-main namespace pages on mobile
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T295910#7609013 |
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Edits via API should set cookie for anons | mediawiki/core | master | +8 -0 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T278838 Mobile user communication issues ([[Wikipedia:Mobile communication bugs]]) | |||
| Open | None | T240889 Mobile IP editors not given any indication that they have new messages | |||
| Resolved | ovasileva | T284642 Add yellow talk page message banner to non-main namespace pages on mobile | |||
| Resolved | ovasileva | T295910 Yellow talk page message banner appearing inconsistently on edit page |
If I understand correctly, the User-notice tag was not intended to be replicated here (it was just copied whilst creating the subtask), so I'm removing it.
If I'm mistaken, please re-add it, and let us know what you want the Tech News entry to say! Thanks.
Context for what's happening here: https://phabricator.wikimedia.org/T284642#7500475
As part of analysis we should see how the session cookie is set on desktop and make sure it is also set in the mobile editor.
Tagging editing team as perhaps they have some ideas.
On desktop it's set via SubmitAction (called on save or preview). On mobile you'll probably have to set it via an AJAX call. A very ugly hack would be to call the login API, or Special:UserLogin, which always starts a session. A better way would be to just create a new dedicated API endpoint that creates a session, or have the appropriate edit APIs replicate the behavior of SubmitAction.
There's a performance tradeoff (having a session means all requests pass through the edge caches and are served from the main DC) so the ideal solution would be to display the notice via a separate API call which has its own caching semantics. But that looks like a very complicated change (it's a bit alongside the lines of T140664: Achieve predictable MediaWiki routing and cacheable skin data) and IP masking will uproot (possibly obsolete) anon messaging anyway so hardly worth trying now.
Change 745334 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/core@master] Edits via API should set cookie for anons
Above patch should fix this, but it's not clear to me who maintains ApiEditPage. Would that be the editing team?
From Gerrit "All in all, I thing this is good to merge; I'll leave it around for a week or so in case others want to comment. Also adding someone from Platform, just for the FYI."
Have tagged platform engineering on this ticket.
Change 745334 merged by jenkins-bot:
[mediawiki/core@master] Edits via API should set cookie for anons
For QA, please test the wikitext editor as well as the visual editor, as they use different APIs internally. (The change should work for both of them.)
Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA
Test Artifact(s):
In incognito mode, make an edit on desktop site
As logged in user edit https://en.wikipedia.org/w/index.php?title=User_talk:<ip>
Switch to mobile in incognito window and open editor
✅ AC1: Edit notice appears
Wikitext:
Visual Editor:
Status: ❓ Need more info
Environment: testwiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA
Test Artifact(s):
In incognito mode, make an edit on desktop site
As logged in user edit https://en.wikipedia.org/w/index.php?title=User_talk:<ip>
Switch to mobile in incognito window and open editor
✅ AC1: Edit notice appears
Wikitext:
Visual Editor:
@ovasileva , the message notification ends up under the VE Toolbar. IF the test is whether it appears then this passes, but the location of the message under the toolbar should be addressed separately. If the consistency is not just that it shows up, but that it shows up in the right place, then this is a fail. This occurred in Beta as well, but somehow I let it go.
Test Result - Prod
Status: ❓ Need more info
Environment: testwiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NATest Artifact(s):
QA Steps
In incognito mode, make an edit on desktop site
As logged in user edit https://en.wikipedia.org/w/index.php?title=User_talk:<ip>
Switch to mobile in incognito window and open editor
✅ AC1: Edit notice appearsWikitext:
Visual Editor:
@ovasileva , the message notification ends up under the VE Toolbar. IF the test is whether it appears then this passes, but the location of the message under the toolbar should be addressed separately. If the consistency is not just that it shows up, but that it shows up in the right place, then this is a fail. This occurred in Beta as well, but somehow I let it go.
@Edtadros - this is okay - thank you for double-checking! Resolving this one.