Page MenuHomePhabricator

Add the safety translation strings to Extension:WikimediaMessages
Closed, ResolvedPublic

Description

User Story

Add all the safety survey translation strings from T296488: Translations for test survey to Extension:WikimediaMessages so that they can be referenced in the survey configuration.

Technical information

This patch should be deployed before or with the config change to enable the survey. The config change patch should mention in the gerrit commit message above the Bug line a Depends-On: Iasdfsadfa with the change ID of this patch to WikimediaMessages.

Acceptance Criteria

  • Messages have been configured and deployed in WikimediaMessages
  • @TAndic has been notified when the messages are available in translatewiki.net

Event Timeline

Restricted Application added a subscriber: Aklapper. ยท View Herald TranscriptNov 29 2021, 5:25 PM
Jhernandez renamed this task from ... to Add the safety translation strings to Extension:WikimediaMessages.Nov 29 2021, 5:25 PM
Jhernandez updated the task description. (Show Details)

@Jhernandez the existing en message ext-quicksurveys-tst-internal-survey-question uses the template variable {{SITENAME}}, but the strings listed in T296488 use literal text for the site name. The messages should be consistent in terms of variable use across locales. Which way should it be: literal or variable?

jsn.sherman changed the task status from Open to Stalled.Dec 3 2021, 6:00 PM

@jsn.sherman Hey! I forgot adding this context, we did a spike to how that site name and server name should be if it was shared in surveys across many wikis, and this is the task with the answers: T295751: [8h] Dynamically change the survey question based on the project domain

In summary, this is doable:

{{SITENAME}}{{#switch: {{SITENAME}} | Wikimedia Commons | Wikidata | Meta = | #default = <nowiki> </nowiki>({{SERVERNAME}})}}

But given that this survey is going to be deployed only to cawiki and fawiki (maybe) we can simplify that part to:

{{SITENAME}} ({{SERVERNAME}})
jsn.sherman changed the task status from Stalled to Open.Dec 3 2021, 7:17 PM

Thank you ๐Ÿ™ , very helpful!

Change 743489 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):

[mediawiki/extensions/WikimediaMessages@master] Update messages for TST internal survey

https://gerrit.wikimedia.org/r/743489

Okay, I:

  • added the privacy policy message
  • updated the question message
  • reanamed all of the existing keys for this survey in all locales to align with T296486. This rename will avoid invalidating the translation work that's already been done. This makes it quite a bit bigger change than it would otherwise be

Updated based on review feedback. We're now leaving all of the existing messages alone, and just adding new messages to the en and qqq locales.

Change 743489 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMessages@master] Update messages for the GDI safety internal survey

https://gerrit.wikimedia.org/r/743489

@TAndic We have these messages merged in, and I can find the message documentation on translatewiki, but I can't seem to find the messages themselves. Can you check to see if they are available to you?

Adding the WikimediaMessages code project. Please add code project tags so other people who don't know or don't care about team tags can also find this task when searching via projects. Thanks!

Per T297537, we temporarily removed {{SERVERNAME}} from the question and I updated the ca translation to match.