Hi @scblr

The search function has been implemented, please check the latest APK in the ticket description. (the APK is the same as T299233, so you can test them together).

Looks good to me @cooltey – it feels like sometimes the performance of the search is a bit slow. But I think you flagged that in the beginning.

Re: loading indicator – the constant flashing (disappearing/reappearing) of the loading indicator feels suboptimal and is perceived like an error/endless loop (when there are a couple of results). Is there a way to keep the spinner visible at all times? Here’s an example animation:

Thanks!

Hi @scblr

Re: loading indicator – the constant flashing (disappearing/reappearing) of the loading indicator feels suboptimal and is perceived like an error/endless loop (when there are a couple of results). Is there a way to keep the spinner visible at all times? Here’s an example animation:

Please download the latest APK to see the improved filter/search.

After making a couple of implementations, I found out this cannot be achieved easily due to the restriction of the Paging library.

The loading behavior contains Loading and NotLoading, and each 500 item will trigger the Loading and NotLoading status again and again, and that's why you see the progress bar animation keeps flashing.

Now we have a better caching mechanism, which means users will not see the flashing progress bar that often unless they manually refresh (clear the cache) the list.

Or, maybe we can add a static text, such as "Search..." or "Still loading...".

Thanks @cooltey – this looks good to me. What I’m concerned about though is the performance of the search. A delay/lag is most noticeable when typing, hitting the x to delete the search term, hitting the ← button or attempting to scroll. See the attached video on a Pixel 3:

https://www.dropbox.com/s/03812fgpji89ovb/screen-20220330-103330.mp4?dl=0

Is there a way to improve this? E.g. by not loading search results after every character but after users stop typing (e.g. load 0.5s after users stop typing). I’m open to any other suggestions from your end.

Thanks!

Hi @scblr

Thanks @cooltey – this looks good to me. What I’m concerned about though is the performance of the search. A delay/lag is most noticeable when typing, hitting the x to delete the search term, hitting the ← button or attempting to scroll. See the attached video on a Pixel 3:

@Dbrant has found the ultimate solution for searching and filtering, and the performance has been increased incredibly!

Please check the latest APK to see how it has been improved. 😄

@cooltey the performance is incredible now, thanks for collaborating with dmitry! 👏

I noticed that the loading behavior is now different again, could that be? It currently loads like this:

1. Header
2. Content
3. Search bar

Can we change it to this?

1. Header
2. Search bar
3. Content

Search and content can also fade in at the same time if that is easier to implement.

I noticed that the loading behavior is now different again, could that be? It currently loads like this:

@scblr Done. Forgot to move this to design signoff last week 😓

Per our discussion in Slack, I have updated the way of displaying the stats, search bar, and the list. Please check the latest APK to see the changes.

perfect now, thx @cooltey

Testing on 2.7.50400

I moved this to did not pass QA because I was unable to search based on the criteria listed here:

The search allows users to search information in front of them, namely a full text search for dates, edit summaries/previews, time, amount of bytes and username.

I could not figure out how to successfully search for dates, times, or amount of bytes.

Hi @ABorbaWMF

This is expected since I removed the logic of searching dates, times, and bytes from the list because it looks a little bit confused when these texts are highlighted in the search results.

@scblr Please let me know if you need to add the logic back, or if you think it is fine then please help to move to the QA signoff column. Thanks!

thanks @ABorbaWMF for spotting this

@cooltey

(...) because it looks a little bit confused when these texts are highlighted in the search results.

What do you mean by “confused”? Would it be possible to provide screenshots? I think searching by date and time could be of interest, bytes likely not that much (but if we do the others – we can include bytes too).

Let me know if you need designs that illustrate the highlights.

Thanks!

Hi @scblr

Please confirm the final decision from our last conversation that we will have another ticket for an advanced date/time filter for the search function?

In T299234#7931409, @cooltey wrote:

Hi @scblr

Please confirm the final decision from our last conversation that we will have another ticket for an advanced date/time filter for the search function?

Confirmed! ✅

Searching for terms appears to be working on 2.7.50402-r-2022-05-03